linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* question on beacon-loss messages
@ 2013-03-13 22:17 Ben Greear
  2013-03-19 20:22 ` Johannes Berg
  0 siblings, 1 reply; 2+ messages in thread
From: Ben Greear @ 2013-03-13 22:17 UTC (permalink / raw)
  To: linux-wireless

I am wondering, should the rssi_notify() call only be made if 'beacon' is
true?

I'm seeing lots of beacon-miss events, but when I print out the beacon-loss counters,
they are zero (or much smaller than the number of events I see come out of 'iw').



static void ieee80211_mgd_probe_ap(struct ieee80211_sub_if_data *sdata,
				   bool beacon)
{
	struct ieee80211_if_managed *ifmgd = &sdata->u.mgd;
	bool already = false;

	if (!ieee80211_sdata_running(sdata))
		return;

	mutex_lock(&ifmgd->mtx);

	if (!ifmgd->associated)
		goto out;

	mutex_lock(&sdata->local->mtx);

	if (sdata->local->tmp_channel || sdata->local->scanning) {
		mutex_unlock(&sdata->local->mtx);
		goto out;
	}

	if (beacon)
		mlme_dbg_ratelimited(sdata,
				     "detected beacon loss from AP - probing\n");

	ieee80211_cqm_rssi_notify(&sdata->vif,
		NL80211_CQM_RSSI_BEACON_LOSS_EVENT, GFP_KERNEL);


Thanks,
Ben

-- 
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc  http://www.candelatech.com


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: question on beacon-loss messages
  2013-03-13 22:17 question on beacon-loss messages Ben Greear
@ 2013-03-19 20:22 ` Johannes Berg
  0 siblings, 0 replies; 2+ messages in thread
From: Johannes Berg @ 2013-03-19 20:22 UTC (permalink / raw)
  To: Ben Greear; +Cc: linux-wireless

On Wed, 2013-03-13 at 15:17 -0700, Ben Greear wrote:
> I am wondering, should the rssi_notify() call only be made if 'beacon' is
> true?

Yes, it does seem so.

johannes


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2013-03-19 20:22 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-03-13 22:17 question on beacon-loss messages Ben Greear
2013-03-19 20:22 ` Johannes Berg

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).