From: Antonio Quartulli <antonio@open-mesh.com>
To: Johannes Berg <johannes@sipsolutions.net>,
Antonio Quartulli <antonio@meshcoding.com>
Cc: b.a.t.m.a.n@lists.open-mesh.org, linux-wireless@vger.kernel.org,
devel@lists.open80211s.org
Subject: Re: [PATCH 2/7] mac80211: add get_expected_throughput API
Date: Wed, 14 May 2014 23:09:23 +0200 [thread overview]
Message-ID: <5373DB83.2080006@open-mesh.com> (raw)
In-Reply-To: <1398440696.4152.26.camel@jlt4.sipsolutions.net>
[-- Attachment #1: Type: text/plain, Size: 485 bytes --]
On 25/04/14 17:44, Johannes Berg wrote:
> On Mon, 2014-04-14 at 16:03 +0200, Antonio Quartulli wrote:
>
>> + u32 (*get_expected_throughput)(struct ieee80211_sta *sta);
>
> This isn't nice - it forces drivers to conjure up a value.
>
> You should probably at least allow returning 0 for "no idea" or
> something.
Yeah, I think so too. Returning 0 as "I don't know what to provide"
should be fine. I will specify this in the doc.
Cheers,
--
Antonio Quartulli
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 901 bytes --]
next prev parent reply other threads:[~2014-05-14 21:11 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-14 14:03 [PATCH 1/7] cfg80211: export expected throughput through get_station() Antonio Quartulli
2014-04-14 14:03 ` [PATCH 2/7] mac80211: add get_expected_throughput API Antonio Quartulli
2014-04-14 18:00 ` [B.A.T.M.A.N.] " Bastian Bittorf
2014-04-18 0:56 ` Yeoh Chun-Yeow
2014-04-18 6:19 ` Antonio Quartulli
2014-04-25 15:44 ` Johannes Berg
2014-05-14 21:09 ` Antonio Quartulli [this message]
2014-04-14 14:03 ` [PATCH 3/7] mac80211: add new RC API to retrieve expected throughput Antonio Quartulli
2014-04-25 15:45 ` Johannes Berg
2014-05-14 21:14 ` Antonio Quartulli
2014-04-14 14:03 ` [PATCH 4/7] mac80211: export expected throughput in set_sta_info() Antonio Quartulli
2014-04-14 14:03 ` [PATCH 5/7] mac80211: minstrel - implement get_expected_throughput() API Antonio Quartulli
2014-04-25 15:46 ` Johannes Berg
2014-04-25 15:47 ` Antonio Quartulli
2014-04-14 14:03 ` [PATCH 6/7] mac80211: minstrel_ht " Antonio Quartulli
2014-04-14 14:03 ` [PATCH 7/7] cfg80211: implement cfg80211_get_station cfg80211 API Antonio Quartulli
2014-04-25 15:46 ` Johannes Berg
2014-05-14 21:15 ` Antonio Quartulli
2014-04-25 15:44 ` [PATCH 1/7] cfg80211: export expected throughput through get_station() Johannes Berg
2014-05-14 21:27 ` Antonio Quartulli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5373DB83.2080006@open-mesh.com \
--to=antonio@open-mesh.com \
--cc=antonio@meshcoding.com \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
--cc=devel@lists.open80211s.org \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).