* if i deselect PCIEPORTBUS, why are iwlwifi PCIE modules still being compiled?
@ 2014-05-20 7:49 Robert P. J. Day
2014-05-20 8:27 ` Johannes Berg
0 siblings, 1 reply; 6+ messages in thread
From: Robert P. J. Day @ 2014-05-20 7:49 UTC (permalink / raw)
To: linux-wireless
quite possibly a silly question (which has never stopped me before),
but in perusing the PCIE code in the kernel source, i was looking for
sample code to demo in a classroom setting and picked on
drivers/net/wireless/iwlwifi/pcie, which i was *assuming* was
PCIE-dependent -- specifically, i was going to demo the Advanced-N
6235 PCIE wifi card on an intel galileo board.
but i thought it was a bit strange that the pcie/ subdirectory there
doesn't seem to depend on PCIEPORTBUS. as a test, i deselected
PCIEPORTBUS in a configuration and did a rebuild, and the source in
the pcie/ directory was recompiled.
am i misunderstanding the function of the kernel config variable
PCIEPORTBUS? i notice that .../iwlwifi/Makefile includes the line:
iwlwifi-objs += pcie/drv.o pcie/rx.o pcie/tx.o pcie/trans.o
which simply compiles those files with no regard to dependency. can
someone clarify this? thanks.
rday
--
========================================================================
Robert P. J. Day Ottawa, Ontario, CANADA
http://crashcourse.ca
Twitter: http://twitter.com/rpjday
LinkedIn: http://ca.linkedin.com/in/rpjday
========================================================================
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: if i deselect PCIEPORTBUS, why are iwlwifi PCIE modules still being compiled?
2014-05-20 7:49 if i deselect PCIEPORTBUS, why are iwlwifi PCIE modules still being compiled? Robert P. J. Day
@ 2014-05-20 8:27 ` Johannes Berg
2014-05-20 9:28 ` Robert P. J. Day
2014-05-20 9:34 ` Arend van Spriel
0 siblings, 2 replies; 6+ messages in thread
From: Johannes Berg @ 2014-05-20 8:27 UTC (permalink / raw)
To: Robert P. J. Day; +Cc: linux-wireless
On Tue, 2014-05-20 at 03:49 -0400, Robert P. J. Day wrote:
> quite possibly a silly question (which has never stopped me before),
> but in perusing the PCIE code in the kernel source, i was looking for
> sample code to demo in a classroom setting and picked on
> drivers/net/wireless/iwlwifi/pcie, which i was *assuming* was
> PCIE-dependent -- specifically, i was going to demo the Advanced-N
> 6235 PCIE wifi card on an intel galileo board.
>
> but i thought it was a bit strange that the pcie/ subdirectory there
> doesn't seem to depend on PCIEPORTBUS. as a test, i deselected
> PCIEPORTBUS in a configuration and did a rebuild, and the source in
> the pcie/ directory was recompiled.
>
> am i misunderstanding the function of the kernel config variable
> PCIEPORTBUS? i notice that .../iwlwifi/Makefile includes the line:
>
> iwlwifi-objs += pcie/drv.o pcie/rx.o pcie/tx.o pcie/trans.o
>
> which simply compiles those files with no regard to dependency. can
> someone clarify this? thanks.
The whole driver depends on CONFIG_PCI, maybe it should depend on
something more PCIe specific, but that wasn't easy to sort out, and the
APIs it needs aren't PCIe specific afaict.
johannes
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: if i deselect PCIEPORTBUS, why are iwlwifi PCIE modules still being compiled?
2014-05-20 8:27 ` Johannes Berg
@ 2014-05-20 9:28 ` Robert P. J. Day
2014-05-20 10:20 ` Johannes Berg
2014-05-20 9:34 ` Arend van Spriel
1 sibling, 1 reply; 6+ messages in thread
From: Robert P. J. Day @ 2014-05-20 9:28 UTC (permalink / raw)
To: Johannes Berg; +Cc: linux-wireless
On Tue, 20 May 2014, Johannes Berg wrote:
> On Tue, 2014-05-20 at 03:49 -0400, Robert P. J. Day wrote:
> > quite possibly a silly question (which has never stopped me before),
> > but in perusing the PCIE code in the kernel source, i was looking for
> > sample code to demo in a classroom setting and picked on
> > drivers/net/wireless/iwlwifi/pcie, which i was *assuming* was
> > PCIE-dependent -- specifically, i was going to demo the Advanced-N
> > 6235 PCIE wifi card on an intel galileo board.
> >
> > but i thought it was a bit strange that the pcie/ subdirectory there
> > doesn't seem to depend on PCIEPORTBUS. as a test, i deselected
> > PCIEPORTBUS in a configuration and did a rebuild, and the source in
> > the pcie/ directory was recompiled.
> >
> > am i misunderstanding the function of the kernel config variable
> > PCIEPORTBUS? i notice that .../iwlwifi/Makefile includes the line:
> >
> > iwlwifi-objs += pcie/drv.o pcie/rx.o pcie/tx.o pcie/trans.o
> >
> > which simply compiles those files with no regard to dependency. can
> > someone clarify this? thanks.
>
> The whole driver depends on CONFIG_PCI, maybe it should depend on
> something more PCIe specific, but that wasn't easy to sort out, and
> the APIs it needs aren't PCIe specific afaict.
ok, i'll have to think about that for a few minutes. am i at least
correct in my understanding that, technically, the kernel config
option PCIEPORTBUS is supposed to control whether one wants basic PCIE
support or not?
rday
--
========================================================================
Robert P. J. Day Ottawa, Ontario, CANADA
http://crashcourse.ca
Twitter: http://twitter.com/rpjday
LinkedIn: http://ca.linkedin.com/in/rpjday
========================================================================
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: if i deselect PCIEPORTBUS, why are iwlwifi PCIE modules still being compiled?
2014-05-20 8:27 ` Johannes Berg
2014-05-20 9:28 ` Robert P. J. Day
@ 2014-05-20 9:34 ` Arend van Spriel
1 sibling, 0 replies; 6+ messages in thread
From: Arend van Spriel @ 2014-05-20 9:34 UTC (permalink / raw)
To: Johannes Berg; +Cc: Robert P. J. Day, linux-wireless
On 05/20/14 10:27, Johannes Berg wrote:
> On Tue, 2014-05-20 at 03:49 -0400, Robert P. J. Day wrote:
>> quite possibly a silly question (which has never stopped me before),
>> but in perusing the PCIE code in the kernel source, i was looking for
>> sample code to demo in a classroom setting and picked on
>> drivers/net/wireless/iwlwifi/pcie, which i was *assuming* was
>> PCIE-dependent -- specifically, i was going to demo the Advanced-N
>> 6235 PCIE wifi card on an intel galileo board.
>>
>> but i thought it was a bit strange that the pcie/ subdirectory there
>> doesn't seem to depend on PCIEPORTBUS. as a test, i deselected
>> PCIEPORTBUS in a configuration and did a rebuild, and the source in
>> the pcie/ directory was recompiled.
>>
>> am i misunderstanding the function of the kernel config variable
>> PCIEPORTBUS? i notice that .../iwlwifi/Makefile includes the line:
>>
>> iwlwifi-objs += pcie/drv.o pcie/rx.o pcie/tx.o pcie/trans.o
>>
>> which simply compiles those files with no regard to dependency. can
>> someone clarify this? thanks.
>
> The whole driver depends on CONFIG_PCI, maybe it should depend on
> something more PCIe specific, but that wasn't easy to sort out, and the
> APIs it needs aren't PCIe specific afaict.
Correct. A number of PCIe specific calls are under CONFIG_PCI, ie.
pcie_capability_*() et al.
Regards,
Arend
> johannes
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: if i deselect PCIEPORTBUS, why are iwlwifi PCIE modules still being compiled?
2014-05-20 9:28 ` Robert P. J. Day
@ 2014-05-20 10:20 ` Johannes Berg
2014-05-20 10:26 ` Robert P. J. Day
0 siblings, 1 reply; 6+ messages in thread
From: Johannes Berg @ 2014-05-20 10:20 UTC (permalink / raw)
To: Robert P. J. Day; +Cc: linux-wireless
On Tue, 2014-05-20 at 05:28 -0400, Robert P. J. Day wrote:
> > The whole driver depends on CONFIG_PCI, maybe it should depend on
> > something more PCIe specific, but that wasn't easy to sort out, and
> > the APIs it needs aren't PCIe specific afaict.
>
> ok, i'll have to think about that for a few minutes. am i at least
> correct in my understanding that, technically, the kernel config
> option PCIEPORTBUS is supposed to control whether one wants basic PCIE
> support or not?
I don't know, sorry.
johannes
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: if i deselect PCIEPORTBUS, why are iwlwifi PCIE modules still being compiled?
2014-05-20 10:20 ` Johannes Berg
@ 2014-05-20 10:26 ` Robert P. J. Day
0 siblings, 0 replies; 6+ messages in thread
From: Robert P. J. Day @ 2014-05-20 10:26 UTC (permalink / raw)
To: Johannes Berg; +Cc: linux-wireless
On Tue, 20 May 2014, Johannes Berg wrote:
> On Tue, 2014-05-20 at 05:28 -0400, Robert P. J. Day wrote:
>
> > > The whole driver depends on CONFIG_PCI, maybe it should depend on
> > > something more PCIe specific, but that wasn't easy to sort out, and
> > > the APIs it needs aren't PCIe specific afaict.
> >
> > ok, i'll have to think about that for a few minutes. am i at least
> > correct in my understanding that, technically, the kernel config
> > option PCIEPORTBUS is supposed to control whether one wants basic PCIE
> > support or not?
>
> I don't know, sorry.
ok, i think i'll go hassle people on the linux-pci list about this,
thanks for your patience.
rday
--
========================================================================
Robert P. J. Day Ottawa, Ontario, CANADA
http://crashcourse.ca
Twitter: http://twitter.com/rpjday
LinkedIn: http://ca.linkedin.com/in/rpjday
========================================================================
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-05-20 10:28 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-05-20 7:49 if i deselect PCIEPORTBUS, why are iwlwifi PCIE modules still being compiled? Robert P. J. Day
2014-05-20 8:27 ` Johannes Berg
2014-05-20 9:28 ` Robert P. J. Day
2014-05-20 10:20 ` Johannes Berg
2014-05-20 10:26 ` Robert P. J. Day
2014-05-20 9:34 ` Arend van Spriel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).