New iwlwifi warning

New iwlwifi warning

[Linus Torvalds]

I only noticed now, because it doesn't cause any issues, but that may
be because this only happens on my desktop, and I don't actually use
the wireless there...

The WARN_ON in iwl_trans_configure() has started triggering as of this
merge window:

        WARN_ON(iwl_cmd_groups_verify_sorted(trans_cfg));

and causes the appended warning at bootup.

Comments? Anything in particular you need from me for debugging?

                Linus

---

    WARNING: CPU: 3 PID: 2060 at
drivers/net/wireless/intel/iwlwifi/mvm/../iwl-trans.h:1158
iwl_op_mode_mvm_start+0x969/0x970 [iwlmvm]
    Modules linked in: iwlmvm(+) mac80211 libarc4 snd_hda_codec_hdmi
snd_hda_intel snd_intel_dspcfg snd_usb_audio(+) btusb snd_hda_codec
btrtl btintel btbcm iwlwifi ...
    CPU: 3 PID: 2060 Comm: modprobe Not tainted 6.6.0-16167-g045c47737fc1 #19
    Hardware name: Gigabyte Technology Co., Ltd. TRX40 AORUS
MASTER/TRX40 AORUS MASTER, BIOS F5c 03/05/2020
    RIP: 0010:iwl_op_mode_mvm_start+0x969/0x970 [iwlmvm]
    Code: 41 5e 41 5f 5d c3 48 c7 c7 11 89 6f c1 48 c7 c6 97 88 6f c1
e8 58 b0 4e fc b8 01 00 00 00 e9 cd fb ff ff 0f 0b e9 d4 fe ff ff <0f>
0b e9 ac fc ff ff 0f 1f 44 00 00 41 56 53 48 89 fb 4c 8d 77 08
    RSP: 0018:ffffc90003c8b9e8 EFLAGS: 00010286
    RAX: 00000000ffffffff RBX: ffffc90003c8b9f0 RCX: ffffffffc16eef00
    RDX: 0000000000000000 RSI: 0000000000000002 RDI: ffffffffc16ef590
    RBP: ffff8881146bc028 R08: 0000000000000090 R09: 0000000000000070
    R10: 0000000000000070 R11: 00000000000000ff R12: ffff88815c789fc8
    R13: ffff88811cdaa014 R14: ffff88815c789fc0 R15: ffff8881602d3a40
    FS:  00007efcc530c740(0000) GS:ffff888ffe0c0000(0000) knlGS:0000000000000000
    CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
    CR2: 00007efcc4d06910 CR3: 000000015a002000 CR4: 0000000000350ef0
    Call Trace:
     <TASK>
     ? __warn+0xc0/0x190
     ? iwl_op_mode_mvm_start+0x969/0x970 [iwlmvm]
     ? report_bug+0x12f/0x1b0
     ? handle_bug+0x3d/0x70
     ? exc_invalid_op+0x16/0x40
     ? asm_exc_invalid_op+0x16/0x20
     ? iwl_op_mode_mvm_start+0x969/0x970 [iwlmvm]
     ? iwl_op_mode_mvm_start+0x614/0x970 [iwlmvm]
     _iwl_op_mode_start+0x5a/0xc0 [iwlwifi]
     iwl_opmode_register+0x88/0xb0 [iwlwifi]
     ? 0xffffffffc0468000
     init_module+0x23/0x1000 [iwlmvm]
     ? 0xffffffffc0468000
     do_one_initcall+0x116/0x2c0
     do_init_module+0xdb/0x2f0
     __x64_sys_finit_module+0x341/0x370
     do_syscall_64+0x40/0xe0
     entry_SYSCALL_64_after_hwframe+0x46/0x4e

Re: New iwlwifi warning

[Kalle Valo]

Linus Torvalds <torvalds@linux-foundation.org> writes:

> I only noticed now, because it doesn't cause any issues, but that may
> be because this only happens on my desktop, and I don't actually use
> the wireless there...
>
> The WARN_ON in iwl_trans_configure() has started triggering as of this
> merge window:
>
>         WARN_ON(iwl_cmd_groups_verify_sorted(trans_cfg));
>
> and causes the appended warning at bootup.
>
> Comments? Anything in particular you need from me for debugging?
>
>                 Linus
>
> ---
>
>     WARNING: CPU: 3 PID: 2060 at
> drivers/net/wireless/intel/iwlwifi/mvm/../iwl-trans.h:1158
> iwl_op_mode_mvm_start+0x969/0x970 [iwlmvm]

I investigated a bit and at least two other people have reported this
warning but I couldn't find any fix:

https://lore.kernel.org/lkml/2fa930bb-54dd-4942-a88d-05a47c8e9731@gmail.com/T/

Adding also Johannes and Miri.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

Re: New iwlwifi warning

[Bagas Sanjaya]

[-- Attachment #1: Type: text/plain, Size: 1304 bytes --]

On Sun, Nov 12, 2023 at 09:22:06AM +0200, Kalle Valo wrote:
> Linus Torvalds <torvalds@linux-foundation.org> writes:
> 
> > I only noticed now, because it doesn't cause any issues, but that may
> > be because this only happens on my desktop, and I don't actually use
> > the wireless there...
> >
> > The WARN_ON in iwl_trans_configure() has started triggering as of this
> > merge window:
> >
> >         WARN_ON(iwl_cmd_groups_verify_sorted(trans_cfg));
> >
> > and causes the appended warning at bootup.
> >
> > Comments? Anything in particular you need from me for debugging?
> >
> >                 Linus
> >
> > ---
> >
> >     WARNING: CPU: 3 PID: 2060 at
> > drivers/net/wireless/intel/iwlwifi/mvm/../iwl-trans.h:1158
> > iwl_op_mode_mvm_start+0x969/0x970 [iwlmvm]
> 
> I investigated a bit and at least two other people have reported this
> warning but I couldn't find any fix:
> 
> https://lore.kernel.org/lkml/2fa930bb-54dd-4942-a88d-05a47c8e9731@gmail.com/T/
> 
> Adding also Johannes and Miri.
> 

It seems like the culprit authour from the above regression report
(Anjaneyulu) missed the report (AFK?). Cc'ing him anyways. If there's
no response from him, let's revert the culprit.

Thanks.

-- 
An old man doll... just what I always wanted! - Clara

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: New iwlwifi warning

[Johannes Berg]

On Sat, 2023-11-11 at 14:34 -0800, Linus Torvalds wrote:
> I only noticed now, because it doesn't cause any issues, but that may
> be because this only happens on my desktop, and I don't actually use
> the wireless there...
> 

For the record, it's just for debug prints. Not sure how the ordering
issue slipped through though.

I've converted some other checks we had to kunit tests, maybe we should
convert this one too, it's not critical and kunit tests can even run
without loading the hardware, unlike this.

johannes