From: Ben Greear <greearb@candelatech.com>
To: Christian Lamparter <chunkeey@gmail.com>,
Ansuel Smith <ansuelsmth@gmail.com>
Cc: Kalle Valo <kvalo@codeaurora.org>,
linux-wireless@vger.kernel.org, ath10k@lists.infradead.org
Subject: Re: new "[1/2] ath10k: Try to get mac-address from dts"
Date: Thu, 28 Oct 2021 13:35:43 -0700 [thread overview]
Message-ID: <5a2bc68a-603c-9a8a-0e7c-eb69b3045dc7@candelatech.com> (raw)
In-Reply-To: <e6936f55-6ca7-209c-8c3f-5eeae879c9dc@gmail.com>
On 10/28/21 1:29 PM, Christian Lamparter wrote:
> On 28/10/2021 20:57, Ansuel Smith wrote:
>>>
>>> The "[1/2] ath10k: Try to get mac-address from dts" patch
>>> will need a respin, so it can apply cleanly.
>>>
>>> Is Anyone interested? If not, I can take a shot at it on Saturday.
>>>
>>
>> A refreshed patch is applied to atk10k-ct repo so it would be good to
>> have the same patch on normal ath10k. Many router would benefit
>> from that.
>
> Found it!
>
> https://github.com/greearb/ath10k-ct/commit/e6a7d5b5b834737cd12e357b5efdc2e42d923bf6.patch
>
> Hmm, Author is now "Ben" and the whole commit message is gone.
> Now, adding the commit message back from your original patch
> is not a problem, but the missing "Signed-off-by" from him and
> you might be.
> ...
>
> But then, do we need it? Because there might be the option to extend
> device_get_mac_address() instead?! ...
I applied this since owrt was using it and it decreased out-of-tree patches,
and it does not break my (non-owrt) use case. Other than that, I don't know much
about this patch...
If it is decided this patch should go away, please let me know so I can adjust
ath10k-ct accordingly.
Thanks
Ben
--
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc http://www.candelatech.com
next prev parent reply other threads:[~2021-10-28 20:35 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-16 23:46 [PATCH v2] ath10k: fetch (pre-)calibration data via nvmem subsystem Christian Lamparter
2021-10-28 8:58 ` Kalle Valo
2021-10-28 11:31 ` Christian Lamparter
2021-10-28 11:39 ` Ansuel Smith
2021-10-28 11:52 ` Kalle Valo
2021-10-28 18:50 ` Christian Lamparter
2021-10-28 18:57 ` Ansuel Smith
2021-10-28 20:29 ` new "[1/2] ath10k: Try to get mac-address from dts" Christian Lamparter
2021-10-28 20:35 ` Ben Greear [this message]
2021-10-28 20:38 ` Ansuel Smith
2021-11-01 14:25 ` [PATCH v2] ath10k: fetch (pre-)calibration data via nvmem subsystem Kalle Valo
2021-11-01 14:17 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5a2bc68a-603c-9a8a-0e7c-eb69b3045dc7@candelatech.com \
--to=greearb@candelatech.com \
--cc=ansuelsmth@gmail.com \
--cc=ath10k@lists.infradead.org \
--cc=chunkeey@gmail.com \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).