* [PATCH v2] staging: rtl8723bs: remove re-positioned call to kfree in os_dep/ioctl_cfg80211.c
@ 2017-04-27 22:50 Ian W MORRISON
2017-04-30 20:56 ` Hans de Goede
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Ian W MORRISON @ 2017-04-27 22:50 UTC (permalink / raw)
To: linux-wireless
Cc: Bastien Nocera, Larry Finger, Hans de Goede, Greg KH, Jes Sorensen
This patch is to remove the re-positioned call to kfree() in
drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c which otherwise
results in segmentation fault.
Signed-off-by: Ian W Morrison <linuxium@linuxium.com.au>
---
| 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c
b/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c
index f17f4fb..2ee9df5 100644
--- a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c
+++ b/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c
@@ -3527,7 +3527,6 @@ int rtw_wdev_alloc(struct adapter *padapter,
struct device *dev)
pwdev_priv->power_mgmt = true;
else
pwdev_priv->power_mgmt = false;
- kfree((u8 *)wdev);
return ret;
--
1.9.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH v2] staging: rtl8723bs: remove re-positioned call to kfree in os_dep/ioctl_cfg80211.c
2017-04-27 22:50 [PATCH v2] staging: rtl8723bs: remove re-positioned call to kfree in os_dep/ioctl_cfg80211.c Ian W MORRISON
@ 2017-04-30 20:56 ` Hans de Goede
2017-05-05 17:47 ` Ian W MORRISON
2017-05-06 14:46 ` Greg KH
2 siblings, 0 replies; 5+ messages in thread
From: Hans de Goede @ 2017-04-30 20:56 UTC (permalink / raw)
To: Ian W MORRISON, linux-wireless
Cc: Bastien Nocera, Larry Finger, Greg KH, Jes Sorensen
Hi,
On 28-04-17 00:50, Ian W MORRISON wrote:
> This patch is to remove the re-positioned call to kfree() in
> drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c which otherwise
> results in segmentation fault.
>
> Signed-off-by: Ian W Morrison <linuxium@linuxium.com.au>
Patch looks good to me:
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Regards,
Hans
> ---
> drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c
> b/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c
> index f17f4fb..2ee9df5 100644
> --- a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c
> +++ b/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c
> @@ -3527,7 +3527,6 @@ int rtw_wdev_alloc(struct adapter *padapter,
> struct device *dev)
> pwdev_priv->power_mgmt = true;
> else
> pwdev_priv->power_mgmt = false;
> - kfree((u8 *)wdev);
>
> return ret;
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] staging: rtl8723bs: remove re-positioned call to kfree in os_dep/ioctl_cfg80211.c
2017-04-27 22:50 [PATCH v2] staging: rtl8723bs: remove re-positioned call to kfree in os_dep/ioctl_cfg80211.c Ian W MORRISON
2017-04-30 20:56 ` Hans de Goede
@ 2017-05-05 17:47 ` Ian W MORRISON
2017-05-06 14:46 ` Greg KH
2017-05-06 14:46 ` Greg KH
2 siblings, 1 reply; 5+ messages in thread
From: Ian W MORRISON @ 2017-05-05 17:47 UTC (permalink / raw)
To: driverdev-devel
Cc: Bastien Nocera, Larry Finger, Hans de Goede, Greg KH,
Jes Sorensen, linux-wireless
The following patch was sent to linux-wireless@vger.kernel.org and
various wifi driver developers however I've just realized that I
should have sent it to driverdev-devel@linuxdriverproject.org. It was
reviewed on 01 May with the following comment: "Patch looks good to
me: Reviewed-by: Hans de Goede <hdegoede@redhat.com>".
This patch is to remove the re-positioned call to kfree() in
drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c which otherwise
results in segmentation fault.
Signed-off-by: Ian W Morrison <linuxium@linuxium.com.au>
---
drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c
b/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c
index f17f4fb..2ee9df5 100644
--- a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c
+++ b/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c
@@ -3527,7 +3527,6 @@ int rtw_wdev_alloc(struct adapter *padapter,
struct device *dev)
pwdev_priv->power_mgmt = true;
else
pwdev_priv->power_mgmt = false;
- kfree((u8 *)wdev);
return ret;
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH v2] staging: rtl8723bs: remove re-positioned call to kfree in os_dep/ioctl_cfg80211.c
2017-05-05 17:47 ` Ian W MORRISON
@ 2017-05-06 14:46 ` Greg KH
0 siblings, 0 replies; 5+ messages in thread
From: Greg KH @ 2017-05-06 14:46 UTC (permalink / raw)
To: Ian W MORRISON
Cc: driverdev-devel, Jes Sorensen, linux-wireless, Hans de Goede,
Bastien Nocera, Larry Finger
On Sat, May 06, 2017 at 03:47:50AM +1000, Ian W MORRISON wrote:
> The following patch was sent to linux-wireless@vger.kernel.org and
> various wifi driver developers however I've just realized that I
> should have sent it to driverdev-devel@linuxdriverproject.org. It was
> reviewed on 01 May with the following comment: "Patch looks good to
> me: Reviewed-by: Hans de Goede <hdegoede@redhat.com>".
>
> This patch is to remove the re-positioned call to kfree() in
> drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c which otherwise
> results in segmentation fault.
>
> Signed-off-by: Ian W Morrison <linuxium@linuxium.com.au>
> ---
> drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c
> b/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c
> index f17f4fb..2ee9df5 100644
> --- a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c
> +++ b/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c
> @@ -3527,7 +3527,6 @@ int rtw_wdev_alloc(struct adapter *padapter,
> struct device *dev)
> pwdev_priv->power_mgmt = true;
> else
> pwdev_priv->power_mgmt = false;
> - kfree((u8 *)wdev);
>
> return ret;
Whitespace is also messed up here :(
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] staging: rtl8723bs: remove re-positioned call to kfree in os_dep/ioctl_cfg80211.c
2017-04-27 22:50 [PATCH v2] staging: rtl8723bs: remove re-positioned call to kfree in os_dep/ioctl_cfg80211.c Ian W MORRISON
2017-04-30 20:56 ` Hans de Goede
2017-05-05 17:47 ` Ian W MORRISON
@ 2017-05-06 14:46 ` Greg KH
2 siblings, 0 replies; 5+ messages in thread
From: Greg KH @ 2017-05-06 14:46 UTC (permalink / raw)
To: Ian W MORRISON
Cc: linux-wireless, Bastien Nocera, Larry Finger, Hans de Goede,
Jes Sorensen
On Fri, Apr 28, 2017 at 08:50:05AM +1000, Ian W MORRISON wrote:
> This patch is to remove the re-positioned call to kfree() in
> drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c which otherwise
> results in segmentation fault.
>
> Signed-off-by: Ian W Morrison <linuxium@linuxium.com.au>
> ---
> drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c
> b/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c
> index f17f4fb..2ee9df5 100644
> --- a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c
> +++ b/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c
> @@ -3527,7 +3527,6 @@ int rtw_wdev_alloc(struct adapter *padapter,
> struct device *dev)
> pwdev_priv->power_mgmt = true;
> else
> pwdev_priv->power_mgmt = false;
> - kfree((u8 *)wdev);
>
> return ret;
>
Patch has whitespace all turned into spaces :(
Please fix up.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-05-06 14:47 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-04-27 22:50 [PATCH v2] staging: rtl8723bs: remove re-positioned call to kfree in os_dep/ioctl_cfg80211.c Ian W MORRISON
2017-04-30 20:56 ` Hans de Goede
2017-05-05 17:47 ` Ian W MORRISON
2017-05-06 14:46 ` Greg KH
2017-05-06 14:46 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).