archive mirror
 help / color / mirror / Atom feed
From: Arend van Spriel <>
To: "Russell Joyce" <>,
	"Rafał Miłecki" <>
Cc: "Alan Millard" <>,
	"Franky Lin" <>,
	"Hante Meuleman" <>,
	"Chi-Hsien Lin" <>,
	"Wright Feng" <>,
	"Kalle Valo" <>,
	"Marc Kleine-Budde" <>,
	"Marcel Holtmann" <>,
	"Michael S. Tsirkin" <>,
	"Pieter-Paul Giesberts" <>,
	"Rafał Miłecki" <>,
	"" <>,
	"James Hughes" <>,
	"Tobias Klauser" <>,
	"Linux Kernel Mailing List" <>,
	"" <>,
	"Network Development" <>
Subject: Re: [PATCH] brcmfmac: added LED triggers for transmit/receive
Date: Tue, 11 Jul 2017 10:58:03 +0200	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On 10-07-17 19:02, Russell Joyce wrote:
>> 1) I think most of it should be some cfg80211 shareable code.
> I’m not sure exactly what you mean by this, could you please clarify?

What I think Rafał is saying is that it would be better to have this
code in cfg80211 so other drivers including mac80211 could use it.

>> 2) This "rxtx" while surely present in other places sounds like a
>> workaround for LED subsystem limitation. Maybe it's time to finally
>> rework LED triggers.
> I agree that it’s not an ideal way to do things, but I couldn’t think of a
> better alternative. I think that having a combined trigger is useful though, for
> situations like using the single LED on a Raspberry Pi to show Wi-Fi activity.

Indeed. However, the LED subsystem could/should(?) take care of mapping
"rx" and "tx" triggers to the same LED.

I am happy to comment on your patch, but maybe you can first take a look
at the suggestion Rafał made above.


  reply	other threads:[~2017-07-11  8:58 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-07 14:09 [PATCH] brcmfmac: added LED triggers for transmit/receive Russell Joyce
2017-07-10  9:48 ` Rafał Miłecki
2017-07-10 17:02   ` Russell Joyce
2017-07-11  8:58     ` Arend van Spriel [this message]
2017-07-11 15:01       ` Russell Joyce
2017-07-17  4:59         ` Rafał Miłecki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).