linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Arend van Spriel <arend.vanspriel@broadcom.com>
To: "Russell Joyce" <russell.joyce@york.ac.uk>,
	"Rafał Miłecki" <zajec5@gmail.com>
Cc: "Alan Millard" <alan.millard@york.ac.uk>,
	"Franky Lin" <franky.lin@broadcom.com>,
	"Hante Meuleman" <hante.meuleman@broadcom.com>,
	"Chi-Hsien Lin" <chi-hsien.lin@cypress.com>,
	"Wright Feng" <wright.feng@cypress.com>,
	"Kalle Valo" <kvalo@codeaurora.org>,
	"Marc Kleine-Budde" <mkl@pengutronix.de>,
	"Marcel Holtmann" <marcel@holtmann.org>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	"Pieter-Paul Giesberts" <pieter-paul.giesberts@broadcom.com>,
	"Rafał Miłecki" <rafal@milecki.pl>,
	"mhiramat@kernel.org" <mhiramat@kernel.org>,
	"James Hughes" <james.hughes@raspberrypi.org>,
	"Tobias Klauser" <tklauser@distanz.ch>,
	"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
	"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
	"open list:BROADCOM BRCM80211 IEEE802.11n WIRELESS DRIVER"
	<brcm80211-dev-list.pdl@broadcom.com>,
	brcm80211-dev-list@cypress.com,
	"Network Development" <netdev@vger.kernel.org>
Subject: Re: [PATCH] brcmfmac: added LED triggers for transmit/receive
Date: Tue, 11 Jul 2017 10:58:03 +0200	[thread overview]
Message-ID: <60de1301-b4a3-95a7-117f-a953576655d9@broadcom.com> (raw)
In-Reply-To: <B8983FA2-39CE-478B-80C9-F32E01856FE9@york.ac.uk>

On 10-07-17 19:02, Russell Joyce wrote:
>> 1) I think most of it should be some cfg80211 shareable code.
> 
> I’m not sure exactly what you mean by this, could you please clarify?

What I think Rafał is saying is that it would be better to have this
code in cfg80211 so other drivers including mac80211 could use it.

>> 2) This "rxtx" while surely present in other places sounds like a
>> workaround for LED subsystem limitation. Maybe it's time to finally
>> rework LED triggers.
> 
> I agree that it’s not an ideal way to do things, but I couldn’t think of a
> better alternative. I think that having a combined trigger is useful though, for
> situations like using the single LED on a Raspberry Pi to show Wi-Fi activity.

Indeed. However, the LED subsystem could/should(?) take care of mapping
"rx" and "tx" triggers to the same LED.

I am happy to comment on your patch, but maybe you can first take a look
at the suggestion Rafał made above.

Regards,
Arend

  reply	other threads:[~2017-07-11  8:58 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-07 14:09 [PATCH] brcmfmac: added LED triggers for transmit/receive Russell Joyce
2017-07-10  9:48 ` Rafał Miłecki
2017-07-10 17:02   ` Russell Joyce
2017-07-11  8:58     ` Arend van Spriel [this message]
2017-07-11 15:01       ` Russell Joyce
2017-07-17  4:59         ` Rafał Miłecki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=60de1301-b4a3-95a7-117f-a953576655d9@broadcom.com \
    --to=arend.vanspriel@broadcom.com \
    --cc=alan.millard@york.ac.uk \
    --cc=brcm80211-dev-list.pdl@broadcom.com \
    --cc=brcm80211-dev-list@cypress.com \
    --cc=chi-hsien.lin@cypress.com \
    --cc=franky.lin@broadcom.com \
    --cc=hante.meuleman@broadcom.com \
    --cc=james.hughes@raspberrypi.org \
    --cc=kvalo@codeaurora.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=marcel@holtmann.org \
    --cc=mhiramat@kernel.org \
    --cc=mkl@pengutronix.de \
    --cc=mst@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=pieter-paul.giesberts@broadcom.com \
    --cc=rafal@milecki.pl \
    --cc=russell.joyce@york.ac.uk \
    --cc=tklauser@distanz.ch \
    --cc=wright.feng@cypress.com \
    --cc=zajec5@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).