* [PATCH] b43: LP-PHY: Fix reading old mode in the set TX power control routine
@ 2009-08-14 18:29 Gábor Stefanik
2009-08-14 18:44 ` Larry Finger
2009-08-17 19:33 ` Gábor Stefanik
0 siblings, 2 replies; 6+ messages in thread
From: Gábor Stefanik @ 2009-08-14 18:29 UTC (permalink / raw)
To: John Linville, Michael Buesch, Larry Finger, Mark Huijgen
Cc: Broadcom Wireless, linux-wireless
Check the mode the hardware is in, not the mode we used the last time.
Signed-off-by: Gábor Stefanik <netrolller.3d@gmail.com>
---
Mark, please test if this fixes the TX power control WARN_ON you were seeing.
drivers/net/wireless/b43/phy_lp.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/wireless/b43/phy_lp.c b/drivers/net/wireless/b43/phy_lp.c
index 292ee51..76457f7 100644
--- a/drivers/net/wireless/b43/phy_lp.c
+++ b/drivers/net/wireless/b43/phy_lp.c
@@ -1015,9 +1015,9 @@ static void lpphy_set_tx_power_control(struct b43_wldev *dev,
struct b43_phy_lp *lpphy = dev->phy.lp;
enum b43_lpphy_txpctl_mode oldmode;
- oldmode = lpphy->txpctl_mode;
lpphy_read_tx_pctl_mode_from_hardware(dev);
- if (lpphy->txpctl_mode == mode)
+ oldmode = lpphy->txpctl_mode;
+ if (oldmode == mode)
return;
lpphy->txpctl_mode = mode;
--
1.6.2.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] b43: LP-PHY: Fix reading old mode in the set TX power control routine
2009-08-14 18:29 [PATCH] b43: LP-PHY: Fix reading old mode in the set TX power control routine Gábor Stefanik
@ 2009-08-14 18:44 ` Larry Finger
2009-08-17 19:33 ` Gábor Stefanik
1 sibling, 0 replies; 6+ messages in thread
From: Larry Finger @ 2009-08-14 18:44 UTC (permalink / raw)
To: Gábor Stefanik
Cc: John Linville, Michael Buesch, Mark Huijgen, Broadcom Wireless,
linux-wireless
Gábor Stefanik wrote:
> Check the mode the hardware is in, not the mode we used the last time.
>
> Signed-off-by: Gábor Stefanik <netrolller.3d@gmail.com>
> ---
> Mark, please test if this fixes the TX power control WARN_ON you were
> seeing.
It does not fix it here. I'll take a look at the specs.
Larry
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] b43: LP-PHY: Fix reading old mode in the set TX power control routine
2009-08-14 18:29 [PATCH] b43: LP-PHY: Fix reading old mode in the set TX power control routine Gábor Stefanik
2009-08-14 18:44 ` Larry Finger
@ 2009-08-17 19:33 ` Gábor Stefanik
2009-08-17 19:56 ` John W. Linville
1 sibling, 1 reply; 6+ messages in thread
From: Gábor Stefanik @ 2009-08-17 19:33 UTC (permalink / raw)
To: John Linville, Michael Buesch, Larry Finger, Mark Huijgen
Cc: Broadcom Wireless, linux-wireless
2009/8/14 Gábor Stefanik <netrolller.3d@gmail.com>:
> Check the mode the hardware is in, not the mode we used the last time.
>
> Signed-off-by: Gábor Stefanik <netrolller.3d@gmail.com>
> ---
> Mark, please test if this fixes the TX power control WARN_ON you were
> seeing.
>
> drivers/net/wireless/b43/phy_lp.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/wireless/b43/phy_lp.c
> b/drivers/net/wireless/b43/phy_lp.c
> index 292ee51..76457f7 100644
> --- a/drivers/net/wireless/b43/phy_lp.c
> +++ b/drivers/net/wireless/b43/phy_lp.c
> @@ -1015,9 +1015,9 @@ static void lpphy_set_tx_power_control(struct
> b43_wldev *dev,
> struct b43_phy_lp *lpphy = dev->phy.lp;
> enum b43_lpphy_txpctl_mode oldmode;
>
> - oldmode = lpphy->txpctl_mode;
> lpphy_read_tx_pctl_mode_from_hardware(dev);
> - if (lpphy->txpctl_mode == mode)
> + oldmode = lpphy->txpctl_mode;
> + if (oldmode == mode)
> return;
> lpphy->txpctl_mode = mode;
>
> --
> 1.6.2.4
>
John, any news on this one? I can't see it in wireless testing.
--
Vista: [V]iruses, [I]ntruders, [S]pyware, [T]rojans and [A]dware. :-)
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] b43: LP-PHY: Fix reading old mode in the set TX power control routine
2009-08-17 19:33 ` Gábor Stefanik
@ 2009-08-17 19:56 ` John W. Linville
2009-08-17 20:03 ` Gábor Stefanik
0 siblings, 1 reply; 6+ messages in thread
From: John W. Linville @ 2009-08-17 19:56 UTC (permalink / raw)
To: Gábor Stefanik
Cc: Michael Buesch, Larry Finger, Mark Huijgen, Broadcom Wireless,
linux-wireless
On Mon, Aug 17, 2009 at 09:33:06PM +0200, Gábor Stefanik wrote:
> 2009/8/14 Gábor Stefanik <netrolller.3d@gmail.com>:
> > Check the mode the hardware is in, not the mode we used the last time.
> >
> > Signed-off-by: Gábor Stefanik <netrolller.3d@gmail.com>
> > ---
> > Mark, please test if this fixes the TX power control WARN_ON you were
> > seeing.
> >
> > drivers/net/wireless/b43/phy_lp.c | 4 ++--
> > 1 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/net/wireless/b43/phy_lp.c
> > b/drivers/net/wireless/b43/phy_lp.c
> > index 292ee51..76457f7 100644
> > --- a/drivers/net/wireless/b43/phy_lp.c
> > +++ b/drivers/net/wireless/b43/phy_lp.c
> > @@ -1015,9 +1015,9 @@ static void lpphy_set_tx_power_control(struct
> > b43_wldev *dev,
> > struct b43_phy_lp *lpphy = dev->phy.lp;
> > enum b43_lpphy_txpctl_mode oldmode;
> >
> > - oldmode = lpphy->txpctl_mode;
> > lpphy_read_tx_pctl_mode_from_hardware(dev);
> > - if (lpphy->txpctl_mode == mode)
> > + oldmode = lpphy->txpctl_mode;
> > + if (oldmode == mode)
> > return;
> > lpphy->txpctl_mode = mode;
> >
> > --
> > 1.6.2.4
> >
>
> John, any news on this one? I can't see it in wireless testing.
Larry said "It does not fix it here. I'll take a look at the specs"...
--
John W. Linville Someday the world will need a hero, and you
linville@tuxdriver.com might be all we have. Be ready.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] b43: LP-PHY: Fix reading old mode in the set TX power control routine
2009-08-17 19:56 ` John W. Linville
@ 2009-08-17 20:03 ` Gábor Stefanik
2009-08-17 21:18 ` Larry Finger
0 siblings, 1 reply; 6+ messages in thread
From: Gábor Stefanik @ 2009-08-17 20:03 UTC (permalink / raw)
To: John W. Linville
Cc: Michael Buesch, Larry Finger, Mark Huijgen, Broadcom Wireless,
linux-wireless
2009/8/17 John W. Linville <linville@tuxdriver.com>:
> On Mon, Aug 17, 2009 at 09:33:06PM +0200, Gábor Stefanik wrote:
>> 2009/8/14 Gábor Stefanik <netrolller.3d@gmail.com>:
>> > Check the mode the hardware is in, not the mode we used the last time.
>> >
>> > Signed-off-by: Gábor Stefanik <netrolller.3d@gmail.com>
>> > ---
>> > Mark, please test if this fixes the TX power control WARN_ON you were
>> > seeing.
>> >
>> > drivers/net/wireless/b43/phy_lp.c | 4 ++--
>> > 1 files changed, 2 insertions(+), 2 deletions(-)
>> >
>> > diff --git a/drivers/net/wireless/b43/phy_lp.c
>> > b/drivers/net/wireless/b43/phy_lp.c
>> > index 292ee51..76457f7 100644
>> > --- a/drivers/net/wireless/b43/phy_lp.c
>> > +++ b/drivers/net/wireless/b43/phy_lp.c
>> > @@ -1015,9 +1015,9 @@ static void lpphy_set_tx_power_control(struct
>> > b43_wldev *dev,
>> > struct b43_phy_lp *lpphy = dev->phy.lp;
>> > enum b43_lpphy_txpctl_mode oldmode;
>> >
>> > - oldmode = lpphy->txpctl_mode;
>> > lpphy_read_tx_pctl_mode_from_hardware(dev);
>> > - if (lpphy->txpctl_mode == mode)
>> > + oldmode = lpphy->txpctl_mode;
>> > + if (oldmode == mode)
>> > return;
>> > lpphy->txpctl_mode = mode;
>> >
>> > --
>> > 1.6.2.4
>> >
>>
>> John, any news on this one? I can't see it in wireless testing.
>
> Larry said "It does not fix it here. I'll take a look at the specs"...
It did not fix the warning, but it is nevertheless a legitimate fix.
(I found this bug when I was looking for the source of the WARN_ON -
this is not the source of the WARN_ON, but still a bug.)
>
> --
> John W. Linville Someday the world will need a hero, and you
> linville@tuxdriver.com might be all we have. Be ready.
>
--
Vista: [V]iruses, [I]ntruders, [S]pyware, [T]rojans and [A]dware. :-)
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] b43: LP-PHY: Fix reading old mode in the set TX power control routine
2009-08-17 20:03 ` Gábor Stefanik
@ 2009-08-17 21:18 ` Larry Finger
0 siblings, 0 replies; 6+ messages in thread
From: Larry Finger @ 2009-08-17 21:18 UTC (permalink / raw)
To: Gábor Stefanik
Cc: John W. Linville, Michael Buesch, Mark Huijgen,
Broadcom Wireless, linux-wireless
Gábor Stefanik wrote:
> 2009/8/17 John W. Linville <linville@tuxdriver.com>:
>> On Mon, Aug 17, 2009 at 09:33:06PM +0200, Gábor Stefanik wrote:
>>> 2009/8/14 Gábor Stefanik <netrolller.3d@gmail.com>:
>>>> Check the mode the hardware is in, not the mode we used the last time.
>>>>
>>>> Signed-off-by: Gábor Stefanik <netrolller.3d@gmail.com>
>>>> ---
>>>> Mark, please test if this fixes the TX power control WARN_ON you were
>>>> seeing.
>>>>
>>>> drivers/net/wireless/b43/phy_lp.c | 4 ++--
>>>> 1 files changed, 2 insertions(+), 2 deletions(-)
>>>>
>>>> diff --git a/drivers/net/wireless/b43/phy_lp.c
>>>> b/drivers/net/wireless/b43/phy_lp.c
>>>> index 292ee51..76457f7 100644
>>>> --- a/drivers/net/wireless/b43/phy_lp.c
>>>> +++ b/drivers/net/wireless/b43/phy_lp.c
>>>> @@ -1015,9 +1015,9 @@ static void lpphy_set_tx_power_control(struct
>>>> b43_wldev *dev,
>>>> struct b43_phy_lp *lpphy = dev->phy.lp;
>>>> enum b43_lpphy_txpctl_mode oldmode;
>>>>
>>>> - oldmode = lpphy->txpctl_mode;
>>>> lpphy_read_tx_pctl_mode_from_hardware(dev);
>>>> - if (lpphy->txpctl_mode == mode)
>>>> + oldmode = lpphy->txpctl_mode;
>>>> + if (oldmode == mode)
>>>> return;
>>>> lpphy->txpctl_mode = mode;
>>>>
>>>> --
>>>> 1.6.2.4
>>>>
>>> John, any news on this one? I can't see it in wireless testing.
>> Larry said "It does not fix it here. I'll take a look at the specs"...
>
> It did not fix the warning, but it is nevertheless a legitimate fix.
> (I found this bug when I was looking for the source of the WARN_ON -
> this is not the source of the WARN_ON, but still a bug.)
This patch is OK.
Larry
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2009-08-17 21:19 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-08-14 18:29 [PATCH] b43: LP-PHY: Fix reading old mode in the set TX power control routine Gábor Stefanik
2009-08-14 18:44 ` Larry Finger
2009-08-17 19:33 ` Gábor Stefanik
2009-08-17 19:56 ` John W. Linville
2009-08-17 20:03 ` Gábor Stefanik
2009-08-17 21:18 ` Larry Finger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).