Re: [PATCH] net: rtw88: fix an issue about leak system resources

Re: [PATCH] net: rtw88: fix an issue about leak system resources

[Markus Elfring]

> the related system resources were not released when pci_iomap() return
> error in the rtw_pci_io_mapping() function. add pci_release_regions() to
> fix it.

How do you think about a wording variant like the following?

   Subject:
   [PATCH v2] net: rtw88: Complete exception handling in rtw_pci_io_mapping()

   Change description:
   A call of the function “pci_request_regions” can fail here.
   The corresponding system resources were not released then.
   Thus add a call of the function “pci_release_regions”.


Regards,
Markus

Re: [PATCH] net: rtw88: fix an issue about leak system resources

[Markus Elfring]

>>> the related system resources were not released when pci_iomap() return
>>> error in the rtw_pci_io_mapping() function. add pci_release_regions() to
>>> fix it.
>>
>> How do you think about a wording variant like the following?
>>
>>    Subject:
>>    [PATCH v2] net: rtw88: Complete exception handling in rtw_pci_io_mapping()
>>
>>    Change description:
>>    A call of the function “pci_request_regions” can fail here.
>>    The corresponding system resources were not released then.
>>    Thus add a call of the function “pci_release_regions”.
>>
>>
> Markus, I think my commit comments is a sufficiently clear description
> for this patch.

I got an other impression for specific aspects.


> Someone has told me not to send commit comments again and again
> when it is enough clear.

My patch review tries should give you hints where I noticed wording weaknesses.
The corresponding change tolerance can vary by involved contributors.


> Because it only wastes the precious time of the maintainer
> and very very little help for patch improvement.

I hope that also your commit messages will improve.


> BTW, In the past week, you asked me to change the commit comments in my
> 6 patches like this one. Let me return to the essence of patch, point
> out the code problems and better solutions will be more popular.

I would appreciate if various update suggestions would become nicer somehow.

Regards,
Markus

Re: [PATCH] net: rtw88: fix an issue about leak system resources

[Brian Norris]

(Markus is clearly not taking the hint, but FYI for everyone else:)

On Mon, May 4, 2020 at 8:00 AM Markus Elfring <Markus.Elfring@web.de> wrote:
> > BTW, In the past week, you asked me to change the commit comments in my
> > 6 patches like this one. Let me return to the essence of patch, point
> > out the code problems and better solutions will be more popular.
>
> I would appreciate if various update suggestions would become nicer somehow.

Markus is not really providing any value to the community. Just search
for his recent mail history -- it's all silly commit message
nitpicking of little value. He's been blacklisted by a number of
people already:

https://lkml.kernel.org/lkml/20190919112937.GA3072241@kroah.com/

Some people continue to humor him, but it's mostly just a waste of
their time, as this has been going on for years. Just look at searches
like this, and tell me whether they produce anything useful:

https://lkml.kernel.org/lkml/?q=%22markus+elfring%22&o=5000

Brian

Re: net: rtw88: fix an issue about leak system resources

[Markus Elfring]

> Markus is not really providing any value to the community.

The opinions can vary also around my contributions.


> Just search for his recent mail history -- it's all silly commit message
> nitpicking of little value.

I dare to point questionable implementation (and/or wording) details out.


> He's been blacklisted by a number of people already:

Such communication settings can happen for some reasons.


> Some people continue to humor him, but it's mostly just a waste of
> their time, as this has been going on for years. Just look at searches
> like this, and tell me whether they produce anything useful:
>
> https://lkml.kernel.org/lkml/?q=%22markus+elfring%22&o=5000

How do you think about to take another look at published software development
statistics in constructive ways?

Regards,
Markus

Re: net: rtw88: fix an issue about leak system resources

[Markus Elfring]

> Markus is not really providing any value to the community.

The opinions can vary also around my contributions.


> Just search for his recent mail history -- it's all silly commit message
> nitpicking of little value.

I dare to point questionable implementation (and/or wording) details out.


> He's been blacklisted by a number of people already:

Such communication settings can happen for some reasons.


> Some people continue to humor him, but it's mostly just a waste of
> their time, as this has been going on for years. Just look at searches
> like this, and tell me whether they produce anything useful:
>
> https://lkml.kernel.org/lkml/?q=%22markus+elfring%22&o=5000

How do you think about to take another look at published software development
statistics in constructive ways?

Regards,
Markus

Re: [PATCH] net: rtw88: fix an issue about leak system resources

[Dejin Zheng]

On Mon, May 04, 2020 at 10:03:59AM -0700, Brian Norris wrote:
> (Markus is clearly not taking the hint, but FYI for everyone else:)
> 
> On Mon, May 4, 2020 at 8:00 AM Markus Elfring <Markus.Elfring@web.de> wrote:
> > > BTW, In the past week, you asked me to change the commit comments in my
> > > 6 patches like this one. Let me return to the essence of patch, point
> > > out the code problems and better solutions will be more popular.
> >
> > I would appreciate if various update suggestions would become nicer somehow.
> 
> Markus is not really providing any value to the community. Just search
> for his recent mail history -- it's all silly commit message
> nitpicking of little value. He's been blacklisted by a number of
> people already:
> 
> https://lkml.kernel.org/lkml/20190919112937.GA3072241@kroah.com/
> 
> Some people continue to humor him, but it's mostly just a waste of
> their time, as this has been going on for years. Just look at searches
> like this, and tell me whether they produce anything useful:
> 
> https://lkml.kernel.org/lkml/?q=%22markus+elfring%22&o=5000
>
Brian, Thanks very much for your reminder, These comments have always
bothered me. Now I can put it on my blacklist. Thank you very very much!

BR,
Dejin

> Brian

Re: net: rtw88: fix an issue about leak system resources

[Markus Elfring]

> Brian, Thanks very much for your reminder,

Reminders can hopefully trigger positive effects.


> These comments have always bothered me.

Thanks for such information.


> Now I can put it on my blacklist.

I find it unfortunate that you choose to adjust your communication preferences
in this direction.
Thus I am curious if other contributors will get more chances to integrate
another bit of advice into your software development attention.

Regards,
Markus

Re: [PATCH] net: rtw88: fix an issue about leak system resources

[Andy Shevchenko]

On Tue, May 5, 2020 at 3:59 AM Dejin Zheng <zhengdejin5@gmail.com> wrote:
> On Mon, May 04, 2020 at 10:03:59AM -0700, Brian Norris wrote:
> > (Markus is clearly not taking the hint, but FYI for everyone else:)

> Brian, Thanks very much for your reminder, These comments have always
> bothered me. Now I can put it on my blacklist. Thank you very very much!

Perhaps we need to find a good researcher student who may do a MD
dissertation out of the case :-)

-- 
With Best Regards,
Andy Shevchenko

Re: net: rtw88: Fix an issue about leaking system resources

[Markus Elfring]

> Perhaps we need to find a good researcher student who may do a MD
> dissertation out of the case :-)

I got the impression that some research is performed already around
affected areas.
Would you like to reuse any more experiences from there?

Regards,
Markus