From: Wen Gong <wgong@codeaurora.org>
To: Kalle Valo <kvalo@codeaurora.org>
Cc: ath10k@lists.infradead.org, linux-wireless@vger.kernel.org
Subject: Re: [PATCH v9 1/4] ath10k: disable TX complete indication of htt for sdio
Date: Tue, 07 Apr 2020 14:04:58 +0800 [thread overview]
Message-ID: <84039fe1187e3ec7546edd4f9fe5600a@codeaurora.org> (raw)
In-Reply-To: <20200407054431.6B2A0C433BA@smtp.codeaurora.org>
On 2020-04-07 13:44, Kalle Valo wrote:
> This has new warnings:
>
> drivers/net/wireless/ath/ath10k/htt_tx.c: In function
> 'ath10k_htt_htc_tx_complete':
> drivers/net/wireless/ath/ath10k/htt_tx.c:566:30: warning: 'msg_type'
> may be used uninitialized in this function [-Wmaybe-uninitialized]
> drivers/net/wireless/ath/ath10k/htt_tx.c:573:6: warning: 'flags1' may
> be used uninitialized in this function [-Wmaybe-uninitialized]
> drivers/net/wireless/ath/ath10k/htt_tx.c:577:42: warning: 'desc_hdr'
> may be used uninitialized in this function [-Wmaybe-uninitialized]
>
I already run ath10k-check, but not see these warnings.
my gcc: gcc (Ubuntu 4.8.4-2ubuntu1~14.04.4) 4.8.4
so is it because my gcc too version too low?
>> From what I can see these are false positives, but please do double
>> check that. In
> the pending branch I solved it like this:
>
> --- a/drivers/net/wireless/ath/ath10k/htt_tx.c
> +++ b/drivers/net/wireless/ath/ath10k/htt_tx.c
> @@ -546,9 +546,9 @@ void ath10k_htt_htc_tx_complete(struct ath10k *ar,
> struct sk_buff *skb)
> struct ath10k_htt *htt = &ar->htt;
> struct htt_tx_done tx_done = {0};
> struct htt_cmd_hdr *htt_hdr;
> - struct htt_data_tx_desc *desc_hdr;
> - u16 flags1;
> - u8 msg_type;
> + struct htt_data_tx_desc *desc_hdr = NULL;
> + u16 flags1 = 0;
> + u8 msg_type = 0;
>
> if (htt->disable_tx_comp) {
> htt_hdr = (struct htt_cmd_hdr *)skb->data;
next prev parent reply other threads:[~2020-04-07 6:05 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-12 8:04 [PATCH v9 0/4] ath10k: improve throughout of TX of sdio Wen Gong
2020-02-12 8:04 ` [PATCH v9 1/4] ath10k: disable TX complete indication of htt for sdio Wen Gong
2020-04-07 5:44 ` Kalle Valo
[not found] ` <20200407054431.6B2A0C433BA@smtp.codeaurora.org>
2020-04-07 6:04 ` Wen Gong [this message]
2020-04-07 6:08 ` Kalle Valo
2020-04-09 14:52 ` Kalle Valo
2020-02-12 8:04 ` [PATCH v9 2/4] ath10k: change ATH10K_SDIO_BUS_REQUEST_MAX_NUM from 64 to 1024 Wen Gong
2020-02-12 8:04 ` [PATCH v9 3/4] ath10k: add htt TX bundle for sdio Wen Gong
2020-04-09 14:53 ` Kalle Valo
2020-04-09 15:40 ` Wen Gong
2020-04-14 8:10 ` Kalle Valo
2020-04-16 12:27 ` Kalle Valo
2020-04-18 14:02 ` Wen Gong
2020-04-21 11:56 ` Kalle Valo
2020-04-09 15:05 ` Kalle Valo
2020-04-09 15:29 ` Wen Gong
2020-04-09 15:42 ` Kalle Valo
2020-04-09 15:55 ` Wen Gong
2020-02-12 8:04 ` [PATCH v9 4/4] ath10k: enable alt data of TX path " Wen Gong
2020-04-10 6:21 ` [PATCH v9 0/4] ath10k: improve throughout of TX of sdio Wen Gong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=84039fe1187e3ec7546edd4f9fe5600a@codeaurora.org \
--to=wgong@codeaurora.org \
--cc=ath10k@lists.infradead.org \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).