From: Kalle Valo <kvalo@codeaurora.org>
To: Wen Gong <wgong@codeaurora.org>
Cc: ath10k@lists.infradead.org, linux-wireless@vger.kernel.org
Subject: Re: [PATCH v9 3/4] ath10k: add htt TX bundle for sdio
Date: Thu, 09 Apr 2020 18:05:45 +0300 [thread overview]
Message-ID: <87pncgu2ba.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <20200212080415.31265-4-wgong@codeaurora.org> (Wen Gong's message of "Wed, 12 Feb 2020 16:04:14 +0800")
Wen Gong <wgong@codeaurora.org> writes:
> The transmission utilization ratio for sdio bus for small packet is
> slow, because the space and time cost for sdio bus is same for large
> length packet and small length packet. So the speed of data for large
> length packet is higher than small length.
>
> Test result of different length of data:
>
> data packet(byte) cost time(us) calculated rate(Mbps)
> 256 28 73
> 512 33 124
> 1024 35 234
> 1792 45 318
> 14336 168 682
> 28672 333 688
> 57344 660 695
>
> This patch change the TX packet from single packet to a large length
> bundle packet, max size is 32, it results in significant performance
> improvement on TX path.
>
> This patch only effect sdio chip, it will not effect PCI, SNOC etc.
> It only enable bundle for sdio chip.
>
> Tested with QCA6174 SDIO with firmware
> WLAN.RMH.4.4.1-00017-QCARMSWP-1.
>
> Signed-off-by: Wen Gong <wgong@codeaurora.org>
[...]
> + if (ep->tx_credits < credits) {
> + ath10k_dbg(ar, ATH10K_DBG_HTC,
> + "htc insufficient credits ep %d required %d available %d consume %d\n",
> + eid, credits, ep->tx_credits, consume);
> + ret = -EAGAIN;
> + goto unlock;
> + }
> +
> + if (consume) {
> + ep->tx_credits -= credits;
> + ath10k_dbg(ar, ATH10K_DBG_HTC,
> + "htc ep %d consumed %d credits (total %d)\n",
"htc ep %d consumed %d credits total %d\n"
[...]
> + ath10k_dbg(ar, ATH10K_DBG_HTC, "bundle skb: len:%d\n", bundle_skb->len);
"htc bundle skb len %d\n"
In other words, start with "htc" and don't use colons or parenthesis.
This applies to most of debug messages in this patch.
--
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2020-04-09 15:06 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-12 8:04 [PATCH v9 0/4] ath10k: improve throughout of TX of sdio Wen Gong
2020-02-12 8:04 ` [PATCH v9 1/4] ath10k: disable TX complete indication of htt for sdio Wen Gong
2020-04-07 5:44 ` Kalle Valo
[not found] ` <20200407054431.6B2A0C433BA@smtp.codeaurora.org>
2020-04-07 6:04 ` Wen Gong
2020-04-07 6:08 ` Kalle Valo
2020-04-09 14:52 ` Kalle Valo
2020-02-12 8:04 ` [PATCH v9 2/4] ath10k: change ATH10K_SDIO_BUS_REQUEST_MAX_NUM from 64 to 1024 Wen Gong
2020-02-12 8:04 ` [PATCH v9 3/4] ath10k: add htt TX bundle for sdio Wen Gong
2020-04-09 14:53 ` Kalle Valo
2020-04-09 15:40 ` Wen Gong
2020-04-14 8:10 ` Kalle Valo
2020-04-16 12:27 ` Kalle Valo
2020-04-18 14:02 ` Wen Gong
2020-04-21 11:56 ` Kalle Valo
2020-04-09 15:05 ` Kalle Valo [this message]
2020-04-09 15:29 ` Wen Gong
2020-04-09 15:42 ` Kalle Valo
2020-04-09 15:55 ` Wen Gong
2020-02-12 8:04 ` [PATCH v9 4/4] ath10k: enable alt data of TX path " Wen Gong
2020-04-10 6:21 ` [PATCH v9 0/4] ath10k: improve throughout of TX of sdio Wen Gong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pncgu2ba.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@codeaurora.org \
--cc=ath10k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=wgong@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).