From: Kalle Valo <kvalo@codeaurora.org>
To: Tony Chuang <yhchuang@realtek.com>
Cc: Larry Finger <Larry.Finger@lwfinger.net>,
Pkshih <pkshih@realtek.com>, Andy Huang <tehuang@realtek.com>,
"briannorris\@chromium.org" <briannorris@chromium.org>,
"sgruszka\@redhat.com" <sgruszka@redhat.com>,
"linux-wireless\@vger.kernel.org"
<linux-wireless@vger.kernel.org>
Subject: Re: [PATCH v3 00/13] rtw88: mac80211 driver for Realtek 802.11ac wireless network chips
Date: Tue, 29 Jan 2019 19:23:59 +0200 [thread overview]
Message-ID: <871s4vwf68.fsf@codeaurora.org> (raw)
In-Reply-To: <F7CD281DE3E379468C6D07993EA72F84D1798ACF@RTITMBSVM04.realtek.com.tw> (Tony Chuang's message of "Tue, 29 Jan 2019 13:01:44 +0000")
Tony Chuang <yhchuang@realtek.com> writes:
>> I suggest to look at criticality of the bug and size of the patch. For
>> example, if the bug is a minor and the patch is large you should
>> definitely drop that. And smaller fixes to severe bugs you should
>> definitely again include them.
>>
>> Just remember to list in the changelog every change you made since
>> previous version.
>>
>
> Hi Kalle,
>
> One more question, should I merge the trivial patches into the original
> patch set and resend them like [PATCH v4 00/13].
>
> Or should I add them after the 13 patches for people to review easily.
> Such as [PATCH v4 00/21]. Which do you prefer?
I don't have any strong opinion but I prefer the former (13 patches).
Others might think differently.
BTW, I don't if you are aware but I will add the driver to
wireless-drivers-next in commit, so in the end we need to squash these
patches into patch. Only in review it's easier to have them split like
this. But we don't need to worry about that right now, let's focus on
people reviewing the driver first.
--
Kalle Valo
next prev parent reply other threads:[~2019-01-29 17:24 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-28 5:46 [PATCH v3 00/13] rtw88: mac80211 driver for Realtek 802.11ac wireless network chips yhchuang
2019-01-28 5:46 ` [PATCH v3 01/13] rtw88: main files yhchuang
2019-01-28 5:46 ` [PATCH v3 02/13] rtw88: core files yhchuang
2019-01-28 5:46 ` [PATCH v3 03/13] rtw88: hci files yhchuang
2019-01-28 5:46 ` [PATCH v3 04/13] rtw88: trx files yhchuang
2019-01-28 5:46 ` [PATCH v3 05/13] rtw88: mac files yhchuang
2019-01-28 5:46 ` [PATCH v3 06/13] rtw88: fw and efuse files yhchuang
2019-01-28 5:46 ` [PATCH v3 07/13] rtw88: phy files yhchuang
2019-01-28 5:46 ` [PATCH v3 08/13] rtw88: debug files yhchuang
2019-01-28 5:46 ` [PATCH v3 09/13] rtw88: chip files yhchuang
2019-01-28 5:46 ` [PATCH v3 10/13] rtw88: 8822B init table yhchuang
2019-01-28 5:46 ` [PATCH v3 11/13] rtw88: 8822C " yhchuang
2019-01-28 5:46 ` [PATCH v3 12/13] rtw88: Kconfig & Makefile yhchuang
2019-01-28 5:46 ` [PATCH v3 13/13] rtw88: add support for Realtek 802.11ac wireless chips yhchuang
2019-01-28 8:36 ` [PATCH v3 00/13] rtw88: mac80211 driver for Realtek 802.11ac wireless network chips Kalle Valo
2019-01-28 9:25 ` Tony Chuang
2019-01-28 10:12 ` Stanislaw Gruszka
2019-01-28 22:38 ` Brian Norris
2019-01-29 2:27 ` Tony Chuang
2019-01-28 20:56 ` Larry Finger
2019-01-29 2:15 ` Tony Chuang
2019-01-29 2:41 ` Brian Norris
2019-01-29 2:53 ` Tony Chuang
2019-01-29 7:53 ` Kalle Valo
2019-01-29 3:23 ` Larry Finger
2019-01-29 4:03 ` Tony Chuang
2019-01-29 7:59 ` Kalle Valo
2019-01-29 13:01 ` Tony Chuang
2019-01-29 17:23 ` Kalle Valo [this message]
2019-01-29 14:54 ` Larry Finger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871s4vwf68.fsf@codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=Larry.Finger@lwfinger.net \
--cc=briannorris@chromium.org \
--cc=linux-wireless@vger.kernel.org \
--cc=pkshih@realtek.com \
--cc=sgruszka@redhat.com \
--cc=tehuang@realtek.com \
--cc=yhchuang@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).