linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tony Chuang <yhchuang@realtek.com>
To: Brian Norris <briannorris@chromium.org>,
	Stanislaw Gruszka <sgruszka@redhat.com>
Cc: Kalle Valo <kvalo@codeaurora.org>,
	"johannes@sipsolutions.net" <johannes@sipsolutions.net>,
	"Larry.Finger@lwfinger.net" <Larry.Finger@lwfinger.net>,
	Pkshih <pkshih@realtek.com>, Andy Huang <tehuang@realtek.com>,
	"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: RE: [PATCH v3 00/13] rtw88: mac80211 driver for Realtek 802.11ac wireless network chips
Date: Tue, 29 Jan 2019 02:27:16 +0000	[thread overview]
Message-ID: <F7CD281DE3E379468C6D07993EA72F84D1794B00@RTITMBSVM04.realtek.com.tw> (raw)
In-Reply-To: <CA+ASDXNW9v_abS+nX2+H2XymwOL9aVNwdPn-QhfZo71aeQahWQ@mail.gmail.com>



> -----Original Message-----
> From: Brian Norris [mailto:briannorris@chromium.org]
> Sent: Tuesday, January 29, 2019 6:39 AM
> To: Stanislaw Gruszka
> Cc: Tony Chuang; Kalle Valo; johannes@sipsolutions.net;
> Larry.Finger@lwfinger.net; Pkshih; Andy Huang; linux-wireless@vger.kernel.org
> Subject: Re: [PATCH v3 00/13] rtw88: mac80211 driver for Realtek 802.11ac
> wireless network chips
> 
> On Mon, Jan 28, 2019 at 2:16 AM Stanislaw Gruszka <sgruszka@redhat.com>
> wrote:
> > On Mon, Jan 28, 2019 at 09:25:32AM +0000, Tony Chuang wrote:
> > > Sorry for the typo here. Yes, I mean " wireless-drivers-next ".
> > > In MAINTAINERS file, I do change to "wireless-drivers-next" instead of
> "wireless-next".
> >
> > The git entry in MAINTAINER file is not necessary and should point
> > the driver specific tree, which rtw88 do not have. Just remove this
> > entry.
> 
> Yes, it seems Tony mis-interpreted my suggestion when I said he was
> using the wrong tree. I agree this driver does not need a git entry at
> all.

Sorry for that, now rtw88 indeed does not have an own tree other than wireless-drivers.
And Kalle can just remove it.

> 
> Regards,
> Brian
> 
> P.S. I do plan to give this driver a spin this week and hopefully give
> it a little closer review. No guarantees I actually get the time for
> that, but I hope to...


Thanks for your review.
Just point it out if I have done anything wrong or inappropriate.


Yan-Hsuan

  reply	other threads:[~2019-01-29  2:27 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-28  5:46 [PATCH v3 00/13] rtw88: mac80211 driver for Realtek 802.11ac wireless network chips yhchuang
2019-01-28  5:46 ` [PATCH v3 01/13] rtw88: main files yhchuang
2019-01-28  5:46 ` [PATCH v3 02/13] rtw88: core files yhchuang
2019-01-28  5:46 ` [PATCH v3 03/13] rtw88: hci files yhchuang
2019-01-28  5:46 ` [PATCH v3 04/13] rtw88: trx files yhchuang
2019-01-28  5:46 ` [PATCH v3 05/13] rtw88: mac files yhchuang
2019-01-28  5:46 ` [PATCH v3 06/13] rtw88: fw and efuse files yhchuang
2019-01-28  5:46 ` [PATCH v3 07/13] rtw88: phy files yhchuang
2019-01-28  5:46 ` [PATCH v3 08/13] rtw88: debug files yhchuang
2019-01-28  5:46 ` [PATCH v3 09/13] rtw88: chip files yhchuang
2019-01-28  5:46 ` [PATCH v3 10/13] rtw88: 8822B init table yhchuang
2019-01-28  5:46 ` [PATCH v3 11/13] rtw88: 8822C " yhchuang
2019-01-28  5:46 ` [PATCH v3 12/13] rtw88: Kconfig & Makefile yhchuang
2019-01-28  5:46 ` [PATCH v3 13/13] rtw88: add support for Realtek 802.11ac wireless chips yhchuang
2019-01-28  8:36 ` [PATCH v3 00/13] rtw88: mac80211 driver for Realtek 802.11ac wireless network chips Kalle Valo
2019-01-28  9:25   ` Tony Chuang
2019-01-28 10:12     ` Stanislaw Gruszka
2019-01-28 22:38       ` Brian Norris
2019-01-29  2:27         ` Tony Chuang [this message]
2019-01-28 20:56 ` Larry Finger
2019-01-29  2:15   ` Tony Chuang
2019-01-29  2:41     ` Brian Norris
2019-01-29  2:53       ` Tony Chuang
2019-01-29  7:53       ` Kalle Valo
2019-01-29  3:23     ` Larry Finger
2019-01-29  4:03       ` Tony Chuang
2019-01-29  7:59         ` Kalle Valo
2019-01-29 13:01           ` Tony Chuang
2019-01-29 17:23             ` Kalle Valo
2019-01-29 14:54         ` Larry Finger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=F7CD281DE3E379468C6D07993EA72F84D1794B00@RTITMBSVM04.realtek.com.tw \
    --to=yhchuang@realtek.com \
    --cc=Larry.Finger@lwfinger.net \
    --cc=briannorris@chromium.org \
    --cc=johannes@sipsolutions.net \
    --cc=kvalo@codeaurora.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=pkshih@realtek.com \
    --cc=sgruszka@redhat.com \
    --cc=tehuang@realtek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).