[PATCH v2] mwifiex: set netif carrier off in ndo_open

[PATCH v2] mwifiex: set netif carrier off in ndo_open

[Avinash Patil]

From: Johannes Berg <johannes@sipsolutions.net>

This patch adds fix to set carrier state off during ndo_open.
Carrier should be set to ON when device is ready to send data.
In case of station/adhoc interface device is able to transfer
data after successful association/join operation.
For AP this would be after bss_active event.

Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
Signed-off-by: Avinash Patil <patila@marvell.com>
---
 drivers/net/wireless/mwifiex/main.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/net/wireless/mwifiex/main.c b/drivers/net/wireless/mwifiex/main.c
index 6125d1c..a16c293 100644
--- a/drivers/net/wireless/mwifiex/main.c
+++ b/drivers/net/wireless/mwifiex/main.c
@@ -562,7 +562,8 @@ static int mwifiex_init_hw_fw(struct mwifiex_adapter *adapter)
 static int
 mwifiex_open(struct net_device *dev)
 {
-	netif_tx_start_all_queues(dev);
+	netif_carrier_off(dev);
+
 	return 0;
 }
 
-- 
1.8.1.4

Re: [PATCH v2] mwifiex: set netif carrier off in ndo_open

[Avinash Patil]

On Mon, 2015-01-19 at 02:24 -0800, Avinash Patil wrote:
> From: Johannes Berg <johannes@sipsolutions.net>
> 
> This patch adds fix to set carrier state off during ndo_open.
> Carrier should be set to ON when device is ready to send data.
> In case of station/adhoc interface device is able to transfer
> data after successful association/join operation.
> For AP this would be after bss_active event.
> 
> Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
> Signed-off-by: Avinash Patil <patila@marvell.com>
> ---
>  drivers/net/wireless/mwifiex/main.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/wireless/mwifiex/main.c b/drivers/net/wireless/mwifiex/main.c
> index 6125d1c..a16c293 100644
> --- a/drivers/net/wireless/mwifiex/main.c
> +++ b/drivers/net/wireless/mwifiex/main.c
> @@ -562,7 +562,8 @@ static int mwifiex_init_hw_fw(struct mwifiex_adapter *adapter)
>  static int
>  mwifiex_open(struct net_device *dev)
>  {
> -	netif_tx_start_all_queues(dev);
> +	netif_carrier_off(dev);
> +
>  	return 0;
>  }
>  

Hi Kalle,

I do not see this patch in master branch as well as in patchworks
pending patchlist. Is this one also dropped?
Do you want me to resend this as well while I am sending rebased DFS
patches?

Thanks,
Avinash

Re: [v2] mwifiex: set netif carrier off in ndo_open

[Kalle Valo]

> From: Johannes Berg <johannes@sipsolutions.net>
> 
> This patch adds fix to set carrier state off during ndo_open.
> Carrier should be set to ON when device is ready to send data.
> In case of station/adhoc interface device is able to transfer
> data after successful association/join operation.
> For AP this would be after bss_active event.
> 
> Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
> Signed-off-by: Avinash Patil <patila@marvell.com>

Thanks, applied to wireless-drivers-next.git.

Kalle Valo

Re: [PATCH v2] mwifiex: set netif carrier off in ndo_open

[Kalle Valo]

Avinash Patil <patila@marvell.com> writes:

> On Mon, 2015-01-19 at 02:24 -0800, Avinash Patil wrote:
>> From: Johannes Berg <johannes@sipsolutions.net>
>> 
>> This patch adds fix to set carrier state off during ndo_open.
>> Carrier should be set to ON when device is ready to send data.
>> In case of station/adhoc interface device is able to transfer
>> data after successful association/join operation.
>> For AP this would be after bss_active event.
>> 
>> Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
>> Signed-off-by: Avinash Patil <patila@marvell.com>

[...]

> I do not see this patch in master branch as well as in patchworks
> pending patchlist. Is this one also dropped? Do you want me to resend
> this as well while I am sending rebased DFS patches?

I had accidentally marked this patch as "Not Applicable" in patchwork,
sorry about that. Good thing that you noticed. I have applied the patch
now.

-- 
Kalle Valo

Re: [PATCH v2] mwifiex: set netif carrier off in ndo_open

[Avinash Patil]

On Tue, 2015-01-27 at 09:42 -0800, Kalle Valo wrote:
> Avinash Patil <patila@marvell.com> writes:
> 
> > On Mon, 2015-01-19 at 02:24 -0800, Avinash Patil wrote:
> >> From: Johannes Berg <johannes@sipsolutions.net>
> >> 
> >> This patch adds fix to set carrier state off during ndo_open.
> >> Carrier should be set to ON when device is ready to send data.
> >> In case of station/adhoc interface device is able to transfer
> >> data after successful association/join operation.
> >> For AP this would be after bss_active event.
> >> 
> >> Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
> >> Signed-off-by: Avinash Patil <patila@marvell.com>
> 
> [...]
> 
> > I do not see this patch in master branch as well as in patchworks
> > pending patchlist. Is this one also dropped? Do you want me to resend
> > this as well while I am sending rebased DFS patches?
> 
> I had accidentally marked this patch as "Not Applicable" in patchwork,
> sorry about that. Good thing that you noticed. I have applied the patch
> now.
> 
Thanks, Kalle.

-Avinash