* iwlagn: possible regressions from 2.6.29 in 2.6.30 @ 2009-06-30 5:30 Paul Collins 2009-06-30 16:17 ` reinette chatre 0 siblings, 1 reply; 5+ messages in thread From: Paul Collins @ 2009-06-30 5:30 UTC (permalink / raw) To: linux-wireless Two things I liked about iwlagn in 2.6.29 no longer happen with 2.6.30: 1. reassociation following resume from suspend-to-ram 2. transmission of packets > 250 bytes following resume from suspend-to-ram I can script around the first problem just by doing "iwconfig wlan0 ap auto" on resume, but the second problem requires me to ifdown/ifup wlan0 before I can usefully use my network again, so fixing the first problem doesn't get me very far. When I say "packets > 250 bytes" I mean 250-byte packets as claimed by "ping -s 222 mygateway": PING cornelius.lan (10.2.4.1) 222(250) bytes of data. The above will work, but "ping -s 223 cornelius" yields no replies. I am using a Wireless WiFi Link 5300 [8086:4236] in a ThinkPad X200. In both cases I was using Debian kernels, although they don't seem to have included any changes to iwlagn. -- Paul Collins Wellington, New Zealand Dag vijandelijk luchtschip de huismeester is dood ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: iwlagn: possible regressions from 2.6.29 in 2.6.30 2009-06-30 5:30 iwlagn: possible regressions from 2.6.29 in 2.6.30 Paul Collins @ 2009-06-30 16:17 ` reinette chatre 2009-06-30 21:53 ` Paul Collins 0 siblings, 1 reply; 5+ messages in thread From: reinette chatre @ 2009-06-30 16:17 UTC (permalink / raw) To: Paul Collins; +Cc: linux-wireless Hi Paul, On Mon, 2009-06-29 at 22:30 -0700, Paul Collins wrote: > Two things I liked about iwlagn in 2.6.29 no longer happen with 2.6.30: > > 1. reassociation following resume from suspend-to-ram > 2. transmission of packets > 250 bytes following resume from suspend-to-ram > > I can script around the first problem just by doing "iwconfig wlan0 ap > auto" on resume, but the second problem requires me to ifdown/ifup wlan0 > before I can usefully use my network again, so fixing the first problem > doesn't get me very far. For reliable reassociation you need to use a userspace application like wpa_supplicant. > > When I say "packets > 250 bytes" I mean 250-byte packets as claimed by > "ping -s 222 mygateway": > > PING cornelius.lan (10.2.4.1) 222(250) bytes of data. > > The above will work, but "ping -s 223 cornelius" yields no replies. Are you saying this works before suspend, but not after resume? What do you usually do to get this working again? Could you please try this patch? --- drivers/net/wireless/iwlwifi/iwl-tx.c | 14 +++++++++----- 1 files changed, 9 insertions(+), 5 deletions(-) diff --git a/drivers/net/wireless/iwlwifi/iwl-tx.c b/drivers/net/wireless/iwlwifi/iwl-tx.c index 753fca3..3f3147e 100644 --- a/drivers/net/wireless/iwlwifi/iwl-tx.c +++ b/drivers/net/wireless/iwlwifi/iwl-tx.c @@ -873,7 +876,8 @@ int iwl_tx_skb(struct iwl_priv *priv, struct sk_buff *skb) iwl_print_hex_dump(priv, IWL_DL_TX, (u8 *)tx_cmd->hdr, hdr_len); /* Set up entry for this TFD in Tx byte-count array */ - priv->cfg->ops->lib->txq_update_byte_cnt_tbl(priv, txq, + if (info->flags & IEEE80211_TX_CTL_AMPDU) + priv->cfg->ops->lib->txq_update_byte_cnt_tbl(priv, txq, le16_to_cpu(tx_cmd->len)); pci_dma_sync_single_for_device(priv->pci_dev, txcmd_phys, -- 1.5.6.3 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: iwlagn: possible regressions from 2.6.29 in 2.6.30 2009-06-30 16:17 ` reinette chatre @ 2009-06-30 21:53 ` Paul Collins 2009-07-04 6:39 ` Paul Collins 0 siblings, 1 reply; 5+ messages in thread From: Paul Collins @ 2009-06-30 21:53 UTC (permalink / raw) To: reinette chatre; +Cc: linux-wireless reinette chatre <reinette.chatre@intel.com> writes: > On Mon, 2009-06-29 at 22:30 -0700, Paul Collins wrote: >> Two things I liked about iwlagn in 2.6.29 no longer happen with 2.6.30: >> >> 1. reassociation following resume from suspend-to-ram >> 2. transmission of packets > 250 bytes following resume from suspend-to-ram >> >> I can script around the first problem just by doing "iwconfig wlan0 ap >> auto" on resume, but the second problem requires me to ifdown/ifup wlan0 >> before I can usefully use my network again, so fixing the first problem >> doesn't get me very far. > > For reliable reassociation you need to use a userspace application like > wpa_supplicant. I'm using WEP here, though. And, as I mentioned, 2.6.29 did seem to reassociate every time by itself, but maybe I just got lucky. >> When I say "packets > 250 bytes" I mean 250-byte packets as claimed by >> "ping -s 222 mygateway": >> >> PING cornelius.lan (10.2.4.1) 222(250) bytes of data. >> >> The above will work, but "ping -s 223 cornelius" yields no replies. > > Are you saying this works before suspend, but not after resume? What do > you usually do to get this working again? Yes, normally it works great; I can ping with packet sizes up to the MTU. However, after suspend/resume and reassociation, "ping -s 223" or greater does not work. I get replies with "-s 222" or less, i.e. packets of 250 bytes or less. To get it working again I do "ifdown wlan0" followed by "ifup wlan0", which does the equivalent of "ip set link wlan0 down/up" and applying the network configuration. I will give the patch a shot when I get home. Regards, Paul ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: iwlagn: possible regressions from 2.6.29 in 2.6.30 2009-06-30 21:53 ` Paul Collins @ 2009-07-04 6:39 ` Paul Collins 2009-08-03 21:08 ` reinette chatre 0 siblings, 1 reply; 5+ messages in thread From: Paul Collins @ 2009-07-04 6:39 UTC (permalink / raw) To: reinette chatre; +Cc: linux-wireless Paul Collins <paul@burly.ondioline.org> writes: > reinette chatre <reinette.chatre@intel.com> writes: >>> When I say "packets > 250 bytes" I mean 250-byte packets as claimed by >>> "ping -s 222 mygateway": >>> >>> PING cornelius.lan (10.2.4.1) 222(250) bytes of data. >>> >>> The above will work, but "ping -s 223 cornelius" yields no replies. >> >> Are you saying this works before suspend, but not after resume? What do >> you usually do to get this working again? > > Yes, normally it works great; I can ping with packet sizes up to the > MTU. However, after suspend/resume and reassociation, "ping -s 223" or > greater does not work. I get replies with "-s 222" or less, > i.e. packets of 250 bytes or less. > > To get it working again I do "ifdown wlan0" followed by "ifup wlan0", > which does the equivalent of "ip set link wlan0 down/up" and applying > the network configuration. > > I will give the patch a shot when I get home. I thought at first that the patch had moved the problem from reliably reproducible to intermittently reproducible, but it looks like it was simply intermittently reproducible the whole time. So, no change with the patch applied. -- Paul Collins Wellington, New Zealand Dag vijandelijk luchtschip de huismeester is dood ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: iwlagn: possible regressions from 2.6.29 in 2.6.30 2009-07-04 6:39 ` Paul Collins @ 2009-08-03 21:08 ` reinette chatre 0 siblings, 0 replies; 5+ messages in thread From: reinette chatre @ 2009-08-03 21:08 UTC (permalink / raw) To: Paul Collins; +Cc: linux-wireless Paul, Hi Paul, On Fri, 2009-07-03 at 23:39 -0700, Paul Collins wrote: > Paul Collins <paul@burly.ondioline.org> writes: > > > reinette chatre <reinette.chatre@intel.com> writes: > >>> When I say "packets > 250 bytes" I mean 250-byte packets as claimed by > >>> "ping -s 222 mygateway": > >>> > >>> PING cornelius.lan (10.2.4.1) 222(250) bytes of data. > >>> > >>> The above will work, but "ping -s 223 cornelius" yields no replies. > >> > >> Are you saying this works before suspend, but not after resume? What do > >> you usually do to get this working again? > > > > Yes, normally it works great; I can ping with packet sizes up to the > > MTU. However, after suspend/resume and reassociation, "ping -s 223" or > > greater does not work. I get replies with "-s 222" or less, > > i.e. packets of 250 bytes or less. > > > > To get it working again I do "ifdown wlan0" followed by "ifup wlan0", > > which does the equivalent of "ip set link wlan0 down/up" and applying > > the network configuration. > > > > I will give the patch a shot when I get home. > > I thought at first that the patch had moved the problem from reliably > reproducible to intermittently reproducible, but it looks like it was > simply intermittently reproducible the whole time. So, no change with > the patch applied. We have not yet been able to look into this issue - could you please submit a bug at intellinuxwireless.org/bugzilla so that we can track it there? Thank you Reinette ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2009-08-03 21:08 UTC | newest] Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2009-06-30 5:30 iwlagn: possible regressions from 2.6.29 in 2.6.30 Paul Collins 2009-06-30 16:17 ` reinette chatre 2009-06-30 21:53 ` Paul Collins 2009-07-04 6:39 ` Paul Collins 2009-08-03 21:08 ` reinette chatre
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).