* [PATCH] mt76: Fix an IS_ERR() vs NULL check in mt76_wmac_probe()
@ 2019-03-06 7:26 Dan Carpenter
2019-03-06 8:50 ` Kalle Valo
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2019-03-06 7:26 UTC (permalink / raw)
To: Felix Fietkau
Cc: Lorenzo Bianconi, Kalle Valo, Matthias Brugger, linux-wireless,
linux-mediatek, kernel-janitors
The devm_ioremap_resource() function never returns NULL, it returns
error pointers.
Fixes: c8846e101502 ("mt76: add driver for MT7603E and MT7628/7688")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
drivers/net/wireless/mediatek/mt76/mt7603/soc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/wireless/mediatek/mt76/mt7603/soc.c b/drivers/net/wireless/mediatek/mt76/mt7603/soc.c
index e13fea80d970..b920be1f5718 100644
--- a/drivers/net/wireless/mediatek/mt76/mt7603/soc.c
+++ b/drivers/net/wireless/mediatek/mt76/mt7603/soc.c
@@ -23,9 +23,9 @@ mt76_wmac_probe(struct platform_device *pdev)
}
mem_base = devm_ioremap_resource(&pdev->dev, res);
- if (!mem_base) {
+ if (IS_ERR(mem_base)) {
dev_err(&pdev->dev, "Failed to get memory resource\n");
- return -EINVAL;
+ return PTR_ERR(mem_base);
}
mdev = mt76_alloc_device(&pdev->dev, sizeof(*dev), &mt7603_ops,
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] mt76: Fix an IS_ERR() vs NULL check in mt76_wmac_probe()
2019-03-06 7:26 [PATCH] mt76: Fix an IS_ERR() vs NULL check in mt76_wmac_probe() Dan Carpenter
@ 2019-03-06 8:50 ` Kalle Valo
0 siblings, 0 replies; 2+ messages in thread
From: Kalle Valo @ 2019-03-06 8:50 UTC (permalink / raw)
To: Dan Carpenter
Cc: Felix Fietkau, Lorenzo Bianconi, Matthias Brugger,
linux-wireless, linux-mediatek, kernel-janitors
Dan Carpenter <dan.carpenter@oracle.com> writes:
> The devm_ioremap_resource() function never returns NULL, it returns
> error pointers.
>
> Fixes: c8846e101502 ("mt76: add driver for MT7603E and MT7628/7688")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> drivers/net/wireless/mediatek/mt76/mt7603/soc.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/wireless/mediatek/mt76/mt7603/soc.c b/drivers/net/wireless/mediatek/mt76/mt7603/soc.c
> index e13fea80d970..b920be1f5718 100644
> --- a/drivers/net/wireless/mediatek/mt76/mt7603/soc.c
> +++ b/drivers/net/wireless/mediatek/mt76/mt7603/soc.c
> @@ -23,9 +23,9 @@ mt76_wmac_probe(struct platform_device *pdev)
> }
>
> mem_base = devm_ioremap_resource(&pdev->dev, res);
> - if (!mem_base) {
> + if (IS_ERR(mem_base)) {
> dev_err(&pdev->dev, "Failed to get memory resource\n");
> - return -EINVAL;
> + return PTR_ERR(mem_base);
> }
Wei already posted an identical patch:
https://patchwork.kernel.org/patch/10837285/
--
Kalle Valo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-03-06 8:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-06 7:26 [PATCH] mt76: Fix an IS_ERR() vs NULL check in mt76_wmac_probe() Dan Carpenter
2019-03-06 8:50 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).