From: Kalle Valo <kvalo@codeaurora.org>
To: "Rakesh Pillai" <pillair@codeaurora.org>
Cc: "'Peter Oh'" <peter.oh@eero.com>,
'Brian Norris' <briannorris@chromium.org>,
'linux-wireless' <linux-wireless@vger.kernel.org>,
'Doug Anderson' <dianders@chromium.org>,
'ath10k' <ath10k@lists.infradead.org>,
'LKML' <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ath10k: Add interrupt summary based CE processing
Date: Wed, 26 Aug 2020 17:43:42 +0300 [thread overview]
Message-ID: <877dtlcvs1.fsf@codeaurora.org> (raw)
In-Reply-To: <000201d65f51$83d2ac60$8b780520$@codeaurora.org> (Rakesh Pillai's message of "Tue, 21 Jul 2020 16:54:30 +0530")
(Guys, PLEASE edit your quotes. These long emails my use of patchwork
horrible.)
"Rakesh Pillai" <pillair@codeaurora.org> writes:
>> -----Original Message-----
>> From: Peter Oh <peter.oh@eero.com>
>> Sent: Tuesday, July 21, 2020 7:03 AM
>> To: Kalle Valo <kvalo@codeaurora.org>
>> Cc: Brian Norris <briannorris@chromium.org>; Doug Anderson
>> <dianders@chromium.org>; linux-wireless <linux-
>> wireless@vger.kernel.org>; Rakesh Pillai <pillair@codeaurora.org>; ath10k
>> <ath10k@lists.infradead.org>; LKML <linux-kernel@vger.kernel.org>
>> Subject: Re: [PATCH] ath10k: Add interrupt summary based CE processing
>>
>> I'll take my word back.
>> It's not this patch problem, but by others.
>> I have 2 extra patches before the 3 patches so my system looks like
>>
>> backports from ath.git 5.6-rc1 + linux kernel 4.4 (similar to OpenWrt)
>> On top of the working system, I cherry-picked these 5.
>>
>> #1.
>> ath10k: Avoid override CE5 configuration for QCA99X0 chipsets
>> ath.git commit 521fc37be3d879561ca5ab42d64719cf94116af0
>> #2.
>> ath10k: Fix NULL pointer dereference in AHB device probe
>> wireless-drivers.git commit 1cfd3426ef989b83fa6176490a38777057e57f6c
>> #3.
>> ath10k: Add interrupt summary based CE processing
>> https://patchwork.kernel.org/patch/11628299/
>
> This patch is applicable only for snoc target WCN3990, since there is
> a check for per_ce_irq. For PCI targets, per_ce_irq is false, and
> hence follows a different path.
This information should be in the commit log. But I have a patch in the
pending branch which removes per_ce_irq:
[v2,2/2] ath10k: Get rid of "per_ce_irq" hw param
https://patchwork.kernel.org/patch/11654621/
So how will multilple hardware support work then?
In theory I like the patch but there's no information in the patch if
this works or breaks other hardware, especially QCA9884 or QCA6174 PCI
devices. I really need some kind of assurance that this works with all
ath10k devices, not just WCN3990 which you are working on.
I have written about this in the wiki:
https://wireless.wiki.kernel.org/en/users/drivers/ath10k/submittingpatches#hardware_families
--
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2020-08-26 14:44 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-26 17:52 [PATCH] ath10k: Add interrupt summary based CE processing Rakesh Pillai
2020-06-26 21:37 ` Doug Anderson
2020-06-26 21:49 ` Doug Anderson
2020-06-26 21:52 ` Brian Norris
2020-07-16 6:38 ` Kalle Valo
2020-07-21 0:33 ` Peter Oh
2020-07-21 0:40 ` Doug Anderson
2020-07-21 0:43 ` Peter Oh
[not found] ` <CALhWmc1B0+SONV6_AF+nUzgxZdekPD3sZuhrsmwVQx1Q-cgT_g@mail.gmail.com>
2020-07-21 0:56 ` Peter Oh
2020-07-21 0:58 ` Peter Oh
2020-07-21 1:32 ` Peter Oh
2020-07-21 11:24 ` Rakesh Pillai
2020-08-26 14:43 ` Kalle Valo [this message]
2020-08-26 14:54 ` Doug Anderson
2020-07-21 15:37 ` Doug Anderson
2020-09-01 11:59 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877dtlcvs1.fsf@codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=ath10k@lists.infradead.org \
--cc=briannorris@chromium.org \
--cc=dianders@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=peter.oh@eero.com \
--cc=pillair@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).