Re: [RFC PATCH v1] cfg80211/nl80211: add support for AID assignment by driver : https://patchwork.kernel.org/patch/10726899/

Re: [RFC PATCH v1] cfg80211/nl80211: add support for AID assignment by driver : https://patchwork.kernel.org/patch/10726899/

[Kalle Valo]

+ linux-wireless

"Garnayak, Sarada Prasanna" <sarada.prasanna.garnayak@intel.com> writes:

> Thank you so much for reviewing my RFC patch and here I would like to
> address the big concerns/comments about this RFC patch like 
>
> Ø What are the exact use case and potential user of this patch.
>
> Ø How the Hostapd will handle this get aid and free aid.
>
> Ø etc.
>
> In the current implementation in WLAN Stack, the hostapd is assigning
> the AID for a station during association. 
>
> But we have a few WLAN hardware which is maintaining the AID in the
> WLAN hardware level itself and the firmware checking this AID in the
> hardware level according to that the firmware is taking action on
> station management
>
> like (Station DB management, BA agreement, SMPS and TM management
> frame etc....). For this reason, we need these get_aid/free_aid. 
>
> Also here I am attaching the Hostapd RFC Patch for the same. PFA
> (hostapd patch, call flow diagram and comments on this kernel patch)
>
> Please review the call flow below:

You made few crucial mistakes:

1. You did not CC linux-wireless.

2. You submitted the message as HTML and our lists automatically filter
   those.

3. You attached a powerpoint file and I would hope that our lists
   automatically filter those as well. At least I'm not going to open
   any random powerpoint/word files I receive via email.

-- 
Kalle Valo

RE: [RFC PATCH v1] cfg80211/nl80211: add support for AID assignment by driver : https://patchwork.kernel.org/patch/10726899/

[Garnayak, Sarada Prasanna]

My Bad, Onwards I will submit a new version of the RFC patch to address the reviewer comments on previous RFC patch and for query or suggestions, I will definitely cc Linux-wireless in my mail without any external link or attachment.

Thanks,
Prasanna

-----Original Message-----
From: Kalle Valo [mailto:kvalo@codeaurora.org] 
Sent: Tuesday, January 8, 2019 10:50 PM
To: Garnayak, Sarada Prasanna <sarada.prasanna.garnayak@intel.com>
Cc: Berg, Johannes <johannes.berg@intel.com>; Jouni Malinen <j@w1.fi>; Sergey Matyukevich <sergey.matyukevich.os@quantenna.com>; linux-kernel@vger.kernel.org; linux-wireless@vger.kernel.org
Subject: Re: [RFC PATCH v1] cfg80211/nl80211: add support for AID assignment by driver : https://patchwork.kernel.org/patch/10726899/

+ linux-wireless

"Garnayak, Sarada Prasanna" <sarada.prasanna.garnayak@intel.com> writes:

> Thank you so much for reviewing my RFC patch and here I would like to 
> address the big concerns/comments about this RFC patch like
>
> Ø What are the exact use case and potential user of this patch.
>
> Ø How the Hostapd will handle this get aid and free aid.
>
> Ø etc.
>
> In the current implementation in WLAN Stack, the hostapd is assigning 
> the AID for a station during association.
>
> But we have a few WLAN hardware which is maintaining the AID in the 
> WLAN hardware level itself and the firmware checking this AID in the 
> hardware level according to that the firmware is taking action on 
> station management
>
> like (Station DB management, BA agreement, SMPS and TM management 
> frame etc....). For this reason, we need these get_aid/free_aid.
>
> Also here I am attaching the Hostapd RFC Patch for the same. PFA 
> (hostapd patch, call flow diagram and comments on this kernel patch)
>
> Please review the call flow below:

You made few crucial mistakes:

1. You did not CC linux-wireless.

2. You submitted the message as HTML and our lists automatically filter
   those.

3. You attached a powerpoint file and I would hope that our lists
   automatically filter those as well. At least I'm not going to open
   any random powerpoint/word files I receive via email.

--
Kalle Valo