* [PATCH v2] rtw88: add quirk to disable pci caps on HP Pavilion 14-ce0xxx
@ 2021-08-21 21:05 Larry Finger
2021-08-22 5:07 ` Kalle Valo
0 siblings, 1 reply; 2+ messages in thread
From: Larry Finger @ 2021-08-21 21:05 UTC (permalink / raw)
To: kvalo; +Cc: linux-wireless, Ugo Rémery, Larry Finger
From: Ugo Rémery <ugo.remery@gmail.com>
8821CE causes random freezes on HP Pavilion 14-ce0019nf. Add a quirk
to disable pci ASPM capability.
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
---
v2 - add s-o-b line
---
drivers/net/wireless/realtek/rtw88/pci.c | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/drivers/net/wireless/realtek/rtw88/pci.c b/drivers/net/wireless/realtek/rtw88/pci.c
index e7d17ab8f113..31ee859d379b 100644
--- a/drivers/net/wireless/realtek/rtw88/pci.c
+++ b/drivers/net/wireless/realtek/rtw88/pci.c
@@ -1701,6 +1701,15 @@ static const struct dmi_system_id rtw88_pci_quirks[] = {
},
.driver_data = (void *)BIT(QUIRK_DIS_PCI_CAP_ASPM),
},
+ {
+ .callback = disable_pci_caps,
+ .ident = "HP HP Pavilion Laptop 14-ce0xxx",
+ .matches = {
+ DMI_MATCH(DMI_SYS_VENDOR, "HP"),
+ DMI_MATCH(DMI_PRODUCT_NAME, "HP Pavilion Laptop 14-ce0xxx"),
+ },
+ .driver_data = (void *)BIT(QUIRK_DIS_PCI_CAP_ASPM),
+ },
{}
};
--
2.32.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] rtw88: add quirk to disable pci caps on HP Pavilion 14-ce0xxx
2021-08-21 21:05 [PATCH v2] rtw88: add quirk to disable pci caps on HP Pavilion 14-ce0xxx Larry Finger
@ 2021-08-22 5:07 ` Kalle Valo
0 siblings, 0 replies; 2+ messages in thread
From: Kalle Valo @ 2021-08-22 5:07 UTC (permalink / raw)
To: Larry Finger; +Cc: linux-wireless, Ugo Rémery
Larry Finger <Larry.Finger@lwfinger.net> writes:
> From: Ugo Rémery <ugo.remery@gmail.com>
>
> 8821CE causes random freezes on HP Pavilion 14-ce0019nf. Add a quirk
> to disable pci ASPM capability.
>
> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
If Ugo wrote this (which I assume he did as he is marked as the author
in the from line) his s-o-b is also needed. The order of s-o-b should be
first the author's (Ugo) and then the submitter's (Larry).
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#signed-off-by_missing
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-08-22 5:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-21 21:05 [PATCH v2] rtw88: add quirk to disable pci caps on HP Pavilion 14-ce0xxx Larry Finger
2021-08-22 5:07 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).