linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@codeaurora.org>
To: Maya Erez <merez@codeaurora.org>
Cc: Gidon Studinski <gidons@codeaurora.org>,
	linux-wireless@vger.kernel.org, wil6210@qti.qualcomm.com
Subject: Re: [PATCH 5/7] wil6210: add support for enhanced DMA RX data flows
Date: Fri, 25 May 2018 15:31:29 +0300	[thread overview]
Message-ID: <87efhzlxwe.fsf@purkki.adurom.net> (raw)
In-Reply-To: <1526227375-31881-6-git-send-email-merez@codeaurora.org> (Maya Erez's message of "Sun, 13 May 2018 19:02:53 +0300")

Maya Erez <merez@codeaurora.org> writes:

> From: Gidon Studinski <gidons@codeaurora.org>
>
> Enhanced DMA RX data path is handled using a single
> RX descriptor ring for all VIFs.
> Multiple RX status rings are supported, to allow RSS
> and multi MSI support.
> The driver gets the RX completions via the RX status rings.
> The RX status message includes the completed RX buffer ID,
> which points to the allocated SKB.
>
> The enhanced DMA RX data flow supports RX chaining, where
> multiple SKBs are merged into a single packet.
>
> Enhanced DMA HW supports RX HW reorder offload, enabled by
> default and can be disabled via module parameter.
>
> Signed-off-by: Gidon Studinski <gidons@codeaurora.org>
> Signed-off-by: Maya Erez <merez@codeaurora.org>

kbuild bot reported a warning but not sure if it's valid, please take a
look:

   drivers/net/wireless/ath/wil6210/txrx_edma.c: In function
   'wil_rx_handle_edma':
>> drivers/net/wireless/ath/wil6210/txrx_edma.c:815:7: warning: 'stats'
   may be used uninitialized in this function [-Wmaybe-uninitialized]
     stats->rx_non_data_frame++;
     ~~~~~^~~~~~~~~~~~~~~~~~~
   drivers/net/wireless/ath/wil6210/txrx_edma.c:908:24: note: 'stats'
   was declared here
     struct wil_net_stats *stats;
                           ^~~~~
-- 
Kalle Valo

  reply	other threads:[~2018-05-25 12:31 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-13 16:02 [PATCH 0/7] wil6210 patches Maya Erez
2018-05-13 16:02 ` [PATCH 1/7] wil6210: add support for Talyn-MB (Talyn ver 2.0) device Maya Erez
2018-05-13 16:02 ` [PATCH 2/7] wil6210: add support for enhanced DMA structures Maya Erez
2018-05-25 12:05   ` Kalle Valo
2018-05-13 16:02 ` [PATCH 3/7] wil6210: initialize TX and RX enhanced DMA rings Maya Erez
2018-05-25 12:06   ` Kalle Valo
2018-05-25 12:14     ` Kalle Valo
2018-05-28 10:16       ` merez
2018-05-13 16:02 ` [PATCH 4/7] wil6210: add support for enhanced DMA TX data flows Maya Erez
2018-05-13 16:02 ` [PATCH 5/7] wil6210: add support for enhanced DMA RX " Maya Erez
2018-05-25 12:31   ` Kalle Valo [this message]
2018-05-28 10:08     ` merez
2018-05-13 16:02 ` [PATCH 6/7] wil6210: add support for enhanced DMA debugfs Maya Erez
2018-05-13 16:02 ` [PATCH 7/7] wil6210: add support for Talyn-MB boot flow Maya Erez

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87efhzlxwe.fsf@purkki.adurom.net \
    --to=kvalo@codeaurora.org \
    --cc=gidons@codeaurora.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=merez@codeaurora.org \
    --cc=wil6210@qti.qualcomm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).