From: Kalle Valo <kvalo@codeaurora.org>
To: Maya Erez <merez@codeaurora.org>
Cc: Gidon Studinski <gidons@codeaurora.org>,
linux-wireless@vger.kernel.org, wil6210@qti.qualcomm.com
Subject: Re: [PATCH 3/7] wil6210: initialize TX and RX enhanced DMA rings
Date: Fri, 25 May 2018 15:06:12 +0300 [thread overview]
Message-ID: <87muwokki3.fsf@purkki.adurom.net> (raw)
In-Reply-To: <1526227375-31881-4-git-send-email-merez@codeaurora.org> (Maya Erez's message of "Sun, 13 May 2018 19:02:51 +0300")
Maya Erez <merez@codeaurora.org> writes:
> From: Gidon Studinski <gidons@codeaurora.org>
>
> Enhanced DMA design includes the following rings:
> - Single RX descriptor ring is used for all VIFs
> - Multiple RX status rings are supported, to allow RSS
> - TX descriptor ring is allocated per connection
> - A single TX status ring is used for all TX descriptor rings
>
> This patch initializes and frees the above descriptor and
> status rings.
>
> The RX SKBs are handled by a new entity of RX buffers manager,
> which handles RX buffers, each one points to an allocated SKB.
> During Rx completion processing, the driver extracts a buffer
> ID which is used as an index to the buffers array.
> After the SKB is freed the buffer is moved from the 'active'
> list to the 'free' list, indicating it can be used for another
> descriptor. During Rx refill, SKBs are allocated and attached
> to 'free' buffers. Those buffers are attached to new descriptors
> and moved to the 'active' list.
>
> Signed-off-by: Gidon Studinski <gidons@codeaurora.org>
> Signed-off-by: Maya Erez <merez@codeaurora.org>
[...]
> --- a/drivers/net/wireless/ath/wil6210/pcie_bus.c
> +++ b/drivers/net/wireless/ath/wil6210/pcie_bus.c
> @@ -32,6 +32,10 @@
> module_param(ftm_mode, bool, 0444);
> MODULE_PARM_DESC(ftm_mode, " Set factory test mode, default - false");
>
> +static bool use_enhanced_dma_hw = true;
> +module_param(use_enhanced_dma_hw, bool, 0444);
> +MODULE_PARM_DESC(use_enhanced_dma_hw, " Use enhanced or legacy DMA HW. Default: true when available");
Similarly as with debugfs, please document in the commit log any changes
in module parameters.
--
Kalle Valo
next prev parent reply other threads:[~2018-05-25 12:06 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-13 16:02 [PATCH 0/7] wil6210 patches Maya Erez
2018-05-13 16:02 ` [PATCH 1/7] wil6210: add support for Talyn-MB (Talyn ver 2.0) device Maya Erez
2018-05-13 16:02 ` [PATCH 2/7] wil6210: add support for enhanced DMA structures Maya Erez
2018-05-25 12:05 ` Kalle Valo
2018-05-13 16:02 ` [PATCH 3/7] wil6210: initialize TX and RX enhanced DMA rings Maya Erez
2018-05-25 12:06 ` Kalle Valo [this message]
2018-05-25 12:14 ` Kalle Valo
2018-05-28 10:16 ` merez
2018-05-13 16:02 ` [PATCH 4/7] wil6210: add support for enhanced DMA TX data flows Maya Erez
2018-05-13 16:02 ` [PATCH 5/7] wil6210: add support for enhanced DMA RX " Maya Erez
2018-05-25 12:31 ` Kalle Valo
2018-05-28 10:08 ` merez
2018-05-13 16:02 ` [PATCH 6/7] wil6210: add support for enhanced DMA debugfs Maya Erez
2018-05-13 16:02 ` [PATCH 7/7] wil6210: add support for Talyn-MB boot flow Maya Erez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87muwokki3.fsf@purkki.adurom.net \
--to=kvalo@codeaurora.org \
--cc=gidons@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=merez@codeaurora.org \
--cc=wil6210@qti.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).