From: Kalle Valo <kvalo@kernel.org>
To: Jeff Johnson <quic_jjohnson@quicinc.com>
Cc: Johannes Berg <johannes@sipsolutions.net>,
<linux-wireless@vger.kernel.org>,
Miri Korenblit <miriam.rachel.korenblit@intel.com>,
<ath12k@lists.infradead.org>
Subject: Re: [PATCH 2/2] wifi: iwlwifi: mvm: disable MLO for the time being
Date: Thu, 14 Mar 2024 20:28:31 +0200 [thread overview]
Message-ID: <87h6h8ekhc.fsf@kernel.org> (raw)
In-Reply-To: <50b2d162-00a1-4001-894b-d5560c4226b2@quicinc.com> (Jeff Johnson's message of "Thu, 14 Mar 2024 09:42:08 -0700")
Jeff Johnson <quic_jjohnson@quicinc.com> writes:
> On 3/14/2024 9:39 AM, Kalle Valo wrote:
>> Johannes Berg <johannes@sipsolutions.net> writes:
>>
>>> On Thu, 2024-03-14 at 18:08 +0200, Kalle Valo wrote:
>>>>
>>>>> - hw->wiphy->flags |= WIPHY_FLAG_SUPPORTS_MLO;
>>>>> + hw->wiphy->flags |= WIPHY_FLAG_DISABLE_WEXT;
>>>>
>>>> I think we should add the same for ath12k, right?
>>>>
>>>
>>> It's really up to you, I think. I'm hoping to even get this into stable,
>>> FWIW.
>>
>> ath12k doesn't support MLO yet but I feel that disabling wext already
>> now would be consistent from user's point of view.
>
> Now that I understand what this is doing I completely agree. We should prevent
> the use of wext with ath12k.
And thinking more about this I think it would be good that other drivers
supporting Wi-Fi 7 hardware do the same until they also support MLO. Of
course Wi-Fi 6 and older hardware should still support wext,
unfortunately :/
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
prev parent reply other threads:[~2024-03-14 18:28 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-14 10:09 [PATCH 1/2] wifi: cfg80211: add a flag to disable wireless extensions Johannes Berg
2024-03-14 10:09 ` [PATCH 2/2] wifi: iwlwifi: mvm: disable MLO for the time being Johannes Berg
2024-03-14 16:08 ` Kalle Valo
2024-03-14 16:09 ` Johannes Berg
2024-03-14 16:34 ` Jeff Johnson
2024-03-14 16:36 ` Johannes Berg
2024-03-14 16:39 ` Kalle Valo
2024-03-14 16:40 ` Johannes Berg
2024-03-14 16:45 ` Kalle Valo
2024-03-14 16:42 ` Jeff Johnson
2024-03-14 18:28 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h6h8ekhc.fsf@kernel.org \
--to=kvalo@kernel.org \
--cc=ath12k@lists.infradead.org \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=miriam.rachel.korenblit@intel.com \
--cc=quic_jjohnson@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).