linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Kalle Valo <kvalo@kernel.org>
Cc: linux-wireless@vger.kernel.org,
	Miri Korenblit <miriam.rachel.korenblit@intel.com>,
	ath12k@lists.infradead.org
Subject: Re: [PATCH 2/2] wifi: iwlwifi: mvm: disable MLO for the time being
Date: Thu, 14 Mar 2024 17:40:21 +0100	[thread overview]
Message-ID: <db6a60e0dbd66f307a5890d958f67029ad5bcb4f.camel@sipsolutions.net> (raw)
In-Reply-To: <87plvwepjq.fsf@kernel.org>

On Thu, 2024-03-14 at 18:39 +0200, Kalle Valo wrote:
> Johannes Berg <johannes@sipsolutions.net> writes:
> 
> > On Thu, 2024-03-14 at 18:08 +0200, Kalle Valo wrote:
> > > 
> > > > -		hw->wiphy->flags |= WIPHY_FLAG_SUPPORTS_MLO;
> > > > +		hw->wiphy->flags |= WIPHY_FLAG_DISABLE_WEXT;
> > > 
> > > I think we should add the same for ath12k, right?
> > > 
> > 
> > It's really up to you, I think. I'm hoping to even get this into stable,
> > FWIW.
> 
> ath12k doesn't support MLO yet but I feel that disabling wext already
> now would be consistent from user's point of view.

Ah, you're in the situation where wext is still enabled now, but will
disappear when you enable MLO.

Agree then that it would make sense to disable wext right now so it's
not a software upgrade for the same hardware that removes it.

johannes

  reply	other threads:[~2024-03-14 16:40 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-14 10:09 [PATCH 1/2] wifi: cfg80211: add a flag to disable wireless extensions Johannes Berg
2024-03-14 10:09 ` [PATCH 2/2] wifi: iwlwifi: mvm: disable MLO for the time being Johannes Berg
2024-03-14 16:08   ` Kalle Valo
2024-03-14 16:09     ` Johannes Berg
2024-03-14 16:34       ` Jeff Johnson
2024-03-14 16:36         ` Johannes Berg
2024-03-14 16:39       ` Kalle Valo
2024-03-14 16:40         ` Johannes Berg [this message]
2024-03-14 16:45           ` Kalle Valo
2024-03-14 16:42         ` Jeff Johnson
2024-03-14 18:28           ` Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=db6a60e0dbd66f307a5890d958f67029ad5bcb4f.camel@sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=ath12k@lists.infradead.org \
    --cc=kvalo@kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=miriam.rachel.korenblit@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).