* Variable-length arrays considered bad
@ 2018-03-08 8:40 Kalle Valo
2018-03-09 7:28 ` Amitkumar Karwar
0 siblings, 1 reply; 3+ messages in thread
From: Kalle Valo @ 2018-03-08 8:40 UTC (permalink / raw)
To: linux-wireless
Hi,
in an lkml discussion[1] it was mentioned that variable-length arrays
should not be used. Few warnings were found[2] from wireless:
drivers/net/wireless/ath/ath9k/dfs.c:104:2: warning: ISO C90 forbids variable length array 'max_bin' [-Wvla]
drivers/net/wireless/rsi/rsi_91x_sdio.c:570:2: warning: ISO C90 forbids variable length array 'temp_buf' [-Wvla]
Patches welcome.
[1] https://lkml.kernel.org/r/CA+55aFzCG-zNmZwX4A2FQpadafLfEzK6CC=qPXydAacU1RqZWA@mail.gmail.com
[2] http://paste.ubuntu.com/p/srQxwPQS9s/
--
Kalle Valo
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Variable-length arrays considered bad
2018-03-08 8:40 Variable-length arrays considered bad Kalle Valo
@ 2018-03-09 7:28 ` Amitkumar Karwar
2018-03-09 10:38 ` Kalle Valo
0 siblings, 1 reply; 3+ messages in thread
From: Amitkumar Karwar @ 2018-03-09 7:28 UTC (permalink / raw)
To: Kalle Valo; +Cc: linux-wireless
On Thu, Mar 8, 2018 at 2:10 PM, Kalle Valo <kvalo@codeaurora.org> wrote:
> Hi,
>
> in an lkml discussion[1] it was mentioned that variable-length arrays
> should not be used. Few warnings were found[2] from wireless:
>
> drivers/net/wireless/ath/ath9k/dfs.c:104:2: warning: ISO C90 forbids variable length array 'max_bin' [-Wvla]
> drivers/net/wireless/rsi/rsi_91x_sdio.c:570:2: warning: ISO C90 forbids variable length array 'temp_buf' [-Wvla]
>
> Patches welcome.
>
> [1] https://lkml.kernel.org/r/CA+55aFzCG-zNmZwX4A2FQpadafLfEzK6CC=qPXydAacU1RqZWA@mail.gmail.com
>
> [2] http://paste.ubuntu.com/p/srQxwPQS9s/
>
I will submit a cleanup patch for RSI warning
Regards,
Amitkumar Karwar
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Variable-length arrays considered bad
2018-03-09 7:28 ` Amitkumar Karwar
@ 2018-03-09 10:38 ` Kalle Valo
0 siblings, 0 replies; 3+ messages in thread
From: Kalle Valo @ 2018-03-09 10:38 UTC (permalink / raw)
To: Amitkumar Karwar; +Cc: linux-wireless
Amitkumar Karwar <amitkarwar@gmail.com> writes:
> On Thu, Mar 8, 2018 at 2:10 PM, Kalle Valo <kvalo@codeaurora.org> wrote:
>> Hi,
>>
>> in an lkml discussion[1] it was mentioned that variable-length arrays
>> should not be used. Few warnings were found[2] from wireless:
>>
>> drivers/net/wireless/ath/ath9k/dfs.c:104:2: warning: ISO C90 forbids
>> variable length array 'max_bin' [-Wvla]
>> drivers/net/wireless/rsi/rsi_91x_sdio.c:570:2: warning: ISO C90
>> forbids variable length array 'temp_buf' [-Wvla]
>>
>> Patches welcome.
>>
>> [1]
>> https://lkml.kernel.org/r/CA+55aFzCG-zNmZwX4A2FQpadafLfEzK6CC=qPXydAacU1RqZWA@mail.gmail.com
>>
>> [2] http://paste.ubuntu.com/p/srQxwPQS9s/
>>
>
> I will submit a cleanup patch for RSI warning
Thanks, but Tobin was faster:
https://lkml.kernel.org/r/1520577493-24603-1-git-send-email-me@tobin.cc
He just forgot to CC linux-wireless.
--
Kalle Valo
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-03-09 10:38 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-03-08 8:40 Variable-length arrays considered bad Kalle Valo
2018-03-09 7:28 ` Amitkumar Karwar
2018-03-09 10:38 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).