From: Kalle Valo <kvalo@codeaurora.org>
To: Ping-Ke Shih <pkshih@realtek.com>
Cc: <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH v6 06/24] rtw89: add files to download and communicate with firmware
Date: Fri, 01 Oct 2021 18:55:27 +0300 [thread overview]
Message-ID: <87o888ivtc.fsf@codeaurora.org> (raw)
In-Reply-To: <20210820043538.12424-7-pkshih@realtek.com> (Ping-Ke Shih's message of "Fri, 20 Aug 2021 12:35:20 +0800")
Ping-Ke Shih <pkshih@realtek.com> writes:
> The firmware must be downloaded right after HCI basic initialization, and
> then we can obtain hardware capabilities that are used to do mac80211
> register hw.
>
> To download firmware, we need to parse the header to know how many sections
> the firmware has, and then download each section to proper location.
>
> We introduce H2C and C2H to do bi-direction communication with firmware,
> and both support packet-based and register-based methods.
> Normally, we use packet-based H2C/C2H, because it has no number and size
> limits. In contrast, register-based H2C/C2H has only one message and
> fix-four-dword in size.
>
> Header size of packet-based H2C/C2H is eight bytes (two dwords), which uses
> a hierarchical IDs, containing type, category, class and function, to
> classify a H2C or C2H command.
>
> When a C2H is received in interrupt context, we don't process it right
> there, but queue the skb and wake up a ieee80211 work to handle the skb.
>
> Signed-off-by: Ping-Ke Shih <pkshih@realtek.com>
[...]
> +static __always_inline void RTW89_SET_FWCMD(u8 *cmd, u32 val, u8 offset, u32 mask)
> +{
> + u32 *cmd32 = (u32 *)cmd;
> +
> + le32p_replace_bits((__le32 *)(cmd32 + offset), val, mask);
> +}
> +
> +static __always_inline void RTW89_SET_FWCMD_UA8(u8 *cmd, u8 val, u8 offset, u32 mask)
> +{
> + u8p_replace_bits(cmd + offset, val, mask);
> +}
> +
> +static __always_inline void RTW89_SET_FWCMD_UA16(u8 *cmd, u16 val, u8
> offset, u32 mask)
> +{
> + le16p_replace_bits((__le16 *)(cmd + offset), val, mask);
> +}
> +
> +static __always_inline void RTW89_SET_FWCMD_UA32(u8 *cmd, u32 val, u8
> offset, u32 mask)
> +{
> + le32p_replace_bits((__le32 *)(cmd + offset), val, mask);
> +}
Is __always_inline really necessary? I would say just use the regular
inline keyword and let the compiler optimise as it sees fit.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2021-10-01 15:55 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-20 4:35 [PATCH v6 00/24] rtw89: add Realtek 802.11ax driver Ping-Ke Shih
2021-08-20 4:35 ` [PATCH v6 01/24] rtw89: add CAM files Ping-Ke Shih
2021-10-01 14:46 ` Kalle Valo
2021-08-20 4:35 ` [PATCH v6 02/24] rtw89: add BT coexistence files Ping-Ke Shih
2021-10-01 15:26 ` Kalle Valo
2021-10-01 17:40 ` Small driver submissions and long feedback cycles Brian Norris
2021-08-20 4:35 ` [PATCH v6 03/24] rtw89: add core and trx files Ping-Ke Shih
2021-10-01 16:26 ` Kalle Valo
2021-10-05 7:16 ` Pkshih
2021-10-05 7:46 ` Kalle Valo
2021-10-05 8:42 ` Arnd Bergmann
2021-10-05 9:32 ` Pkshih
2021-10-05 9:59 ` Arnd Bergmann
2021-10-06 1:35 ` Pkshih
2021-10-06 7:32 ` Arnd Bergmann
2021-10-06 8:19 ` Pkshih
2021-08-20 4:35 ` [PATCH v6 04/24] rtw89: add debug files Ping-Ke Shih
2021-08-20 4:35 ` [PATCH v6 05/24] rtw89: add efuse files Ping-Ke Shih
2021-08-20 4:35 ` [PATCH v6 06/24] rtw89: add files to download and communicate with firmware Ping-Ke Shih
2021-10-01 15:55 ` Kalle Valo [this message]
2021-08-20 4:35 ` [PATCH v6 07/24] rtw89: add MAC files Ping-Ke Shih
2021-10-01 16:13 ` Kalle Valo
2021-08-20 4:35 ` [PATCH v6 08/24] rtw89: implement mac80211 ops Ping-Ke Shih
2021-08-20 4:35 ` [PATCH v6 09/24] rtw89: add pci files Ping-Ke Shih
2021-08-20 4:35 ` [PATCH v6 10/24] rtw89: add phy files Ping-Ke Shih
2021-08-20 4:35 ` [PATCH v6 11/24] rtw89: define register names Ping-Ke Shih
2021-08-20 4:35 ` [PATCH v6 12/24] rtw89: add regulatory support Ping-Ke Shih
2021-08-20 4:35 ` [PATCH v6 13/24] rtw89: 8852a: add 8852a specific files Ping-Ke Shih
2021-10-01 16:20 ` Kalle Valo
2021-08-20 4:35 ` [PATCH v6 14/24] rtw89: 8852a: add 8852a RFK files Ping-Ke Shih
2021-08-20 4:35 ` [PATCH v6 15/24] rtw89: 8852a: add 8852a RFK tables Ping-Ke Shih
2021-08-20 4:35 ` [PATCH v6 16/24] rtw89: 8852a: add 8852a tables (1 of 5) Ping-Ke Shih
2021-08-20 4:35 ` [PATCH v6 17/24] rtw89: 8852a: add 8852a tables (2 " Ping-Ke Shih
2021-08-20 4:35 ` [PATCH v6 18/24] rtw89: 8852a: add 8852a tables (3 " Ping-Ke Shih
2021-08-20 4:35 ` [PATCH v6 19/24] rtw89: 8852a: add 8852a tables (4 " Ping-Ke Shih
2021-08-20 4:35 ` [PATCH v6 20/24] rtw89: 8852a: add 8852a tables (5 " Ping-Ke Shih
2021-08-20 4:35 ` [PATCH v6 21/24] rtw89: add ser to recover error reported by firmware Ping-Ke Shih
2021-08-20 4:35 ` [PATCH v6 22/24] rtw89: add PS files Ping-Ke Shih
2021-08-20 4:35 ` [PATCH v6 23/24] rtw89: add SAR files Ping-Ke Shih
2021-08-20 4:35 ` [PATCH v6 24/24] rtw89: add Kconfig and Makefile Ping-Ke Shih
2021-08-22 3:43 ` kernel test robot
2021-08-23 1:37 ` Pkshih
2021-10-01 15:57 ` Kalle Valo
2021-10-01 16:34 ` [PATCH v6 00/24] rtw89: add Realtek 802.11ax driver Kalle Valo
2021-10-01 16:42 ` Larry Finger
2021-10-01 16:46 ` Kalle Valo
2021-10-01 17:18 ` Larry Finger
2021-10-05 5:46 ` Kalle Valo
2021-10-04 6:46 ` Pkshih
2021-10-05 5:52 ` Kalle Valo
2021-10-06 0:10 ` Brian Norris
2021-10-08 4:14 ` Pkshih
2021-10-08 4:11 ` Pkshih
2021-10-09 8:28 ` Kalle Valo
2021-10-12 1:53 ` Pkshih
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o888ivtc.fsf@codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=pkshih@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).