From: Kalle Valo <kvalo@codeaurora.org>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: Ping-Ke Shih <pkshih@realtek.com>, linux-wireless@vger.kernel.org
Subject: Re: [PATCH v6 00/24] rtw89: add Realtek 802.11ax driver
Date: Fri, 01 Oct 2021 19:46:59 +0300 [thread overview]
Message-ID: <87y27chev0.fsf@codeaurora.org> (raw)
In-Reply-To: <7df9058b-4983-6d0e-07f7-8fe4df1cff27@lwfinger.net> (Larry Finger's message of "Fri, 1 Oct 2021 11:42:27 -0500")
Larry Finger <Larry.Finger@lwfinger.net> writes:
> On 10/1/21 11:34, Kalle Valo wrote:
>> Ping-Ke Shih <pkshih@realtek.com> writes:
>>
>>> This driver named rtw89, which is the next generation of rtw88, supports
>>> Realtek 8852AE 802.11ax 2x2 chip whose new features are OFDMA, DBCC,
>>> Spatial reuse, TWT and BSS coloring; now some of them aren't implemented
>>> though.
>>>
>>> The chip architecture is entirely different from the chips supported by
>>> rtw88 like RTL8822CE 802.11ac chip. First of all, register address ranges
>>> are totally redefined, so it's impossible to reuse register definition. To
>>> communicate with firmware, new H2C/C2H format is proposed. In order to have
>>> better utilization, TX DMA flow is changed to two stages DMA. To provide
>>> rich RX status information, additional RX PPDU packets are added.
>>>
>>> Since there are so many differences mentioned above, we decide to propose
>>> a new driver. It has many authors, they are listed in alphabetic order:
>>
>> I did a review now and this looks pretty good to me. Kconfig has a
>> different license and lots of static/extern variables which are not
>> const, otherwise I only saw smaller issues. But I do have to admit that
>> after mac.h (in alphabetical order) my review was more on the sloppy
>> side, this is a large driver.
>>
>> The community has been testing this driver already, right?
>
> Kalle,
>
> As soon as Ping-Ke submitted this driver, I created a stand-alone
> version at GitHub so that people with new laptops containing this chip
> would have a source for the driver. There have been minor hiccups that
> we have fixed along the way. I am also testing it on my system.
Nice, so I can assume there are quite a few users for this driver
already?
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2021-10-01 16:47 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-20 4:35 [PATCH v6 00/24] rtw89: add Realtek 802.11ax driver Ping-Ke Shih
2021-08-20 4:35 ` [PATCH v6 01/24] rtw89: add CAM files Ping-Ke Shih
2021-10-01 14:46 ` Kalle Valo
2021-08-20 4:35 ` [PATCH v6 02/24] rtw89: add BT coexistence files Ping-Ke Shih
2021-10-01 15:26 ` Kalle Valo
2021-10-01 17:40 ` Small driver submissions and long feedback cycles Brian Norris
2021-08-20 4:35 ` [PATCH v6 03/24] rtw89: add core and trx files Ping-Ke Shih
2021-10-01 16:26 ` Kalle Valo
2021-10-05 7:16 ` Pkshih
2021-10-05 7:46 ` Kalle Valo
2021-10-05 8:42 ` Arnd Bergmann
2021-10-05 9:32 ` Pkshih
2021-10-05 9:59 ` Arnd Bergmann
2021-10-06 1:35 ` Pkshih
2021-10-06 7:32 ` Arnd Bergmann
2021-10-06 8:19 ` Pkshih
2021-08-20 4:35 ` [PATCH v6 04/24] rtw89: add debug files Ping-Ke Shih
2021-08-20 4:35 ` [PATCH v6 05/24] rtw89: add efuse files Ping-Ke Shih
2021-08-20 4:35 ` [PATCH v6 06/24] rtw89: add files to download and communicate with firmware Ping-Ke Shih
2021-10-01 15:55 ` Kalle Valo
2021-08-20 4:35 ` [PATCH v6 07/24] rtw89: add MAC files Ping-Ke Shih
2021-10-01 16:13 ` Kalle Valo
2021-08-20 4:35 ` [PATCH v6 08/24] rtw89: implement mac80211 ops Ping-Ke Shih
2021-08-20 4:35 ` [PATCH v6 09/24] rtw89: add pci files Ping-Ke Shih
2021-08-20 4:35 ` [PATCH v6 10/24] rtw89: add phy files Ping-Ke Shih
2021-08-20 4:35 ` [PATCH v6 11/24] rtw89: define register names Ping-Ke Shih
2021-08-20 4:35 ` [PATCH v6 12/24] rtw89: add regulatory support Ping-Ke Shih
2021-08-20 4:35 ` [PATCH v6 13/24] rtw89: 8852a: add 8852a specific files Ping-Ke Shih
2021-10-01 16:20 ` Kalle Valo
2021-08-20 4:35 ` [PATCH v6 14/24] rtw89: 8852a: add 8852a RFK files Ping-Ke Shih
2021-08-20 4:35 ` [PATCH v6 15/24] rtw89: 8852a: add 8852a RFK tables Ping-Ke Shih
2021-08-20 4:35 ` [PATCH v6 16/24] rtw89: 8852a: add 8852a tables (1 of 5) Ping-Ke Shih
2021-08-20 4:35 ` [PATCH v6 17/24] rtw89: 8852a: add 8852a tables (2 " Ping-Ke Shih
2021-08-20 4:35 ` [PATCH v6 18/24] rtw89: 8852a: add 8852a tables (3 " Ping-Ke Shih
2021-08-20 4:35 ` [PATCH v6 19/24] rtw89: 8852a: add 8852a tables (4 " Ping-Ke Shih
2021-08-20 4:35 ` [PATCH v6 20/24] rtw89: 8852a: add 8852a tables (5 " Ping-Ke Shih
2021-08-20 4:35 ` [PATCH v6 21/24] rtw89: add ser to recover error reported by firmware Ping-Ke Shih
2021-08-20 4:35 ` [PATCH v6 22/24] rtw89: add PS files Ping-Ke Shih
2021-08-20 4:35 ` [PATCH v6 23/24] rtw89: add SAR files Ping-Ke Shih
2021-08-20 4:35 ` [PATCH v6 24/24] rtw89: add Kconfig and Makefile Ping-Ke Shih
2021-08-22 3:43 ` kernel test robot
2021-08-23 1:37 ` Pkshih
2021-10-01 15:57 ` Kalle Valo
2021-10-01 16:34 ` [PATCH v6 00/24] rtw89: add Realtek 802.11ax driver Kalle Valo
2021-10-01 16:42 ` Larry Finger
2021-10-01 16:46 ` Kalle Valo [this message]
2021-10-01 17:18 ` Larry Finger
2021-10-05 5:46 ` Kalle Valo
2021-10-04 6:46 ` Pkshih
2021-10-05 5:52 ` Kalle Valo
2021-10-06 0:10 ` Brian Norris
2021-10-08 4:14 ` Pkshih
2021-10-08 4:11 ` Pkshih
2021-10-09 8:28 ` Kalle Valo
2021-10-12 1:53 ` Pkshih
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y27chev0.fsf@codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=Larry.Finger@lwfinger.net \
--cc=linux-wireless@vger.kernel.org \
--cc=pkshih@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).