Re: drivers/net/wireless/realtek/rtw88/pci.c:1477:5: warning: no previous prototype for 'rtw_pci_probe'

Re: drivers/net/wireless/realtek/rtw88/pci.c:1477:5: warning: no previous prototype for 'rtw_pci_probe'

[Kalle Valo]

+ linux-wireless

kernel test robot <lkp@intel.com> writes:

> Hi Zong-Zhe,
>
> FYI, the error/warning still remains.
>
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> head:   23ee3e4e5bd27bdbc0f1785eef7209ce872794c7
> commit: 72f256c2b948622cc45ff8bc0456dd6039d8fe36 rtw88: extract:
> export symbols about pci interface
> date:   10 weeks ago
> config: arc-randconfig-r026-20200725 (attached as .config)
> compiler: arc-elf-gcc (GCC) 9.3.0
> reproduce (this is a W=1 build):
>         wget
> https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross
> -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         git checkout 72f256c2b948622cc45ff8bc0456dd6039d8fe36
>         # save the attached .config to linux build tree
>         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arc 
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
>
> All warnings (new ones prefixed by >>):
>
>>> drivers/net/wireless/realtek/rtw88/pci.c:1477:5: warning: no
>>> previous prototype for 'rtw_pci_probe' [-Wmissing-prototypes]
>     1477 | int rtw_pci_probe(struct pci_dev *pdev,
>          |     ^~~~~~~~~~~~~
>>> drivers/net/wireless/realtek/rtw88/pci.c:1557:6: warning: no
>>> previous prototype for 'rtw_pci_remove' [-Wmissing-prototypes]
>     1557 | void rtw_pci_remove(struct pci_dev *pdev)
>          |      ^~~~~~~~~~~~~~
>>> drivers/net/wireless/realtek/rtw88/pci.c:1579:6: warning: no
>>> previous prototype for 'rtw_pci_shutdown' [-Wmissing-prototypes]
>     1579 | void rtw_pci_shutdown(struct pci_dev *pdev)
>          |      ^~~~~~~~~~~~~~~~

Tony, these are older warnings but please also check these.

-- 
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

RE: drivers/net/wireless/realtek/rtw88/pci.c:1477:5: warning: no previous prototype for 'rtw_pci_probe'

[Tony Chuang]

> + linux-wireless
> 
> kernel test robot <lkp@intel.com> writes:
> 
> > Hi Zong-Zhe,
> >
> > FYI, the error/warning still remains.
> >
> > tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
> master
> > head:   23ee3e4e5bd27bdbc0f1785eef7209ce872794c7
> > commit: 72f256c2b948622cc45ff8bc0456dd6039d8fe36 rtw88: extract:
> > export symbols about pci interface
> > date:   10 weeks ago
> > config: arc-randconfig-r026-20200725 (attached as .config)
> > compiler: arc-elf-gcc (GCC) 9.3.0
> > reproduce (this is a W=1 build):
> >         wget
> > https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross
> > -O ~/bin/make.cross
> >         chmod +x ~/bin/make.cross
> >         git checkout 72f256c2b948622cc45ff8bc0456dd6039d8fe36
> >         # save the attached .config to linux build tree
> >         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0
> make.cross ARCH=arc
> >
> > If you fix the issue, kindly add following tag as appropriate
> > Reported-by: kernel test robot <lkp@intel.com>
> >
> > All warnings (new ones prefixed by >>):
> >
> >>> drivers/net/wireless/realtek/rtw88/pci.c:1477:5: warning: no
> >>> previous prototype for 'rtw_pci_probe' [-Wmissing-prototypes]
> >     1477 | int rtw_pci_probe(struct pci_dev *pdev,
> >          |     ^~~~~~~~~~~~~
> >>> drivers/net/wireless/realtek/rtw88/pci.c:1557:6: warning: no
> >>> previous prototype for 'rtw_pci_remove' [-Wmissing-prototypes]
> >     1557 | void rtw_pci_remove(struct pci_dev *pdev)
> >          |      ^~~~~~~~~~~~~~
> >>> drivers/net/wireless/realtek/rtw88/pci.c:1579:6: warning: no
> >>> previous prototype for 'rtw_pci_shutdown' [-Wmissing-prototypes]
> >     1579 | void rtw_pci_shutdown(struct pci_dev *pdev)
> >          |      ^~~~~~~~~~~~~~~~
> 
> Tony, these are older warnings but please also check these.
> 

I think this warning can be ignored, as the commit was going to export
pci symbols for the follow-up patches to use, such as:

f56f08636dda rtw88: extract: make 8723d an individual kernel module
416e87fcc780 rtw88: extract: make 8822b an individual kernel module
ba0fbe236fb8 rtw88: extract: make 8822c an individual kernel module

And these patches were submitted and applied together.

Thanks,
Yen-Hsuan

Re: drivers/net/wireless/realtek/rtw88/pci.c:1477:5: warning: no previous prototype for 'rtw_pci_probe'

[Kalle Valo]

Tony Chuang <yhchuang@realtek.com> writes:

>> + linux-wireless
>> 
>> kernel test robot <lkp@intel.com> writes:
>> 
>> > Hi Zong-Zhe,
>> >
>> > FYI, the error/warning still remains.
>> >
>> > tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
>> master
>> > head:   23ee3e4e5bd27bdbc0f1785eef7209ce872794c7
>> > commit: 72f256c2b948622cc45ff8bc0456dd6039d8fe36 rtw88: extract:
>> > export symbols about pci interface
>> > date:   10 weeks ago
>> > config: arc-randconfig-r026-20200725 (attached as .config)
>> > compiler: arc-elf-gcc (GCC) 9.3.0
>> > reproduce (this is a W=1 build):
>> >         wget
>> > https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross
>> > -O ~/bin/make.cross
>> >         chmod +x ~/bin/make.cross
>> >         git checkout 72f256c2b948622cc45ff8bc0456dd6039d8fe36
>> >         # save the attached .config to linux build tree
>> >         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0
>> make.cross ARCH=arc
>> >
>> > If you fix the issue, kindly add following tag as appropriate
>> > Reported-by: kernel test robot <lkp@intel.com>
>> >
>> > All warnings (new ones prefixed by >>):
>> >
>> >>> drivers/net/wireless/realtek/rtw88/pci.c:1477:5: warning: no
>> >>> previous prototype for 'rtw_pci_probe' [-Wmissing-prototypes]
>> >     1477 | int rtw_pci_probe(struct pci_dev *pdev,
>> >          |     ^~~~~~~~~~~~~
>> >>> drivers/net/wireless/realtek/rtw88/pci.c:1557:6: warning: no
>> >>> previous prototype for 'rtw_pci_remove' [-Wmissing-prototypes]
>> >     1557 | void rtw_pci_remove(struct pci_dev *pdev)
>> >          |      ^~~~~~~~~~~~~~
>> >>> drivers/net/wireless/realtek/rtw88/pci.c:1579:6: warning: no
>> >>> previous prototype for 'rtw_pci_shutdown' [-Wmissing-prototypes]
>> >     1579 | void rtw_pci_shutdown(struct pci_dev *pdev)
>> >          |      ^~~~~~~~~~~~~~~~
>> 
>> Tony, these are older warnings but please also check these.
>> 
>
> I think this warning can be ignored, as the commit was going to export
> pci symbols for the follow-up patches to use, such as:
>
> f56f08636dda rtw88: extract: make 8723d an individual kernel module
> 416e87fcc780 rtw88: extract: make 8822b an individual kernel module
> ba0fbe236fb8 rtw88: extract: make 8822c an individual kernel module
>
> And these patches were submitted and applied together.

Good, thanks for checking.

-- 
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

Re: drivers/net/wireless/realtek/rtw88/pci.c:1477:5: warning: no previous prototype for 'rtw_pci_probe'

[Kalle Valo]

Tony Chuang <yhchuang@realtek.com> writes:

>> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
>> head:   ef2e9a563b0cd7965e2a1263125dcbb1c86aa6cc
>> commit: ba0fbe236fb8a7b992e82d6eafb03a600f5eba43 rtw88: extract: make
>> 8822c an individual kernel module
>> date:   4 months ago
>> config: i386-randconfig-r034-20200913 (attached as .config)
>> compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
>> reproduce (this is a W=1 build):
>>         git checkout ba0fbe236fb8a7b992e82d6eafb03a600f5eba43
>>         # save the attached .config to linux build tree
>>         make W=1 ARCH=i386
>> 
>> If you fix the issue, kindly add following tag as appropriate
>> Reported-by: kernel test robot <lkp@intel.com>
>> 
>> All warnings (new ones prefixed by >>):
>> 
>> >> drivers/net/wireless/realtek/rtw88/pci.c:1477:5: warning: no previous
>> >> prototype for 'rtw_pci_probe' [-Wmissing-prototypes]
>>     1477 | int rtw_pci_probe(struct pci_dev *pdev,
>>          |     ^~~~~~~~~~~~~
>> >> drivers/net/wireless/realtek/rtw88/pci.c:1557:6: warning: no previous
>> >> prototype for 'rtw_pci_remove' [-Wmissing-prototypes]
>>     1557 | void rtw_pci_remove(struct pci_dev *pdev)
>>          |      ^~~~~~~~~~~~~~
>> >> drivers/net/wireless/realtek/rtw88/pci.c:1579:6: warning: no previous
>> >> prototype for 'rtw_pci_shutdown' [-Wmissing-prototypes]
>>     1579 | void rtw_pci_shutdown(struct pci_dev *pdev)
>>          |      ^~~~~~~~~~~~~~~~
>> 

[...]

> Hi Kalle,
>
> The exported function is used by the following patchset.
> So this is a false alarm.

Good, thanks for checking.

-- 
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches