* [PATCH] wireless: ath: return error code upstream
@ 2018-12-26 6:43 Kangjie Lu
2019-01-08 16:47 ` Kalle Valo
2019-01-10 13:29 ` Kalle Valo
0 siblings, 2 replies; 3+ messages in thread
From: Kangjie Lu @ 2018-12-26 6:43 UTC (permalink / raw)
To: kjlu
Cc: pakki001, Kalle Valo, David S. Miller, linux-wireless, netdev,
linux-kernel
ath6kl_wmi_cmd_send could fail, so let's return its error code upstream.
Signed-off-by: Kangjie Lu <kjlu@umn.edu>
---
drivers/net/wireless/ath/ath6kl/wmi.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/net/wireless/ath/ath6kl/wmi.c b/drivers/net/wireless/ath/ath6kl/wmi.c
index 777acc564ac9..1f3cead3180b 100644
--- a/drivers/net/wireless/ath/ath6kl/wmi.c
+++ b/drivers/net/wireless/ath/ath6kl/wmi.c
@@ -776,10 +776,8 @@ int ath6kl_wmi_set_roam_lrssi_cmd(struct wmi *wmi, u8 lrssi)
cmd->info.params.roam_rssi_floor = DEF_LRSSI_ROAM_FLOOR;
cmd->roam_ctrl = WMI_SET_LRSSI_SCAN_PARAMS;
- ath6kl_wmi_cmd_send(wmi, 0, skb, WMI_SET_ROAM_CTRL_CMDID,
+ return ath6kl_wmi_cmd_send(wmi, 0, skb, WMI_SET_ROAM_CTRL_CMDID,
NO_SYNC_WMIFLAG);
-
- return 0;
}
int ath6kl_wmi_force_roam_cmd(struct wmi *wmi, const u8 *bssid)
--
2.17.2 (Apple Git-113)
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] wireless: ath: return error code upstream
2018-12-26 6:43 [PATCH] wireless: ath: return error code upstream Kangjie Lu
@ 2019-01-08 16:47 ` Kalle Valo
2019-01-10 13:29 ` Kalle Valo
1 sibling, 0 replies; 3+ messages in thread
From: Kalle Valo @ 2019-01-08 16:47 UTC (permalink / raw)
To: Kangjie Lu
Cc: pakki001, David S. Miller, linux-wireless, netdev, linux-kernel
Kangjie Lu <kjlu@umn.edu> writes:
> ath6kl_wmi_cmd_send could fail, so let's return its error code upstream.
>
> Signed-off-by: Kangjie Lu <kjlu@umn.edu>
> ---
> drivers/net/wireless/ath/ath6kl/wmi.c | 4 +---
The correct prefix is "ath6kl: " but I can fix that.
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#commit_title_is_wrong
--
Kalle Valo
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] wireless: ath: return error code upstream
2018-12-26 6:43 [PATCH] wireless: ath: return error code upstream Kangjie Lu
2019-01-08 16:47 ` Kalle Valo
@ 2019-01-10 13:29 ` Kalle Valo
1 sibling, 0 replies; 3+ messages in thread
From: Kalle Valo @ 2019-01-10 13:29 UTC (permalink / raw)
To: Kangjie Lu
Cc: kjlu, pakki001, David S. Miller, linux-wireless, netdev, linux-kernel
Kangjie Lu <kjlu@umn.edu> wrote:
> ath6kl_wmi_cmd_send could fail, so let's return its error code upstream.
>
> Signed-off-by: Kangjie Lu <kjlu@umn.edu>
> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Patch applied to ath-next branch of ath.git, thanks.
fc6a6521556c ath6kl: return error code in ath6kl_wmi_set_roam_lrssi_cmd()
--
https://patchwork.kernel.org/patch/10742845/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-01-10 13:29 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-12-26 6:43 [PATCH] wireless: ath: return error code upstream Kangjie Lu
2019-01-08 16:47 ` Kalle Valo
2019-01-10 13:29 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).