From: Kalle Valo <kvalo@codeaurora.org>
To: Lorenzo Bianconi <lorenzo@kernel.org>
Cc: nbd@nbd.name, linux-wireless@vger.kernel.org,
lorenzo.bianconi@redhat.com, sean.wang@mediatek.com,
ryder.lee@mediatek.com
Subject: Re: [PATCH wireless-drivers] mt76: fix possible pktid leak
Date: Fri, 26 Nov 2021 17:57:42 +0200 [thread overview]
Message-ID: <87sfvij4eh.fsf@codeaurora.org> (raw)
In-Reply-To: <YaD8lT5csiLvmBzS@lore-desk> (Lorenzo Bianconi's message of "Fri, 26 Nov 2021 16:26:13 +0100")
Lorenzo Bianconi <lorenzo@kernel.org> writes:
>> Lorenzo Bianconi <lorenzo@kernel.org> writes:
>>
>> >> Lorenzo Bianconi <lorenzo@kernel.org> wrote:
>> >>
>> >> > Fix a possible idr pkt-id leak if the packet is dropped on tx side
>> >> >
>> >> > Fixes: bd1e3e7b693c ("mt76: introduce packet_id idr")
>> >> > Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
>> >> > Acked-by: Felix Fietkau <nbd@nbd.name>
>> >>
>> >> Patch applied to wireless-drivers.git, thanks.
>> >>
>> >> 2a9e9857473b mt76: fix possible pktid leak
>> >
>> > Hi Kalle,
>> >
>> > Unfortunately I found a regression introduced by this patch for mt7663u (and I
>> > guess for mt7921s as well). Do you want me to post a fix or just a v2?
>>
>> I don't rebase my trees, so please post a fix. I was planning to submit
>> a pull request to net tree today, but is this so serious that I should
>> skip that?
>
> I have already tested mt7663u but I do not have mt7921s hw for testing (but the
> behaviour should be the same). I guess we can split the patch, just post the
> fix for mt7663u and let Sean the time to test it on mt7921s (I am not sure
> mt7921s is already available on the market). In this way you can send the PR
> today. What do you think?
I think it's best to wait, I prefer to have proper build testing on my
tree before I submit the pull request.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2021-11-26 15:59 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-22 17:34 [PATCH wireless-drivers] mt76: fix possible pktid leak Lorenzo Bianconi
2021-11-24 8:07 ` Kalle Valo
2021-11-24 8:58 ` Felix Fietkau
2021-11-24 17:21 ` Kalle Valo
2021-11-26 14:02 ` Lorenzo Bianconi
2021-11-26 14:57 ` Kalle Valo
2021-11-26 15:26 ` Lorenzo Bianconi
2021-11-26 15:57 ` Kalle Valo [this message]
2021-11-26 16:23 ` Lorenzo Bianconi
2021-11-27 14:27 ` Lorenzo Bianconi
2021-11-29 8:52 ` Kalle Valo
2021-11-29 13:32 ` lorenzo bianconi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sfvij4eh.fsf@codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=lorenzo.bianconi@redhat.com \
--cc=lorenzo@kernel.org \
--cc=nbd@nbd.name \
--cc=ryder.lee@mediatek.com \
--cc=sean.wang@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).