linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] cfg80211: lower dynamic PS timeout to 100ms
@ 2009-07-31  9:18 Johannes Berg
  2009-07-31  9:20 ` Kalle Valo
  0 siblings, 1 reply; 2+ messages in thread
From: Johannes Berg @ 2009-07-31  9:18 UTC (permalink / raw)
  To: John Linville; +Cc: Kalle Valo, linux-wireless

The default of 500ms is pretty high, and leads
to the device being awake at least 50% of the
time under such light traffic conditions as a
simple 1 second interval ping. Reduce to just
100ms -- it should have a similar effect while
providing a better sleep time.

Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
---
 net/wireless/core.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- wireless-testing.orig/net/wireless/core.c	2009-07-31 11:15:32.000000000 +0200
+++ wireless-testing/net/wireless/core.c	2009-07-31 11:15:40.000000000 +0200
@@ -673,7 +673,7 @@ static int cfg80211_netdev_notifier_call
 		wdev->wext.default_mgmt_key = -1;
 		wdev->wext.connect.auth_type = NL80211_AUTHTYPE_AUTOMATIC;
 		wdev->wext.ps = CONFIG_CFG80211_DEFAULT_PS_VALUE;
-		wdev->wext.ps_timeout = 500;
+		wdev->wext.ps_timeout = 100;
 		if (rdev->ops->set_power_mgmt)
 			if (rdev->ops->set_power_mgmt(wdev->wiphy, dev,
 						      wdev->wext.ps,



^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] cfg80211: lower dynamic PS timeout to 100ms
  2009-07-31  9:18 [PATCH] cfg80211: lower dynamic PS timeout to 100ms Johannes Berg
@ 2009-07-31  9:20 ` Kalle Valo
  0 siblings, 0 replies; 2+ messages in thread
From: Kalle Valo @ 2009-07-31  9:20 UTC (permalink / raw)
  To: Johannes Berg; +Cc: John Linville, linux-wireless

Johannes Berg <johannes@sipsolutions.net> writes:

> The default of 500ms is pretty high, and leads
> to the device being awake at least 50% of the
> time under such light traffic conditions as a
> simple 1 second interval ping. Reduce to just
> 100ms -- it should have a similar effect while
> providing a better sleep time.
>
> Signed-off-by: Johannes Berg <johannes@sipsolutions.net>

I agree, 500 ms is too long.

Reviewed-by: Kalle Valo <kalle.valo@iki.fi>

-- 
Kalle Valo

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2009-07-31  9:27 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-07-31  9:18 [PATCH] cfg80211: lower dynamic PS timeout to 100ms Johannes Berg
2009-07-31  9:20 ` Kalle Valo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).