linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@kernel.org>
To: Jakub Kicinski <kuba@kernel.org>
Cc: netdev@vger.kernel.org,  linux-wireless@vger.kernel.org,
	 Ching-Te Ku <ku920601@realtek.com>,
	 Ping-Ke Shih <pkshih@realtek.com>
Subject: Re: pull-request: wireless-next-2024-03-08
Date: Fri, 08 Mar 2024 18:50:11 +0200	[thread overview]
Message-ID: <87wmqc4qik.fsf@kernel.org> (raw)
In-Reply-To: <20240308074539.04512f66@kernel.org> (Jakub Kicinski's message of "Fri, 8 Mar 2024 07:45:39 -0800")

Jakub Kicinski <kuba@kernel.org> writes:

> On Fri,  8 Mar 2024 10:04:29 +0000 (UTC) Kalle Valo wrote:
>> here's a pull request to net-next tree, more info below. Please let me know if
>> there are any problems.
>
> coccicheck flags:
>
> drivers/net/wireless/realtek/rtw89/rtw8922a.c:2235:2-4: WARNING: possible condition with no effect (if == else)

Thanks, but how did you find this? I'm asking just to understand your process, at
least the pull request shows all green:

https://patchwork.kernel.org/project/netdevbpf/patch/20240308100429.B8EA2C433F1@smtp.kernel.org/

We don't run coccicheck so it's not surprising there are new warnings.

> for a non-urgent follow up. Doesn't look like an obvious false positive.

Ping, could you fix this, please? In the patch please add Closes tag
pointing to Jakub's email and mark it for wireless tree (assuming the
merge window starts on Sunday, otherwise we take it to wireless-next).

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

  reply	other threads:[~2024-03-08 16:50 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-08 10:04 pull-request: wireless-next-2024-03-08 Kalle Valo
2024-03-08 15:45 ` Jakub Kicinski
2024-03-08 16:50   ` Kalle Valo [this message]
2024-03-08 16:58     ` Jakub Kicinski
2024-03-09  0:19     ` Ping-Ke Shih
2024-03-08 17:50 ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wmqc4qik.fsf@kernel.org \
    --to=kvalo@kernel.org \
    --cc=ku920601@realtek.com \
    --cc=kuba@kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pkshih@realtek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).