From: Johannes Berg <johannes@sipsolutions.net>
To: Shay Bar <Shay.Bar@celeno.com>, Ben Greear <greearb@candelatech.com>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] mac80211: Send deauth to STA's upon AP stop
Date: Thu, 30 Jul 2020 16:28:12 +0200 [thread overview]
Message-ID: <903ec27f7423574f644312c701ed45fdafdb7ca6.camel@sipsolutions.net> (raw)
In-Reply-To: <AM0P192MB0468715C6F76AFD51938CC55E7710@AM0P192MB0468.EURP192.PROD.OUTLOOK.COM>
On Thu, 2020-07-30 at 14:23 +0000, Shay Bar wrote:
> On 30/07/2020 17:00, Johannes Berg wrote:
> > External Email
> >
> >
> > On Thu, 2020-06-25 at 13:29 +0300, Shay Bar wrote:
> > > On 25/06/2020 12:51, Johannes Berg wrote:
> > > > External Email
> > > >
> > > >
> > > > On Sun, 2020-06-21 at 10:12 +0000, Shay Bar wrote:
> > > > > Hi Johannes and Ben,
> > > > >
> > > > > To conclude this thread, hostapd doesn’t send any deauth/disassoc
> > > > > upon AP stop (when hostapd is killed _or_ when "ifconfig down" the
> > > > > AP interface).
> > > > Right. I'm sort of suggesting you just shouldn't be doing this, and it
> > > > doesn't seem like most people actually do, otherwise we'd have seen this
> > > > issue before?
> > > >
> > > I shouldn't kill hostapd? Isn't this a very basic action?
> > > What is the alternative for stopping the AP?
> > I guess I would say to use hostapd_cli first to "disable" the
> > interfaces?
>
> Indeed, using hostapd_cli "DISABLE" will call
> hostapd_flush_old_stations() that will send broadcast deauth.
Ah.
> The problem is (mentioned before) that some stations (e.g. Samsung S8)
> ignore this broadcast (while it will not ignore unicast
> deauth/disassoc).
Right, you mentioned that. I guess you could work around by disabling
all stations separately, but ... not really a great solution either.
Perhaps we should fix that at the hostapd level?
Not really sure how much trouble we should go to for bad stations
though. I mean, it's not like they should be ignoring that.
Maybe they just miss it due to super aggressive powersave, and we should
send it a few times?
johannes
next prev parent reply other threads:[~2020-07-30 14:28 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-18 9:36 [PATCH] mac80211: Send deauth to STA's upon AP stop Shay Bar
2020-06-18 13:47 ` Ben Greear
2020-06-18 13:48 ` Johannes Berg
2020-06-18 14:14 ` Shay Bar
2020-06-18 14:18 ` Johannes Berg
2020-06-18 14:36 ` Shay Bar
2020-06-18 14:38 ` Johannes Berg
2020-06-18 14:45 ` Shay Bar
2020-06-18 14:48 ` Johannes Berg
2020-06-18 15:11 ` Shay Bar
2020-06-18 15:26 ` Ben Greear
2020-06-21 10:12 ` Shay Bar
2020-06-25 9:51 ` Johannes Berg
2020-06-25 10:29 ` Shay Bar
2020-07-30 14:00 ` Johannes Berg
2020-07-30 14:23 ` Shay Bar
2020-07-30 14:28 ` Johannes Berg [this message]
2020-07-30 14:45 ` Shay Bar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=903ec27f7423574f644312c701ed45fdafdb7ca6.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=Shay.Bar@celeno.com \
--cc=greearb@candelatech.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).