From: Alan Jenkins <sourcejedi.lkml@googlemail.com>
To: Mario Limonciello <mario_limonciello@dell.com>
Cc: Johannes Berg <johannes@sipsolutions.net>,
cezary.jackiewicz@gmail.com, linux-kernel@vger.kernel.org,
linux-acpi@vger.kernel.org, linux-wireless@vger.kernel.org
Subject: Re: [PATCH 2/3] Add rfkill support to compal-laptop
Date: Thu, 20 Aug 2009 09:52:44 +0100 [thread overview]
Message-ID: <9b2b86520908200152m28daa816ib8c54a423e63ca1a@mail.gmail.com> (raw)
In-Reply-To: <4A8C48BA.1000009@dell.com>
On 8/19/09, Mario Limonciello <mario_limonciello@dell.com> wrote:
> Johannes:
>
> Johannes Berg wrote:
>> On Wed, 2009-08-19 at 13:36 -0500, Mario Limonciello wrote:
>>
>>
>>
>>
>> Isn't that missing sysfs_remove_group()?
>>
>> johannes
>>
> The third patch in the (updated) series is dropping the sysfs bits, so
> sysfs_remove_group is removed there.
That's not ideal. Each patch should stand on its own; it's bad form
to introduce a bug in one patch and fix it in the next one. Even
something obscure like omitting to free the sysfs group when
setup_rfkill() fails.
I would suggest merging these two patches into one. That would avoid
adding sysfs_remove_group() in this patch, just to remove it in the
next one. It also avoids the question in this patch, of what happens
to the rfkill interface if you write to the sysfs file.
Alan
next prev parent reply other threads:[~2009-08-20 8:52 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-19 18:36 [PATCH 2/3] Add rfkill support to compal-laptop Mario Limonciello
2009-08-19 18:42 ` Johannes Berg
2009-08-19 18:47 ` Mario Limonciello
2009-08-20 8:52 ` Alan Jenkins [this message]
2009-08-21 21:39 ` [PATCH] compal-laptop: Replace sysfs support with rfkill support Mario Limonciello
2009-08-22 11:20 ` Alan Jenkins
2009-08-24 19:50 ` Mario Limonciello
2009-08-25 8:15 ` Alan Jenkins
[not found] <4A89E768.7010207@dell.com>
[not found] ` <1250558643.30166.109.camel@localhost.localdomain>
[not found] ` <9b2b86520908180044l72cb8642j6256e246662f7971@mail.gmail.com>
[not found] ` <9b2b86520908180752k66feda09rf9034a96ac6ef470@mail.gmail.com>
[not found] ` <4A8AE459.8060102@dell.com>
2009-08-18 21:08 ` [PATCH 2/3] Add rfkill support to compal-laptop Alan Jenkins
2009-08-18 21:31 ` Johannes Berg
2009-08-18 22:00 ` Mario Limonciello
2009-08-19 8:51 ` Alan Jenkins
2009-08-19 9:01 ` Johannes Berg
2009-08-19 11:43 ` Cezary Jackiewicz
2009-08-19 16:46 ` Mario Limonciello
2009-08-19 16:57 ` Alan Jenkins
2009-08-19 17:13 ` Johannes Berg
2009-08-19 18:39 ` Mario Limonciello
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9b2b86520908200152m28daa816ib8c54a423e63ca1a@mail.gmail.com \
--to=sourcejedi.lkml@googlemail.com \
--cc=cezary.jackiewicz@gmail.com \
--cc=johannes@sipsolutions.net \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=mario_limonciello@dell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).