Re: [PATCH] brcm: provide new firmwares for BCM4366 chipset

Re: [PATCH] brcm: provide new firmwares for BCM4366 chipset

[Josh Boyer]

On Wed, Nov 7, 2018 at 3:45 PM Arend van Spriel
<arend.vanspriel@broadcom.com> wrote:
>
> These firmwares are for the BCM4366 3x3 802.11 ac chipsets, which also comprise of BCM4366E or BCM43664 devices. Signed-off-by: Arend van Spriel

This didn't add brcm/brcmfmac4366c-pcie.bin to WHENCE.  I'm assuming
it's under the same license as the rest of the brcmfmac files?  If so,
I can just amend the patch.

josh

Re: [PATCH] brcm: provide new firmwares for BCM4366 chipset

[Arend Van Spriel]

On 12/14/2018 2:02 PM, Josh Boyer wrote:
> On Wed, Nov 7, 2018 at 3:45 PM Arend van Spriel
> <arend.vanspriel@broadcom.com> wrote:
>>
>> These firmwares are for the BCM4366 3x3 802.11 ac chipsets, which also comprise of BCM4366E or BCM43664 devices. Signed-off-by: Arend van Spriel
> 
> This didn't add brcm/brcmfmac4366c-pcie.bin to WHENCE.  I'm assuming
> it's under the same license as the rest of the brcmfmac files?  If so,
> I can just amend the patch.

Hi Josh,

I was not sure this patch ever made it through. It did not appear on 
linux-wireless list probably due to exceeding a size limit. So I resend 
it as two patches on December 10th. However, I indeed forgot to update 
the WHENCE file in that series as well. Indeed there is no license change.

Regards,
Arend

Re: [PATCH] brcm: provide new firmwares for BCM4366 chipset

[Josh Boyer]

On Sat, Dec 15, 2018 at 6:02 AM Arend Van Spriel
<arend.vanspriel@broadcom.com> wrote:
>
>
>
> On 12/14/2018 2:02 PM, Josh Boyer wrote:
> > On Wed, Nov 7, 2018 at 3:45 PM Arend van Spriel
> > <arend.vanspriel@broadcom.com> wrote:
> >>
> >> These firmwares are for the BCM4366 3x3 802.11 ac chipsets, which also comprise of BCM4366E or BCM43664 devices. Signed-off-by: Arend van Spriel
> >
> > This didn't add brcm/brcmfmac4366c-pcie.bin to WHENCE.  I'm assuming
> > it's under the same license as the rest of the brcmfmac files?  If so,
> > I can just amend the patch.
>
> Hi Josh,
>
> I was not sure this patch ever made it through. It did not appear on
> linux-wireless list probably due to exceeding a size limit. So I resend
> it as two patches on December 10th. However, I indeed forgot to update
> the WHENCE file in that series as well. Indeed there is no license change.

OK.  Amended and pushed out.

josh

Re: [PATCH] brcm: provide new firmwares for BCM4366 chipset

[Rafał Miłecki]

On Sat, 15 Dec 2018 at 12:03, Arend Van Spriel
<arend.vanspriel@broadcom.com> wrote:
> On 12/14/2018 2:02 PM, Josh Boyer wrote:
> > On Wed, Nov 7, 2018 at 3:45 PM Arend van Spriel
> > <arend.vanspriel@broadcom.com> wrote:
> >>
> >> These firmwares are for the BCM4366 3x3 802.11 ac chipsets, which also comprise of BCM4366E or BCM43664 devices. Signed-off-by: Arend van Spriel
> >
> > This didn't add brcm/brcmfmac4366c-pcie.bin to WHENCE.  I'm assuming
> > it's under the same license as the rest of the brcmfmac files?  If so,
> > I can just amend the patch.
>
> Hi Josh,
>
> I was not sure this patch ever made it through. It did not appear on
> linux-wireless list probably due to exceeding a size limit. So I resend
> it as two patches on December 10th. However, I indeed forgot to update
> the WHENCE file in that series as well. Indeed there is no license change.

Unfortunately I have only 1 device with 4366B1 (D-Link DIR-885L) and
it seems to have dummy NVRAM restored from the bootloader's copy:
1:ccode=ALL
0:regrev=0
0:ccode=ALL
1:regrev=0

1) Old fw 10.10.69.3309 (r610991) FWID 01-c47a91a4
2 GHz: very weak signal (about -79 dBm)
5 GHz: good signal & works stable
(this also matches vendor firmware behavior)

2) New fw 10.28.2 (r769115) FWID 01-801fb449
2 GHz: very weak signal (about -79 dBm)
5 GHz: good signal but huge packet loss

So the new firmware introduces 5 GHz regression for me, but I guess I
should not complain since my device seems to come with a missing NVRAM
regulatory info.

Is there any chance you know a correct ccode + regrev for D-Link
DIR-885L for any region?

-- 
Rafał

Re: [PATCH] brcm: provide new firmwares for BCM4366 chipset

[Arend Van Spriel]

On 12/17/2018 11:34 AM, Rafał Miłecki wrote:
> On Sat, 15 Dec 2018 at 12:03, Arend Van Spriel
> <arend.vanspriel@broadcom.com> wrote:
>> On 12/14/2018 2:02 PM, Josh Boyer wrote:
>>> On Wed, Nov 7, 2018 at 3:45 PM Arend van Spriel
>>> <arend.vanspriel@broadcom.com> wrote:
>>>>
>>>> These firmwares are for the BCM4366 3x3 802.11 ac chipsets, which also comprise of BCM4366E or BCM43664 devices. Signed-off-by: Arend van Spriel
>>>
>>> This didn't add brcm/brcmfmac4366c-pcie.bin to WHENCE.  I'm assuming
>>> it's under the same license as the rest of the brcmfmac files?  If so,
>>> I can just amend the patch.
>>
>> Hi Josh,
>>
>> I was not sure this patch ever made it through. It did not appear on
>> linux-wireless list probably due to exceeding a size limit. So I resend
>> it as two patches on December 10th. However, I indeed forgot to update
>> the WHENCE file in that series as well. Indeed there is no license change.
> 
> Unfortunately I have only 1 device with 4366B1 (D-Link DIR-885L) and
> it seems to have dummy NVRAM restored from the bootloader's copy:
> 1:ccode=ALL
> 0:regrev=0
> 0:ccode=ALL
> 1:regrev=0
> 
> 1) Old fw 10.10.69.3309 (r610991) FWID 01-c47a91a4
> 2 GHz: very weak signal (about -79 dBm)
> 5 GHz: good signal & works stable
> (this also matches vendor firmware behavior)
> 
> 2) New fw 10.28.2 (r769115) FWID 01-801fb449
> 2 GHz: very weak signal (about -79 dBm)
> 5 GHz: good signal but huge packet loss
> 
> So the new firmware introduces 5 GHz regression for me, but I guess I
> should not complain since my device seems to come with a missing NVRAM
> regulatory info.
> 
> Is there any chance you know a correct ccode + regrev for D-Link
> DIR-885L for any region?

Hi Rafał,

That is bad news. Is the packet loss in receive or transmit direction? 
How do you obtain the info?

Regards,
Arend