From: Brian Norris <briannorris@chromium.org>
To: Ben Greear <greearb@candelatech.com>
Cc: Youghandhar Chintala <youghand@codeaurora.org>,
Johannes Berg <johannes@sipsolutions.net>,
ath10k <ath10k@lists.infradead.org>,
Kalle Valo <kvalo@codeaurora.org>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
linux-wireless <linux-wireless@vger.kernel.org>,
"<netdev@vger.kernel.org>" <netdev@vger.kernel.org>,
Linux Kernel <linux-kernel@vger.kernel.org>,
kuabhs@chromium.org, Doug Anderson <dianders@chromium.org>,
Rakesh Pillai <pillair@codeaurora.org>
Subject: Re: [PATCH 0/3] mac80211: Trigger disconnect for STA during recovery
Date: Thu, 17 Dec 2020 15:18:04 -0800 [thread overview]
Message-ID: <CA+ASDXP+b8bik767LxcN9jV+ETpJ+_4HKH7rvsGgXbAHidFAng@mail.gmail.com> (raw)
In-Reply-To: <6cec8a4c-620f-093d-2739-7eafe89cd79a@candelatech.com>
On Thu, Dec 17, 2020 at 2:57 PM Ben Greear <greearb@candelatech.com> wrote:
> On 12/17/20 2:24 PM, Brian Norris wrote:
> > I'd also note that we don't operate in AP mode -- only STA -- and IIRC
> > Ben, you've complained about AP mode in the past.
>
> I complain about all sorts of things, but I'm usually running
> station mode :)
Hehe, fair :) Maybe I'm mixed up.
But I do get the feeling that specifically within the ath10k family,
there are wildly different use cases (mobile, PC, AP) and chips (and
firmware) that tend to go along with them, and that those use cases
get a fairly different population of {developers, testers, reporters}.
So claiming "feature X works" pretty much always has to be couched in
which chips, firmware, and use case. And there's certainly some wisdom
in these sections:
https://wireless.wiki.kernel.org/en/users/drivers/ath10k/submittingpatches#hardware_families
https://wireless.wiki.kernel.org/en/users/drivers/ath10k/submittingpatches#tested-on_tag
> Do you actually see iwlwifi stations stay associated through
> firmware crashes?
Yes.
> Anyway, happy to hear some have seamless recovery, and in that case,
> I have no objections to the patch.
OK! I hope I'm not the only one with such results, because then I
still might question my sanity (and test coverage), but that's still
my understanding.
BTW, I haven't yet closely reviewed the patch series myself, but I ACK
the concept.
Brian
next prev parent reply other threads:[~2020-12-17 23:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-15 17:21 [PATCH 0/3] mac80211: Trigger disconnect for STA during recovery Youghandhar Chintala
2020-12-15 18:23 ` Ben Greear
2020-12-16 11:35 ` Rakesh Pillai
2020-12-17 22:24 ` Brian Norris
2020-12-17 22:57 ` Ben Greear
2020-12-17 23:18 ` Brian Norris [this message]
2020-12-17 22:30 ` Brian Norris
2020-12-15 17:30 Youghandhar Chintala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA+ASDXP+b8bik767LxcN9jV+ETpJ+_4HKH7rvsGgXbAHidFAng@mail.gmail.com \
--to=briannorris@chromium.org \
--cc=ath10k@lists.infradead.org \
--cc=davem@davemloft.net \
--cc=dianders@chromium.org \
--cc=greearb@candelatech.com \
--cc=johannes@sipsolutions.net \
--cc=kuabhs@chromium.org \
--cc=kuba@kernel.org \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pillair@codeaurora.org \
--cc=youghand@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).