wl18xx: wlconf kernel compatibility

wl18xx: wlconf kernel compatibility

[Yegor Yefremov]

How do I know, which wlconf version is compatible with which kernel
version? I have following problem:

I have *.INI file for my particular WLAN chip. This file will be used
to produce wl18xx-conf.bin. The size of this file will be check during
device initialization. Depending on which kernel version is used the
size of the required file differs. For example kernel 3.18 requires
wl18xx-conf.bin to have 1221 bytes, 4.1 expects 1226 bytes. Recent
wlconf (git://git.ti.com/wilink8-wlan/18xx-ti-utils.git) produces 1229
bytes files.

How should I determine correct wlconf version?

Regards,
Yegor

Re: wl18xx: wlconf kernel compatibility

[Kalle Valo]

Yegor Yefremov <yegorslists@googlemail.com> writes:

> How do I know, which wlconf version is compatible with which kernel
> version? I have following problem:
>
> I have *.INI file for my particular WLAN chip. This file will be used
> to produce wl18xx-conf.bin. The size of this file will be check during
> device initialization. Depending on which kernel version is used the
> size of the required file differs. For example kernel 3.18 requires
> wl18xx-conf.bin to have 1221 bytes, 4.1 expects 1226 bytes. Recent
> wlconf (git://git.ti.com/wilink8-wlan/18xx-ti-utils.git) produces 1229
> bytes files.
>
> How should I determine correct wlconf version?

I also complained about something along these lines earlier, this is not
how upstream drivers are supposed to work. Users should not be forced to
find correct files from somewhere, instead everything should just work
out of box.

Can anyone help Yegor to solve his problem? But in the long run wl18xx
really should manage this better.

-- 
Kalle Valo

Re: wl18xx: wlconf kernel compatibility

[Yegor Yefremov]

Hi Kalle,

On Sat, Jun 6, 2015 at 3:27 PM, Kalle Valo <kvalo@codeaurora.org> wrote:
> Yegor Yefremov <yegorslists@googlemail.com> writes:
>
>> How do I know, which wlconf version is compatible with which kernel
>> version? I have following problem:
>>
>> I have *.INI file for my particular WLAN chip. This file will be used
>> to produce wl18xx-conf.bin. The size of this file will be check during
>> device initialization. Depending on which kernel version is used the
>> size of the required file differs. For example kernel 3.18 requires
>> wl18xx-conf.bin to have 1221 bytes, 4.1 expects 1226 bytes. Recent
>> wlconf (git://git.ti.com/wilink8-wlan/18xx-ti-utils.git) produces 1229
>> bytes files.
>>
>> How should I determine correct wlconf version?
>
> I also complained about something along these lines earlier, this is not
> how upstream drivers are supposed to work. Users should not be forced to
> find correct files from somewhere, instead everything should just work
> out of box.
>
> Can anyone help Yegor to solve his problem? But in the long run wl18xx
> really should manage this better.

I could solve the problem, though for the future it should be clear,
what wlconf version to use.

See my post here:
http://e2e.ti.com/support/wireless_connectivity/f/307/p/426229/1523235#1523235

Yegor

RE: wl18xx: wlconf kernel compatibility

[Machani, Yaniv]

SGksDQpBcyB0aGUgY29uZmlndXJhdGlvbiBmaWxlIGlzIEhXIGRlcGVuZGVkIGl0IHNob3VsZCBi
ZSBjcmVhdGVkIHBlciBwbGF0Zm9ybSwNCndlIGhhdmUgc2V0IHRoaXMgd2lraSBwYWdlIGFuZCBz
Y3JpcHQgdG8gaGVscCB3aXRoIGluaXRpYWwgc2V0dXAgOg0KaHR0cDovL3Byb2Nlc3NvcnMud2lr
aS50aS5jb20vaW5kZXgucGhwL09wZW5fU291cmNlX1dpcmVsZXNzX0Nvbm5lY3Rpdml0eV93bGNv
bmYNCg0KV2UgaGF2ZSBhbHNvIHB1c2hlZCBhIHBhdGNoIHRoYXQgbWFrZXMgc3VyZSB0aGUgZHJp
dmVyIHdpbGwgbm90IGNyYXNoIGlmIHRoZXJlIGlzIGEgZmlsZSBzaXplIG1pc21hdGNoLCANCmFu
ZCB3aWxsIGZhbGwgYmFjayB0byBkZWZhdWx0Lg0KDQpSZWdhcmRzLA0KWWFuaXYNCg0KPiAtLS0t
LU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiBGcm9tOiBZZWdvciBZZWZyZW1vdiBbbWFpbHRvOnll
Z29yc2xpc3RzQGdvb2dsZW1haWwuY29tXQ0KPiBTZW50OiBTYXR1cmRheSwgSnVuZSAwNiwgMjAx
NSA2OjE5IFBNDQo+IFRvOiBLYWxsZSBWYWxvDQo+IENjOiBsaW51eC13aXJlbGVzc0B2Z2VyLmtl
cm5lbC5vcmc7IE1hY2hhbmksIFlhbml2OyBFbGlhZCBQZWxsZXI7IE1hcmMgS2xlaW5lLQ0KPiBC
dWRkZQ0KPiBTdWJqZWN0OiBSZTogd2wxOHh4OiB3bGNvbmYga2VybmVsIGNvbXBhdGliaWxpdHkN
Cj4gDQo+IEhpIEthbGxlLA0KPiANCj4gT24gU2F0LCBKdW4gNiwgMjAxNSBhdCAzOjI3IFBNLCBL
YWxsZSBWYWxvIDxrdmFsb0Bjb2RlYXVyb3JhLm9yZz4gd3JvdGU6DQo+ID4gWWVnb3IgWWVmcmVt
b3YgPHllZ29yc2xpc3RzQGdvb2dsZW1haWwuY29tPiB3cml0ZXM6DQo+ID4NCj4gPj4gSG93IGRv
IEkga25vdywgd2hpY2ggd2xjb25mIHZlcnNpb24gaXMgY29tcGF0aWJsZSB3aXRoIHdoaWNoIGtl
cm5lbA0KPiA+PiB2ZXJzaW9uPyBJIGhhdmUgZm9sbG93aW5nIHByb2JsZW06DQo+ID4+DQo+ID4+
IEkgaGF2ZSAqLklOSSBmaWxlIGZvciBteSBwYXJ0aWN1bGFyIFdMQU4gY2hpcC4gVGhpcyBmaWxl
IHdpbGwgYmUgdXNlZA0KPiA+PiB0byBwcm9kdWNlIHdsMTh4eC1jb25mLmJpbi4gVGhlIHNpemUg
b2YgdGhpcyBmaWxlIHdpbGwgYmUgY2hlY2sNCj4gPj4gZHVyaW5nIGRldmljZSBpbml0aWFsaXph
dGlvbi4gRGVwZW5kaW5nIG9uIHdoaWNoIGtlcm5lbCB2ZXJzaW9uIGlzDQo+ID4+IHVzZWQgdGhl
IHNpemUgb2YgdGhlIHJlcXVpcmVkIGZpbGUgZGlmZmVycy4gRm9yIGV4YW1wbGUga2VybmVsIDMu
MTgNCj4gPj4gcmVxdWlyZXMgd2wxOHh4LWNvbmYuYmluIHRvIGhhdmUgMTIyMSBieXRlcywgNC4x
IGV4cGVjdHMgMTIyNiBieXRlcy4NCj4gPj4gUmVjZW50IHdsY29uZiAoZ2l0Oi8vZ2l0LnRpLmNv
bS93aWxpbms4LXdsYW4vMTh4eC10aS11dGlscy5naXQpDQo+ID4+IHByb2R1Y2VzIDEyMjkgYnl0
ZXMgZmlsZXMuDQo+ID4+DQo+ID4+IEhvdyBzaG91bGQgSSBkZXRlcm1pbmUgY29ycmVjdCB3bGNv
bmYgdmVyc2lvbj8NCj4gPg0KPiA+IEkgYWxzbyBjb21wbGFpbmVkIGFib3V0IHNvbWV0aGluZyBh
bG9uZyB0aGVzZSBsaW5lcyBlYXJsaWVyLCB0aGlzIGlzDQo+ID4gbm90IGhvdyB1cHN0cmVhbSBk
cml2ZXJzIGFyZSBzdXBwb3NlZCB0byB3b3JrLiBVc2VycyBzaG91bGQgbm90IGJlDQo+ID4gZm9y
Y2VkIHRvIGZpbmQgY29ycmVjdCBmaWxlcyBmcm9tIHNvbWV3aGVyZSwgaW5zdGVhZCBldmVyeXRo
aW5nIHNob3VsZA0KPiA+IGp1c3Qgd29yayBvdXQgb2YgYm94Lg0KPiA+DQo+ID4gQ2FuIGFueW9u
ZSBoZWxwIFllZ29yIHRvIHNvbHZlIGhpcyBwcm9ibGVtPyBCdXQgaW4gdGhlIGxvbmcgcnVuIHds
MTh4eA0KPiA+IHJlYWxseSBzaG91bGQgbWFuYWdlIHRoaXMgYmV0dGVyLg0KPiANCj4gSSBjb3Vs
ZCBzb2x2ZSB0aGUgcHJvYmxlbSwgdGhvdWdoIGZvciB0aGUgZnV0dXJlIGl0IHNob3VsZCBiZSBj
bGVhciwgd2hhdCB3bGNvbmYNCj4gdmVyc2lvbiB0byB1c2UuDQo+IA0KPiBTZWUgbXkgcG9zdCBo
ZXJlOg0KPiBodHRwOi8vZTJlLnRpLmNvbS9zdXBwb3J0L3dpcmVsZXNzX2Nvbm5lY3Rpdml0eS9m
LzMwNy9wLzQyNjIyOS8xNTIzMjM1IzE1Mg0KPiAzMjM1DQo+IA0KPiBZZWdvcg0K

Re: wl18xx: wlconf kernel compatibility

[Yegor Yefremov]

Hi Yaniv,

On Sun, Jun 7, 2015 at 9:30 AM, Machani, Yaniv <yanivma@ti.com> wrote:
> Hi,
> As the configuration file is HW depended it should be created per platform,
> we have set this wiki page and script to help with initial setup :
> http://processors.wiki.ti.com/index.php/Open_Source_Wireless_Connectivity_wlconf
>
> We have also pushed a patch that makes sure the driver will not crash if there is a file size mismatch,
> and will fall back to default.

What about following proposal. I'm learning libxmlrpc now. It has
following struct *xmlrpc_server_abyss_parms*
(http://xmlrpc-c.sourceforge.net/doc/libxmlrpc_server_abyss.html#server_abyss_parameters).
If new parameter will be added, it is done via appending this to the
bottom of the structure. This way old structure is still preserved.

The user of this library must specify till what parameter this
structure should be used (parmSize parameter):

oid
xmlrpc_server_abyss(xmlrpc_env *                const envP,
                    xmlrpc_server_abyss_parms * const parmP,
                    unsigned int const parmSize);

This will be achieved via XMLRPC_APSIZE(log_file_name), i.e. macro
with structure field name. This way old programs still can work with
newer library.

This approach could be taken for wl18xx-conf.bin. Driver calculates
the size of known parameters and conf file size and as long as the
size of wl18xx-conf.bin is not smaller than known size, the driver can
use it.

What do you think about it?

Yegor

>> -----Original Message-----
>> From: Yegor Yefremov [mailto:yegorslists@googlemail.com]
>> Sent: Saturday, June 06, 2015 6:19 PM
>> To: Kalle Valo
>> Cc: linux-wireless@vger.kernel.org; Machani, Yaniv; Eliad Peller; Marc Kleine-
>> Budde
>> Subject: Re: wl18xx: wlconf kernel compatibility
>>
>> Hi Kalle,
>>
>> On Sat, Jun 6, 2015 at 3:27 PM, Kalle Valo <kvalo@codeaurora.org> wrote:
>> > Yegor Yefremov <yegorslists@googlemail.com> writes:
>> >
>> >> How do I know, which wlconf version is compatible with which kernel
>> >> version? I have following problem:
>> >>
>> >> I have *.INI file for my particular WLAN chip. This file will be used
>> >> to produce wl18xx-conf.bin. The size of this file will be check
>> >> during device initialization. Depending on which kernel version is
>> >> used the size of the required file differs. For example kernel 3.18
>> >> requires wl18xx-conf.bin to have 1221 bytes, 4.1 expects 1226 bytes.
>> >> Recent wlconf (git://git.ti.com/wilink8-wlan/18xx-ti-utils.git)
>> >> produces 1229 bytes files.
>> >>
>> >> How should I determine correct wlconf version?
>> >
>> > I also complained about something along these lines earlier, this is
>> > not how upstream drivers are supposed to work. Users should not be
>> > forced to find correct files from somewhere, instead everything should
>> > just work out of box.
>> >
>> > Can anyone help Yegor to solve his problem? But in the long run wl18xx
>> > really should manage this better.
>>
>> I could solve the problem, though for the future it should be clear, what wlconf
>> version to use.
>>
>> See my post here:
>> http://e2e.ti.com/support/wireless_connectivity/f/307/p/426229/1523235#152
>> 3235
>>
>> Yegor