* TI wlcore wifi not loading w/ v5.3-rc1
@ 2019-07-22 22:20 John Stultz
2019-07-23 5:11 ` Johannes Berg
0 siblings, 1 reply; 3+ messages in thread
From: John Stultz @ 2019-07-22 22:20 UTC (permalink / raw)
To: Kalle Valo, Tony Lindgren, Johannes Berg; +Cc: linux-wireless
Hey folks,
Testing on my HiKey960, I'm seeing:
[ 8.894909] wlcore: wl18xx HW: 183x or 180x, PG 2.2 (ROM 0x11)
[ 8.902017] ------------[ cut here ]------------
[ 8.906832] WARNING: CPU: 0 PID: 5 at net/wireless/core.c:868
wiphy_register+0x8b4/0xc08
[ 8.914932] Modules linked in:
[ 8.917999] CPU: 0 PID: 5 Comm: kworker/0:0 Tainted: G S
5.3.0-rc1-00095-g1ddb90492e79 #504
[ 8.927657] Hardware name: HiKey960 (DT)
[ 8.931590] Workqueue: events request_firmware_work_func
[ 8.936904] pstate: 60400005 (nZCv daif +PAN -UAO)
[ 8.941704] pc : wiphy_register+0x8b4/0xc08
[ 8.945891] lr : wiphy_register+0x8b4/0xc08
[ 8.950076] sp : ffffff801006bbf0
[ 8.953390] x29: ffffff801006bbf0 x28: 0000000000000000
[ 8.958704] x27: 000000000000002d x26: 0000000000000001
[ 8.964019] x25: 000000000000002f x24: 0000000000000000
[ 8.969334] x23: ffffffc217505d98 x22: ffffffc217503f00
[ 8.974650] x21: ffffff80117c9000 x20: 00000000000007dc
[ 8.979963] x19: ffffffc217504300 x18: ffffffffffffffff
[ 8.985276] x17: 0000000000000000 x16: 0000000000000000
[ 8.990592] x15: ffffff80117c9a88 x14: ffffff809006b957
[ 8.995908] x13: ffffff801006b965 x12: ffffff80117f0000
[ 9.001223] x11: 0000000005f5e0ff x10: ffffff801006b8f0
[ 9.006537] x9 : ffffff80117c9ac0 x8 : ffffff801054b798
[ 9.011852] x7 : 00000000000002ad x6 : 0000000000000028
[ 9.017168] x5 : ffffff8011d72dd8 x4 : 0000000000000000
[ 9.022482] x3 : 0000000000000000 x2 : 1814804b8988b000
[ 9.027800] x1 : 0000000000000000 x0 : 0000000000000024
[ 9.033113] Call trace:
[ 9.035559] wiphy_register+0x8b4/0xc08
[ 9.039396] ieee80211_register_hw+0x43c/0xb88
[ 9.043846] wlcore_nvs_cb+0x8c8/0xae0
[ 9.047603] request_firmware_work_func+0x48/0x88
[ 9.052310] process_one_work+0x1f0/0x430
[ 9.056321] worker_thread+0x48/0x4b0
[ 9.059987] kthread+0x128/0x130
[ 9.063219] ret_from_fork+0x10/0x1c
[ 9.066792] ---[ end trace bfe1c71ef18337b1 ]---
[ 9.071626] wlcore: ERROR unable to register mac80211 hw: -22
Which seems to be caused by commit 901bb9891855 ("nl80211: require and
validate vendor command policy"), and I've validated that reverting
that gets it working again.
It seems like from the commit message, the wlcore driver isn't
providing the policy values the network core expects? I'm not sure
what the right fix would be, but wanted to raise the issue.
Suggestions?
thanks
-john
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: TI wlcore wifi not loading w/ v5.3-rc1
2019-07-22 22:20 TI wlcore wifi not loading w/ v5.3-rc1 John Stultz
@ 2019-07-23 5:11 ` Johannes Berg
2019-07-23 5:24 ` John Stultz
0 siblings, 1 reply; 3+ messages in thread
From: Johannes Berg @ 2019-07-23 5:11 UTC (permalink / raw)
To: John Stultz, Kalle Valo, Tony Lindgren; +Cc: linux-wireless
On Mon, 2019-07-22 at 22:20 +0000, John Stultz wrote:
> Hey folks,
>
> Testing on my HiKey960, I'm seeing:
> [ 8.894909] wlcore: wl18xx HW: 183x or 180x, PG 2.2 (ROM 0x11)
> [ 8.902017] ------------[ cut here ]------------
> [ 8.906832] WARNING: CPU: 0 PID: 5 at net/wireless/core.c:868
> wiphy_register+0x8b4/0xc08
[...]
> It seems like from the commit message, the wlcore driver isn't
> providing the policy values the network core expects? I'm not sure
> what the right fix would be, but wanted to raise the issue.
There's a fix on the way, unfortunately I forgot to send the pull
request before the merge window. I sent it out a couple of days ago and
narrowly missed -rc1, but it'll be in rc2:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=91046d6364afde646734c7ead1f649d253c386e9
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=1667e4f9bcfb6785362a300ac4486df0854a72aa
johannes
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: TI wlcore wifi not loading w/ v5.3-rc1
2019-07-23 5:11 ` Johannes Berg
@ 2019-07-23 5:24 ` John Stultz
0 siblings, 0 replies; 3+ messages in thread
From: John Stultz @ 2019-07-23 5:24 UTC (permalink / raw)
To: Johannes Berg; +Cc: Kalle Valo, Tony Lindgren, linux-wireless
On Mon, Jul 22, 2019 at 10:11 PM Johannes Berg
<johannes@sipsolutions.net> wrote:
>
> On Mon, 2019-07-22 at 22:20 +0000, John Stultz wrote:
> > Hey folks,
> >
> > Testing on my HiKey960, I'm seeing:
> > [ 8.894909] wlcore: wl18xx HW: 183x or 180x, PG 2.2 (ROM 0x11)
> > [ 8.902017] ------------[ cut here ]------------
> > [ 8.906832] WARNING: CPU: 0 PID: 5 at net/wireless/core.c:868
> > wiphy_register+0x8b4/0xc08
> [...]
> > It seems like from the commit message, the wlcore driver isn't
> > providing the policy values the network core expects? I'm not sure
> > what the right fix would be, but wanted to raise the issue.
>
> There's a fix on the way, unfortunately I forgot to send the pull
> request before the merge window. I sent it out a couple of days ago and
> narrowly missed -rc1, but it'll be in rc2:
>
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=91046d6364afde646734c7ead1f649d253c386e9
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=1667e4f9bcfb6785362a300ac4486df0854a72aa
Ah! Thanks so much! Sorry for the noise!
-john
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-07-23 5:25 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-22 22:20 TI wlcore wifi not loading w/ v5.3-rc1 John Stultz
2019-07-23 5:11 ` Johannes Berg
2019-07-23 5:24 ` John Stultz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).