From: Loic Poulain <loic.poulain@linaro.org>
To: "Bryan O'Donoghue" <bryan.odonoghue@linaro.org>
Cc: Kalle Valo <kvalo@codeaurora.org>,
wcn36xx@lists.infradead.org, linux-wireless@vger.kernel.org,
Shawn Guo <shawn.guo@linaro.org>
Subject: Re: [PATCH 2/3] wcn36xx: Enable firmware link monitoring
Date: Sat, 31 Oct 2020 10:57:15 +0100 [thread overview]
Message-ID: <CAMZdPi8+_17YSOK3G+MX3dFb0vejeikBYarRR6EckysZD4G70A@mail.gmail.com> (raw)
In-Reply-To: <20201031022311.1677337-3-bryan.odonoghue@linaro.org>
On Sat, 31 Oct 2020 at 03:22, Bryan O'Donoghue
<bryan.odonoghue@linaro.org> wrote:
>
> This patch switches on CONNECTION_MONITOR. Once done it is up to the
> firmware to send keep alive and to monitor the link state.
>
> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
> ---
> drivers/net/wireless/ath/wcn36xx/main.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/wireless/ath/wcn36xx/main.c b/drivers/net/wireless/ath/wcn36xx/main.c
> index 706728fba72d..e924cc4acde0 100644
> --- a/drivers/net/wireless/ath/wcn36xx/main.c
> +++ b/drivers/net/wireless/ath/wcn36xx/main.c
> @@ -1246,6 +1246,7 @@ static int wcn36xx_init_ieee80211(struct wcn36xx *wcn)
> ieee80211_hw_set(wcn->hw, HAS_RATE_CONTROL);
> ieee80211_hw_set(wcn->hw, SINGLE_SCAN_ON_ALL_BANDS);
> ieee80211_hw_set(wcn->hw, REPORTS_TX_ACK_STATUS);
> + ieee80211_hw_set(wcn->hw, CONNECTION_MONITOR);
The problem could be that when connection monitor is enabled, mac80211
stop sending regular null/probe packet to the AP (as expected), but
also stop monitoring beacon miss:
https://elixir.bootlin.com/linux/v5.10-rc1/source/net/mac80211/mlme.c#L115
That's not a big problem, but that would mean that in active mode
(power_save disabled, non PS), the mac80211 will not detect if the AP
has left immediately, and in worst case, only after 30 seconds. Note
that in PS mode, beacon monitoring is well done by the firmware.
>
> wcn->hw->wiphy->interface_modes = BIT(NL80211_IFTYPE_STATION) |
> BIT(NL80211_IFTYPE_AP) |
> --
> 2.28.0
>
next prev parent reply other threads:[~2020-10-31 9:51 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-31 2:23 [PATCH 0/3] wcn36xx: Firmware link monitor/keepalive offload Bryan O'Donoghue
2020-10-31 2:23 ` [PATCH 1/3] wcn36xx: Set LINK_FAIL_TX_CNT non zero on wcn3620/wcn3660 Bryan O'Donoghue
2020-10-31 9:33 ` Loic Poulain
2020-10-31 12:48 ` Bryan O'Donoghue
2020-10-31 2:23 ` [PATCH 2/3] wcn36xx: Enable firmware link monitoring Bryan O'Donoghue
2020-10-31 9:57 ` Loic Poulain [this message]
2020-10-31 13:02 ` Bryan O'Donoghue
2020-11-02 19:15 ` Loic Poulain
2020-10-31 2:23 ` [PATCH 3/3] wcn36xx: Enable firmware offloaded keepalive Bryan O'Donoghue
2020-10-31 9:39 ` Loic Poulain
2020-10-31 12:54 ` Bryan O'Donoghue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMZdPi8+_17YSOK3G+MX3dFb0vejeikBYarRR6EckysZD4G70A@mail.gmail.com \
--to=loic.poulain@linaro.org \
--cc=bryan.odonoghue@linaro.org \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=shawn.guo@linaro.org \
--cc=wcn36xx@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).