linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Loic Poulain <loic.poulain@linaro.org>
To: "Bryan O'Donoghue" <bryan.odonoghue@linaro.org>
Cc: Kalle Valo <kvalo@codeaurora.org>,
	wcn36xx@lists.infradead.org, linux-wireless@vger.kernel.org,
	Shawn Guo <shawn.guo@linaro.org>
Subject: Re: [PATCH 3/3] wcn36xx: Enable firmware offloaded keepalive
Date: Sat, 31 Oct 2020 10:39:50 +0100	[thread overview]
Message-ID: <CAMZdPi86jzZ_A6OuBH=0NvdA=YXMjgXb+UaX5gajHffh20MgmQ@mail.gmail.com> (raw)
In-Reply-To: <20201031022311.1677337-4-bryan.odonoghue@linaro.org>

On Sat, 31 Oct 2020 at 03:22, Bryan O'Donoghue
<bryan.odonoghue@linaro.org> wrote:
>
> This patch calls wcn36xx_smd_keep_alive_req() on the STA patch immediately
> after associating with an AP.
>
> This will cause the firmware to send a NULL packet out to the AP every 30
> seconds, thus offloading keep-alive processing from the SoC to the
> firmware.
>
> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
> ---
>  drivers/net/wireless/ath/wcn36xx/main.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/net/wireless/ath/wcn36xx/main.c b/drivers/net/wireless/ath/wcn36xx/main.c
> index e924cc4acde0..b514a7b952df 100644
> --- a/drivers/net/wireless/ath/wcn36xx/main.c
> +++ b/drivers/net/wireless/ath/wcn36xx/main.c
> @@ -910,6 +910,8 @@ static void wcn36xx_bss_info_changed(struct ieee80211_hw *hw,
>                          * place where AID is available.
>                          */
>                         wcn36xx_smd_config_sta(wcn, vif, sta);
> +                       wcn36xx_smd_keep_alive_req(wcn, vif,
> +                                       WCN36XX_HAL_KEEP_ALIVE_NULL_PKT);

There is the wcn36xx_enable_keep_alive_null_packet function (from
pmc.c) that you can use.

>                 } else {
>                         wcn36xx_dbg(WCN36XX_DBG_MAC,
>                                     "disassociated bss %pM vif %pM AID=%d\n",
> --
> 2.28.0
>

  reply	other threads:[~2020-10-31  9:33 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-31  2:23 [PATCH 0/3] wcn36xx: Firmware link monitor/keepalive offload Bryan O'Donoghue
2020-10-31  2:23 ` [PATCH 1/3] wcn36xx: Set LINK_FAIL_TX_CNT non zero on wcn3620/wcn3660 Bryan O'Donoghue
2020-10-31  9:33   ` Loic Poulain
2020-10-31 12:48     ` Bryan O'Donoghue
2020-10-31  2:23 ` [PATCH 2/3] wcn36xx: Enable firmware link monitoring Bryan O'Donoghue
2020-10-31  9:57   ` Loic Poulain
2020-10-31 13:02     ` Bryan O'Donoghue
2020-11-02 19:15       ` Loic Poulain
2020-10-31  2:23 ` [PATCH 3/3] wcn36xx: Enable firmware offloaded keepalive Bryan O'Donoghue
2020-10-31  9:39   ` Loic Poulain [this message]
2020-10-31 12:54     ` Bryan O'Donoghue

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAMZdPi86jzZ_A6OuBH=0NvdA=YXMjgXb+UaX5gajHffh20MgmQ@mail.gmail.com' \
    --to=loic.poulain@linaro.org \
    --cc=bryan.odonoghue@linaro.org \
    --cc=kvalo@codeaurora.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=shawn.guo@linaro.org \
    --cc=wcn36xx@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).