* [PATCH] dt-bindings: leds: Document Bluetooth and WLAN triggers
@ 2022-11-09 14:46 Geert Uytterhoeven
2023-01-20 16:39 ` Krzysztof Kozlowski
0 siblings, 1 reply; 6+ messages in thread
From: Geert Uytterhoeven @ 2022-11-09 14:46 UTC (permalink / raw)
To: Pavel Machek, Rob Herring, Krzysztof Kozlowski, Jacek Anaszewski
Cc: linux-leds, devicetree, linux-wireless, linux-bluetooth,
linux-renesas-soc, Geert Uytterhoeven
Add the missing trigger patterns for Bluetooth and WLAN activity, which
are already in active use.
While at it, move the mmc pattern comment where it belongs, and restore
alphabetical sort order.
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
arch/arm64/boot/dts/renesas/r8a774a1-hihope-rzg2m-rev2.dtb: leds: bt_active_led:linux,default-trigger: 'oneOf' conditional failed, one must be fixed:
'hci0-power' is not one of ['backlight', 'default-on', 'heartbeat', 'disk-activity', 'ide-disk', 'timer', 'pattern']
'hci0-power' does not match '^mmc[0-9]+$'
From schema: Documentation/devicetree/bindings/leds/leds-gpio.yaml
arch/arm64/boot/dts/renesas/r8a774a1-hihope-rzg2m-rev2.dtb: leds: wlan_active_led:linux,default-trigger: 'oneOf' conditional failed, one must be fixed:
'phy0tx' is not one of ['backlight', 'default-on', 'heartbeat', 'disk-activity', 'ide-disk', 'timer', 'pattern']
'phy0tx' does not match '^mmc[0-9]+$'
From schema: Documentation/devicetree/bindings/leds/leds-gpio.yaml
---
Documentation/devicetree/bindings/leds/common.yaml | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/leds/common.yaml b/Documentation/devicetree/bindings/leds/common.yaml
index f5c57a580078ea23..d34bb58c00371402 100644
--- a/Documentation/devicetree/bindings/leds/common.yaml
+++ b/Documentation/devicetree/bindings/leds/common.yaml
@@ -98,9 +98,13 @@ properties:
# LED alters the brightness for the specified duration with one software
# timer (requires "led-pattern" property)
- pattern
- # LED is triggered by SD/MMC activity
- - pattern: "^mmc[0-9]+$"
- pattern: "^cpu[0-9]*$"
+ - pattern: "^hci[0-9]+-power$"
+ # LED is triggered by Bluetooth activity
+ - pattern: "^mmc[0-9]+$"
+ # LED is triggered by SD/MMC activity
+ - pattern: "^phy[0-9]+tx$"
+ # LED is triggered by WLAN activity
led-pattern:
description: |
--
2.25.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] dt-bindings: leds: Document Bluetooth and WLAN triggers
2022-11-09 14:46 [PATCH] dt-bindings: leds: Document Bluetooth and WLAN triggers Geert Uytterhoeven
@ 2023-01-20 16:39 ` Krzysztof Kozlowski
2023-01-20 21:28 ` Luiz Augusto von Dentz
0 siblings, 1 reply; 6+ messages in thread
From: Krzysztof Kozlowski @ 2023-01-20 16:39 UTC (permalink / raw)
To: Geert Uytterhoeven, Pavel Machek, Rob Herring,
Krzysztof Kozlowski, Jacek Anaszewski
Cc: linux-leds, devicetree, linux-wireless, linux-bluetooth,
linux-renesas-soc
On 09/11/2022 15:46, Geert Uytterhoeven wrote:
> Add the missing trigger patterns for Bluetooth and WLAN activity, which
> are already in active use.
>
> While at it, move the mmc pattern comment where it belongs, and restore
> alphabetical sort order.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> arch/arm64/boot/dts/renesas/r8a774a1-hihope-rzg2m-rev2.dtb: leds: bt_active_led:linux,default-trigger: 'oneOf' conditional failed, one must be fixed:
> 'hci0-power' is not one of ['backlight', 'default-on', 'heartbeat', 'disk-activity', 'ide-disk', 'timer', 'pattern']
> 'hci0-power' does not match '^mmc[0-9]+$'
> From schema: Documentation/devicetree/bindings/leds/leds-gpio.yaml
> arch/arm64/boot/dts/renesas/r8a774a1-hihope-rzg2m-rev2.dtb: leds: wlan_active_led:linux,default-trigger: 'oneOf' conditional failed, one must be fixed:
> 'phy0tx' is not one of ['backlight', 'default-on', 'heartbeat', 'disk-activity', 'ide-disk', 'timer', 'pattern']
> 'phy0tx' does not match '^mmc[0-9]+$'
> From schema: Documentation/devicetree/bindings/leds/leds-gpio.yaml
This patch got lost... Rob, Lee or Pavel, can you pick it up?
It's with Rob's approval:
https://lore.kernel.org/all/166861772609.231295.14812410099261417331.robh@kernel.org/
> ---
> Documentation/devicetree/bindings/leds/common.yaml | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/leds/common.yaml b/Documentation/devicetree/bindings/leds/common.yaml
> index f5c57a580078ea23..d34bb58c00371402 100644
> --- a/Documentation/devicetree/bindings/leds/common.yaml
> +++ b/Documentation/devicetree/bindings/leds/common.yaml
> @@ -98,9 +98,13 @@ properties:
> # LED alters the brightness for the specified duration with one software
> # timer (requires "led-pattern" property)
> - pattern
> - # LED is triggered by SD/MMC activity
> - - pattern: "^mmc[0-9]+$"
> - pattern: "^cpu[0-9]*$"
> + - pattern: "^hci[0-9]+-power$"
> + # LED is triggered by Bluetooth activity
> + - pattern: "^mmc[0-9]+$"
> + # LED is triggered by SD/MMC activity
> + - pattern: "^phy[0-9]+tx$"
> + # LED is triggered by WLAN activity
>
> led-pattern:
> description: |
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] dt-bindings: leds: Document Bluetooth and WLAN triggers
2023-01-20 16:39 ` Krzysztof Kozlowski
@ 2023-01-20 21:28 ` Luiz Augusto von Dentz
2023-01-22 10:48 ` Geert Uytterhoeven
0 siblings, 1 reply; 6+ messages in thread
From: Luiz Augusto von Dentz @ 2023-01-20 21:28 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Geert Uytterhoeven, Pavel Machek, Rob Herring,
Krzysztof Kozlowski, Jacek Anaszewski, linux-leds, devicetree,
linux-wireless, linux-bluetooth, linux-renesas-soc
Hi Krzysztof,
On Fri, Jan 20, 2023 at 8:42 AM Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
>
> On 09/11/2022 15:46, Geert Uytterhoeven wrote:
> > Add the missing trigger patterns for Bluetooth and WLAN activity, which
> > are already in active use.
> >
> > While at it, move the mmc pattern comment where it belongs, and restore
> > alphabetical sort order.
> >
> > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > ---
> > arch/arm64/boot/dts/renesas/r8a774a1-hihope-rzg2m-rev2.dtb: leds: bt_active_led:linux,default-trigger: 'oneOf' conditional failed, one must be fixed:
> > 'hci0-power' is not one of ['backlight', 'default-on', 'heartbeat', 'disk-activity', 'ide-disk', 'timer', 'pattern']
> > 'hci0-power' does not match '^mmc[0-9]+$'
> > From schema: Documentation/devicetree/bindings/leds/leds-gpio.yaml
> > arch/arm64/boot/dts/renesas/r8a774a1-hihope-rzg2m-rev2.dtb: leds: wlan_active_led:linux,default-trigger: 'oneOf' conditional failed, one must be fixed:
> > 'phy0tx' is not one of ['backlight', 'default-on', 'heartbeat', 'disk-activity', 'ide-disk', 'timer', 'pattern']
> > 'phy0tx' does not match '^mmc[0-9]+$'
> > From schema: Documentation/devicetree/bindings/leds/leds-gpio.yaml
>
> This patch got lost... Rob, Lee or Pavel, can you pick it up?
>
> It's with Rob's approval:
> https://lore.kernel.org/all/166861772609.231295.14812410099261417331.robh@kernel.org/
If it is going to be applied via bluetooth-next make sure to resend it
since last time our CI was not able to apply it thus why we didn't
apply it in the first place.
>
> > ---
> > Documentation/devicetree/bindings/leds/common.yaml | 8 ++++++--
> > 1 file changed, 6 insertions(+), 2 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/leds/common.yaml b/Documentation/devicetree/bindings/leds/common.yaml
> > index f5c57a580078ea23..d34bb58c00371402 100644
> > --- a/Documentation/devicetree/bindings/leds/common.yaml
> > +++ b/Documentation/devicetree/bindings/leds/common.yaml
> > @@ -98,9 +98,13 @@ properties:
> > # LED alters the brightness for the specified duration with one software
> > # timer (requires "led-pattern" property)
> > - pattern
> > - # LED is triggered by SD/MMC activity
> > - - pattern: "^mmc[0-9]+$"
> > - pattern: "^cpu[0-9]*$"
> > + - pattern: "^hci[0-9]+-power$"
> > + # LED is triggered by Bluetooth activity
> > + - pattern: "^mmc[0-9]+$"
> > + # LED is triggered by SD/MMC activity
> > + - pattern: "^phy[0-9]+tx$"
> > + # LED is triggered by WLAN activity
> >
> > led-pattern:
> > description: |
>
> Best regards,
> Krzysztof
>
--
Luiz Augusto von Dentz
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] dt-bindings: leds: Document Bluetooth and WLAN triggers
2023-01-20 21:28 ` Luiz Augusto von Dentz
@ 2023-01-22 10:48 ` Geert Uytterhoeven
2023-01-22 11:32 ` Geert Uytterhoeven
0 siblings, 1 reply; 6+ messages in thread
From: Geert Uytterhoeven @ 2023-01-22 10:48 UTC (permalink / raw)
To: Luiz Augusto von Dentz
Cc: Krzysztof Kozlowski, Pavel Machek, Rob Herring,
Krzysztof Kozlowski, Jacek Anaszewski, linux-leds, devicetree,
linux-wireless, linux-bluetooth, linux-renesas-soc
On Fri, Jan 20, 2023 at 10:42 PM Luiz Augusto von Dentz
<luiz.dentz@gmail.com> wrote:
> On Fri, Jan 20, 2023 at 8:42 AM Krzysztof Kozlowski
> <krzysztof.kozlowski@linaro.org> wrote:
> >
> > On 09/11/2022 15:46, Geert Uytterhoeven wrote:
> > > Add the missing trigger patterns for Bluetooth and WLAN activity, which
> > > are already in active use.
> > >
> > > While at it, move the mmc pattern comment where it belongs, and restore
> > > alphabetical sort order.
> > >
> > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > > ---
> > > arch/arm64/boot/dts/renesas/r8a774a1-hihope-rzg2m-rev2.dtb: leds: bt_active_led:linux,default-trigger: 'oneOf' conditional failed, one must be fixed:
> > > 'hci0-power' is not one of ['backlight', 'default-on', 'heartbeat', 'disk-activity', 'ide-disk', 'timer', 'pattern']
> > > 'hci0-power' does not match '^mmc[0-9]+$'
> > > From schema: Documentation/devicetree/bindings/leds/leds-gpio.yaml
> > > arch/arm64/boot/dts/renesas/r8a774a1-hihope-rzg2m-rev2.dtb: leds: wlan_active_led:linux,default-trigger: 'oneOf' conditional failed, one must be fixed:
> > > 'phy0tx' is not one of ['backlight', 'default-on', 'heartbeat', 'disk-activity', 'ide-disk', 'timer', 'pattern']
> > > 'phy0tx' does not match '^mmc[0-9]+$'
> > > From schema: Documentation/devicetree/bindings/leds/leds-gpio.yaml
> >
> > This patch got lost... Rob, Lee or Pavel, can you pick it up?
> >
> > It's with Rob's approval:
> > https://lore.kernel.org/all/166861772609.231295.14812410099261417331.robh@kernel.org/
>
> If it is going to be applied via bluetooth-next make sure to resend it
> since last time our CI was not able to apply it thus why we didn't
> apply it in the first place.
Resent as v2, https://lore.kernel.org/r/0d0de1bc949d24e08174205c13c0b59bd73c1ea8.1674384302.git.geert+renesas@glider.be
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] dt-bindings: leds: Document Bluetooth and WLAN triggers
2023-01-22 10:48 ` Geert Uytterhoeven
@ 2023-01-22 11:32 ` Geert Uytterhoeven
0 siblings, 0 replies; 6+ messages in thread
From: Geert Uytterhoeven @ 2023-01-22 11:32 UTC (permalink / raw)
To: Luiz Augusto von Dentz
Cc: Krzysztof Kozlowski, Pavel Machek, Rob Herring,
Krzysztof Kozlowski, Jacek Anaszewski, linux-leds, devicetree,
linux-wireless, linux-bluetooth, linux-renesas-soc
Hi Luiz,
On Sun, Jan 22, 2023 at 11:48 AM Geert Uytterhoeven
<geert@linux-m68k.org> wrote:
> On Fri, Jan 20, 2023 at 10:42 PM Luiz Augusto von Dentz
> <luiz.dentz@gmail.com> wrote:
> > On Fri, Jan 20, 2023 at 8:42 AM Krzysztof Kozlowski
> > <krzysztof.kozlowski@linaro.org> wrote:
> > > On 09/11/2022 15:46, Geert Uytterhoeven wrote:
> > > > Add the missing trigger patterns for Bluetooth and WLAN activity, which
> > > > are already in active use.
> > > >
> > > > While at it, move the mmc pattern comment where it belongs, and restore
> > > > alphabetical sort order.
> > > >
> > > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > > > ---
> > > > arch/arm64/boot/dts/renesas/r8a774a1-hihope-rzg2m-rev2.dtb: leds: bt_active_led:linux,default-trigger: 'oneOf' conditional failed, one must be fixed:
> > > > 'hci0-power' is not one of ['backlight', 'default-on', 'heartbeat', 'disk-activity', 'ide-disk', 'timer', 'pattern']
> > > > 'hci0-power' does not match '^mmc[0-9]+$'
> > > > From schema: Documentation/devicetree/bindings/leds/leds-gpio.yaml
> > > > arch/arm64/boot/dts/renesas/r8a774a1-hihope-rzg2m-rev2.dtb: leds: wlan_active_led:linux,default-trigger: 'oneOf' conditional failed, one must be fixed:
> > > > 'phy0tx' is not one of ['backlight', 'default-on', 'heartbeat', 'disk-activity', 'ide-disk', 'timer', 'pattern']
> > > > 'phy0tx' does not match '^mmc[0-9]+$'
> > > > From schema: Documentation/devicetree/bindings/leds/leds-gpio.yaml
> > >
> > > This patch got lost... Rob, Lee or Pavel, can you pick it up?
> > >
> > > It's with Rob's approval:
> > > https://lore.kernel.org/all/166861772609.231295.14812410099261417331.robh@kernel.org/
> >
> > If it is going to be applied via bluetooth-next make sure to resend it
> > since last time our CI was not able to apply it thus why we didn't
> > apply it in the first place.
>
> Resent as v2, https://lore.kernel.org/r/0d0de1bc949d24e08174205c13c0b59bd73c1ea8.1674384302.git.geert+renesas@glider.be
According to your CI, it still does not apply.
However, there are no changes to
Documentation/devicetree/bindings/leds/leds-gpio.yaml
between v6.2-rc1 and next-20230120.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] dt-bindings: leds: Document Bluetooth and WLAN triggers
@ 2022-11-16 16:55 Rob Herring
0 siblings, 0 replies; 6+ messages in thread
From: Rob Herring @ 2022-11-16 16:55 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: linux-wireless, devicetree, Pavel Machek, linux-bluetooth,
Rob Herring, Jacek Anaszewski, linux-renesas-soc,
Krzysztof Kozlowski, linux-leds
On Wed, 09 Nov 2022 15:46:06 +0100, Geert Uytterhoeven wrote:
> Add the missing trigger patterns for Bluetooth and WLAN activity, which
> are already in active use.
>
> While at it, move the mmc pattern comment where it belongs, and restore
> alphabetical sort order.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> arch/arm64/boot/dts/renesas/r8a774a1-hihope-rzg2m-rev2.dtb: leds: bt_active_led:linux,default-trigger: 'oneOf' conditional failed, one must be fixed:
> 'hci0-power' is not one of ['backlight', 'default-on', 'heartbeat', 'disk-activity', 'ide-disk', 'timer', 'pattern']
> 'hci0-power' does not match '^mmc[0-9]+$'
> From schema: Documentation/devicetree/bindings/leds/leds-gpio.yaml
> arch/arm64/boot/dts/renesas/r8a774a1-hihope-rzg2m-rev2.dtb: leds: wlan_active_led:linux,default-trigger: 'oneOf' conditional failed, one must be fixed:
> 'phy0tx' is not one of ['backlight', 'default-on', 'heartbeat', 'disk-activity', 'ide-disk', 'timer', 'pattern']
> 'phy0tx' does not match '^mmc[0-9]+$'
> From schema: Documentation/devicetree/bindings/leds/leds-gpio.yaml
> ---
> Documentation/devicetree/bindings/leds/common.yaml | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
Reviewed-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-01-22 11:32 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-09 14:46 [PATCH] dt-bindings: leds: Document Bluetooth and WLAN triggers Geert Uytterhoeven
2023-01-20 16:39 ` Krzysztof Kozlowski
2023-01-20 21:28 ` Luiz Augusto von Dentz
2023-01-22 10:48 ` Geert Uytterhoeven
2023-01-22 11:32 ` Geert Uytterhoeven
2022-11-16 16:55 Rob Herring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).