linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tony Chuang <yhchuang@realtek.com>
To: Brian Norris <briannorris@chromium.org>
Cc: "kvalo@codeaurora.org" <kvalo@codeaurora.org>,
	"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: RE: [PATCH v2 3/6] rtw88: Enable 802.11ac beamformee support
Date: Thu, 17 Oct 2019 02:43:07 +0000	[thread overview]
Message-ID: <F7CD281DE3E379468C6D07993EA72F84D1900CBB@RTITMBSVM04.realtek.com.tw> (raw)
In-Reply-To: <20191016170628.GA206123@google.com>

From: Brian Norris [mailto:briannorris@chromium.org]
> Subject: Re: [PATCH v2 3/6] rtw88: Enable 802.11ac beamformee support
> 
> Hi,
> 
> On Wed, Oct 16, 2019 at 08:32:58PM +0800, yhchuang@realtek.com wrote:
> ...
> > diff --git a/drivers/net/wireless/realtek/rtw88/bf.h
> b/drivers/net/wireless/realtek/rtw88/bf.h
> > new file mode 100644
> > index 000000000000..96a8216dd11f
> > --- /dev/null
> > +++ b/drivers/net/wireless/realtek/rtw88/bf.h
> 
> ...
> 
> > +void rtw_bf_disassoc(struct rtw_dev *rtwdev, struct ieee80211_vif *vif,
> > +		     struct ieee80211_bss_conf *bss_conf);
> > +void rtw_bf_assoc(struct rtw_dev *rtwdev, struct ieee80211_vif *vif,
> > +		  struct ieee80211_bss_conf *bss_conf);
> > +void rtw_bf_init_bfer_entry_mu(struct rtw_dev *rtwdev,
> > +			       struct mu_bfer_init_para *param);
> 
> Not used outside bf.c, so you should make it static in bf.c and drop the
> declaration here.
> 
> > +void rtw_bf_cfg_sounding(struct rtw_dev *rtwdev, struct rtw_vif *vif,
> > +			 enum rtw_trx_desc_rate rate);
> 
> Same.
> 
> > +void rtw_bf_cfg_mu_bfee(struct rtw_dev *rtwdev, struct
> cfg_mumimo_para *param);
> 
> Same.
> 
> > +void rtw_bf_del_bfer_entry_mu(struct rtw_dev *rtwdev);
> 
> Same.
> 
> > +void rtw_bf_del_sounding(struct rtw_dev *rtwdev);
> 
> Same.
> 
> > +void rtw_bf_enable_bfee_su(struct rtw_dev *rtwdev, struct rtw_vif *vif,
> > +			   struct rtw_bfee *bfee);
> > +void rtw_bf_enable_bfee_mu(struct rtw_dev *rtwdev, struct rtw_vif *vif,
> > +			   struct rtw_bfee *bfee);
> > +void rtw_bf_remove_bfee_su(struct rtw_dev *rtwdev, struct rtw_bfee
> *bfee);
> > +void rtw_bf_remove_bfee_mu(struct rtw_dev *rtwdev, struct rtw_bfee
> *bfee);
> > +void rtw_bf_set_gid_table(struct rtw_dev *rtwdev, struct ieee80211_vif
> *vif,
> > +			  struct ieee80211_bss_conf *conf);
> > +void rtw_bf_phy_init(struct rtw_dev *rtwdev);
> > +void rtw_bf_cfg_csi_rate(struct rtw_dev *rtwdev, u8 rssi, u8 cur_rate,
> > +			 u8 fixrate_en, u8 *new_rate);
> > +#endif
> 

OK, that should be static if not being used.
Will send a v3 to fix them.

Yan-Hsuan

  reply	other threads:[~2019-10-17  2:43 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-16 12:32 [PATCH v2 0/6] rtw88: minor throughput improvement yhchuang
2019-10-16 12:32 ` [PATCH v2 1/6] rtw88: use macro to check the current band yhchuang
2019-10-16 17:10   ` Brian Norris
2019-10-17  2:39     ` Tony Chuang
2019-11-06 20:53       ` Brian Norris
2019-11-07  3:35         ` Tony Chuang
2019-10-16 12:32 ` [PATCH v2 2/6] rtw88: add power tracking support yhchuang
2019-10-17 10:32   ` Chris Chiu
2019-10-16 12:32 ` [PATCH v2 3/6] rtw88: Enable 802.11ac beamformee support yhchuang
2019-10-16 17:06   ` Brian Norris
2019-10-17  2:43     ` Tony Chuang [this message]
2019-10-16 12:32 ` [PATCH v2 4/6] rtw88: update regulatory settings implementaion yhchuang
2019-10-16 16:53   ` Brian Norris
2019-10-17  2:55     ` Tony Chuang
2019-10-17  3:17       ` Brian Norris
2019-10-19 11:14         ` Kalle Valo
2019-10-16 12:33 ` [PATCH v2 5/6] rtw88: add set_bitrate_mask support yhchuang
2019-10-17 10:25   ` Chris Chiu
2019-10-19 11:18     ` Kalle Valo
2019-10-16 12:33 ` [PATCH v2 6/6] rtw88: add phy_info debugfs to show Tx/Rx physical status yhchuang
2019-10-18  7:02   ` Chris Chiu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=F7CD281DE3E379468C6D07993EA72F84D1900CBB@RTITMBSVM04.realtek.com.tw \
    --to=yhchuang@realtek.com \
    --cc=briannorris@chromium.org \
    --cc=kvalo@codeaurora.org \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).