From: Tony Chuang <yhchuang@realtek.com>
To: Brian Norris <briannorris@chromium.org>
Cc: Kalle Valo <kvalo@codeaurora.org>,
linux-wireless <linux-wireless@vger.kernel.org>
Subject: RE: [PATCH v2 4/6] rtw88: update regulatory settings implementaion
Date: Thu, 17 Oct 2019 02:55:23 +0000 [thread overview]
Message-ID: <F7CD281DE3E379468C6D07993EA72F84D1900CF3@RTITMBSVM04.realtek.com.tw> (raw)
In-Reply-To: <CA+ASDXMj_f9q1aKgkcqd+2NPmxQfcQsJK8zQLUQSu8DSUW7Fsw@mail.gmail.com>
From: Brian Norris
>
> On Wed, Oct 16, 2019 at 5:33 AM <yhchuang@realtek.com> wrote:
> > This also supports user regulatory hints, and it should only be
> > enabled for specific distributions that need this to correct
> > the cards reglutory.
>
> s/cards/card's/
> s/reglutory/regulatory/
Typo should be fixed in v3 :)
>
> There should be a pretty high bar for introducing either new CONFIG_*
> options or module parameters, in my opinion, and I'm not sure you
> really satisfied it. Why "should only be enabled" by certain
> distributions? Your opinion? If it's the technical limitation you
> refer to ("efuse settings"), then just detect the efuse and prevent
> user hints only on those modules.
>
Because the efuse/module does not contain the information if the
user's hint is allowed. But sometimes distributions require to set the
regulatory via "NL80211_CMD_SET_REG".
So we are leaving the CONFIG_* here for some reason that needs it.
Yan-Hsuan
next prev parent reply other threads:[~2019-10-17 2:55 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-16 12:32 [PATCH v2 0/6] rtw88: minor throughput improvement yhchuang
2019-10-16 12:32 ` [PATCH v2 1/6] rtw88: use macro to check the current band yhchuang
2019-10-16 17:10 ` Brian Norris
2019-10-17 2:39 ` Tony Chuang
2019-11-06 20:53 ` Brian Norris
2019-11-07 3:35 ` Tony Chuang
2019-10-16 12:32 ` [PATCH v2 2/6] rtw88: add power tracking support yhchuang
2019-10-17 10:32 ` Chris Chiu
2019-10-16 12:32 ` [PATCH v2 3/6] rtw88: Enable 802.11ac beamformee support yhchuang
2019-10-16 17:06 ` Brian Norris
2019-10-17 2:43 ` Tony Chuang
2019-10-16 12:32 ` [PATCH v2 4/6] rtw88: update regulatory settings implementaion yhchuang
2019-10-16 16:53 ` Brian Norris
2019-10-17 2:55 ` Tony Chuang [this message]
2019-10-17 3:17 ` Brian Norris
2019-10-19 11:14 ` Kalle Valo
2019-10-16 12:33 ` [PATCH v2 5/6] rtw88: add set_bitrate_mask support yhchuang
2019-10-17 10:25 ` Chris Chiu
2019-10-19 11:18 ` Kalle Valo
2019-10-16 12:33 ` [PATCH v2 6/6] rtw88: add phy_info debugfs to show Tx/Rx physical status yhchuang
2019-10-18 7:02 ` Chris Chiu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=F7CD281DE3E379468C6D07993EA72F84D1900CF3@RTITMBSVM04.realtek.com.tw \
--to=yhchuang@realtek.com \
--cc=briannorris@chromium.org \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).