From: Brian Norris <briannorris@chromium.org>
To: Ping-Ke Shih <pkshih@realtek.com>
Cc: kvalo@codeaurora.org, linux-wireless@vger.kernel.org
Subject: Re: [PATCH 03/24] rtw89: add core and trx files
Date: Thu, 15 Jul 2021 11:57:04 -0700 [thread overview]
Message-ID: <YPCFABiygQbiMqcB@google.com> (raw)
In-Reply-To: <20210618064625.14131-4-pkshih@realtek.com>
Hi,
On Fri, Jun 18, 2021 at 02:46:04PM +0800, Ping-Ke Shih wrote:
> --- /dev/null
> +++ b/drivers/net/wireless/realtek/rtw89/core.c
> @@ -0,0 +1,2359 @@
> +static void rtw89_traffic_stats_calc(struct rtw89_dev *rtwdev,
> + struct rtw89_traffic_stats *stats)
> +{
...
> + stats->tx_avg_len = (u32)(stats->tx_cnt ? stats->tx_unicast / stats->tx_cnt : 0);
> + stats->rx_avg_len = (u32)(stats->rx_cnt ? stats->rx_unicast / stats->rx_cnt : 0);
You're doing 64-bit division which isn't supported on all architectures.
You need a do_div()-based solution here, like:
stats->tx_avg_len = stats->tx_cnt
? DIV_ROUND_DOWN_ULL(stats->tx_unicast, stats->tx_cnt)
: 0;
stats->rx_avg_len = stats->rx_cnt
? DIV_ROUND_DOWN_ULL(stats->rx_unicast, stats->rx_cnt)
: 0;
Brian
next prev parent reply other threads:[~2021-07-15 18:58 UTC|newest]
Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-18 6:46 [PATCH 00/24] rtw89: add Realtek 802.11ax driver Ping-Ke Shih
2021-06-18 6:46 ` [PATCH 01/24] rtw89: add CAM files Ping-Ke Shih
2021-06-18 6:46 ` [PATCH 02/24] rtw89: add BT coexistence files Ping-Ke Shih
2021-06-18 6:46 ` [PATCH 03/24] rtw89: add core and trx files Ping-Ke Shih
2021-07-09 17:32 ` Oleksij Rempel
2021-07-12 6:23 ` Pkshih
2021-07-15 18:57 ` Brian Norris [this message]
2021-07-16 2:00 ` Pkshih
2021-06-18 6:46 ` [PATCH 04/24] rtw89: add debug files Ping-Ke Shih
2021-07-02 7:23 ` Oleksij Rempel
2021-07-02 17:08 ` Brian Norris
2021-07-02 17:57 ` Oleksij Rempel
2021-07-02 18:38 ` Brian Norris
2021-07-02 19:32 ` Oleksij Rempel
2021-07-02 20:00 ` Brian Norris
2021-07-03 4:15 ` Oleksij Rempel
2021-07-13 1:40 ` Brian Norris
2021-07-05 8:58 ` Pkshih
2021-07-05 9:09 ` Oleksij Rempel
2021-07-05 8:08 ` Kalle Valo
2021-07-05 9:23 ` Oleksij Rempel
2021-07-05 8:58 ` Pkshih
2021-07-13 1:57 ` Brian Norris
2021-07-13 4:50 ` Oleksij Rempel
2021-07-13 11:26 ` Pkshih
2021-06-18 6:46 ` [PATCH 05/24] rtw89: add efuse files Ping-Ke Shih
2021-06-18 6:46 ` [PATCH 06/24] rtw89: add files to download and communicate with firmware Ping-Ke Shih
2021-06-18 6:46 ` [PATCH 07/24] rtw89: add MAC files Ping-Ke Shih
2021-07-09 17:38 ` Oleksij Rempel
2021-07-09 18:16 ` Johannes Berg
2021-07-10 4:58 ` Oleksij Rempel
2021-07-12 1:51 ` Pkshih
2021-07-12 6:23 ` Pkshih
2021-06-18 6:46 ` [PATCH 08/24] rtw89: implement mac80211 ops Ping-Ke Shih
2021-06-18 6:46 ` [PATCH 09/24] rtw89: add pci files Ping-Ke Shih
2021-06-18 6:46 ` [PATCH 10/24] rtw89: add phy files Ping-Ke Shih
2021-06-18 6:46 ` [PATCH 11/24] rtw89: define register names Ping-Ke Shih
2021-06-18 6:46 ` [PATCH 12/24] rtw89: add regulatory support Ping-Ke Shih
2021-06-18 6:46 ` [PATCH 13/24] rtw89: 8852a: add 8852a specific files Ping-Ke Shih
2021-07-10 5:27 ` Oleksij Rempel
2021-07-12 6:24 ` Pkshih
2021-06-18 6:46 ` [PATCH 14/24] rtw89: 8852a: add 8852a RFK files Ping-Ke Shih
2021-07-09 17:41 ` Oleksij Rempel
2021-07-12 6:23 ` Pkshih
2021-07-15 3:33 ` Pkshih
2021-07-15 3:59 ` Oleksij Rempel
2021-06-18 6:46 ` [PATCH 15/24] rtw89: 8852a: add 8852a RFK tables Ping-Ke Shih
2021-06-18 6:46 ` [PATCH 16/24] rtw89: 8852a: add 8852a tables (1 of 5) Ping-Ke Shih
2021-06-18 6:46 ` [PATCH 17/24] rtw89: 8852a: add 8852a tables (2 " Ping-Ke Shih
2021-06-18 6:46 ` [PATCH 18/24] rtw89: 8852a: add 8852a tables (3 " Ping-Ke Shih
2021-06-18 6:46 ` [PATCH 19/24] rtw89: 8852a: add 8852a tables (4 " Ping-Ke Shih
2021-06-18 6:46 ` [PATCH 20/24] rtw89: 8852a: add 8852a tables (5 " Ping-Ke Shih
2021-06-18 6:46 ` [PATCH 21/24] rtw89: add ser to recover error reported by firmware Ping-Ke Shih
2021-06-18 6:46 ` [PATCH 22/24] rtw89: add PS files Ping-Ke Shih
2021-06-18 6:46 ` [PATCH 23/24] rtw89: add SAR files Ping-Ke Shih
2021-06-18 6:46 ` [PATCH 24/24] rtw89: add Kconfig and Makefile Ping-Ke Shih
2021-06-19 3:18 ` kernel test robot
2021-06-25 8:54 ` Pkshih
2021-06-19 3:18 ` kernel test robot
2021-06-18 7:11 ` [PATCH 00/24] rtw89: add Realtek 802.11ax driver Pkshih
2021-06-23 6:29 ` Aaron Ma
2021-06-30 4:52 ` Aaron Ma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YPCFABiygQbiMqcB@google.com \
--to=briannorris@chromium.org \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=pkshih@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).