From: Pkshih <pkshih@realtek.com>
To: Oleksij Rempel <o.rempel@pengutronix.de>
Cc: "kvalo@codeaurora.org" <kvalo@codeaurora.org>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: RE: [PATCH 13/24] rtw89: 8852a: add 8852a specific files
Date: Mon, 12 Jul 2021 06:24:00 +0000 [thread overview]
Message-ID: <de0ed6250b864d63ae39d7778b6b7b63@realtek.com> (raw)
In-Reply-To: <20210710052753.GA485@pengutronix.de>
> -----Original Message-----
> From: Oleksij Rempel [mailto:o.rempel@pengutronix.de]
> Sent: Saturday, July 10, 2021 1:28 PM
> To: Pkshih
> Cc: kvalo@codeaurora.org; linux-wireless@vger.kernel.org
> Subject: Re: [PATCH 13/24] rtw89: 8852a: add 8852a specific files
>
> On Fri, Jun 18, 2021 at 02:46:14PM +0800, Ping-Ke Shih wrote:
> > +static struct rtw89_hfc_param_ini rtw8852a_hfc_param_ini_pcie[] = {
> > + [RTW89_QTA_SCC] = {rtw8852a_hfc_chcfg_pcie, &rtw8852a_hfc_pubcfg_pcie,
> > + &rtw_hfc_preccfg_pcie, RTW89_HCIFC_POH},
> > + [RTW89_QTA_DBCC] = {rtw8852a_hfc_chcfg_pcie, &rtw8852a_hfc_pubcfg_pcie,
> > + &rtw_hfc_preccfg_pcie, RTW89_HCIFC_POH},
> > + [RTW89_QTA_SCC_STF] = {rtw8852a_hfc_chcfg_pcie_stf,
> > + &rtw8852a_hfc_pubcfg_pcie_stf,
> > + &rtw_hfc_preccfg_pcie_stf, RTW89_HCIFC_STF},
> > + [RTW89_QTA_DBCC_STF] = {rtw8852a_hfc_chcfg_pcie_stf,
> > + &rtw8852a_hfc_pubcfg_pcie_stf,
> > + &rtw_hfc_preccfg_pcie_stf, RTW89_HCIFC_STF},
> > + [RTW89_QTA_SU_TP] = {rtw8852a_hfc_chcfg_pcie_sutp,
> > + &rtw8852a_hfc_pubcfg_pcie_sutp,
> > + &rtw_hfc_preccfg_pcie, RTW89_HCIFC_POH},
> > + [RTW89_QTA_DLFW] = {NULL, NULL, &rtw_hfc_preccfg_pcie, RTW89_HCIFC_POH},
> > + [RTW89_QTA_LAMODE] = {rtw8852a_hfc_chcfg_pcie_la,
> > + &rtw8852a_hfc_pubcfg_pcie_la,
> > + &rtw_hfc_preccfg_pcie, RTW89_HCIFC_POH},
> > + [RTW89_QTA_INVALID] = {NULL},
> > +};
> > +
> > +static struct rtw89_dle_mem rtw8852a_dle_mem_pcie[] = {
> > + [RTW89_QTA_SCC] = {RTW89_QTA_SCC, &wde_size0, &ple_size0, &wde_qt0,
> > + &wde_qt0, &ple_qt4, &ple_qt5},
> > + [RTW89_QTA_DBCC] = {RTW89_QTA_DBCC, &wde_size0, &ple_size0, &wde_qt0,
> > + &wde_qt0, &ple_qt0, &ple_qt1},
> > + [RTW89_QTA_SCC_STF] = {RTW89_QTA_SCC_STF, &wde_size1, &ple_size2,
> > + &wde_qt1, &wde_qt1, &ple_qt8, &ple_qt9},
> > + [RTW89_QTA_DBCC_STF] = {RTW89_QTA_DBCC_STF, &wde_size1, &ple_size2,
> > + &wde_qt1, &wde_qt1, &ple_qt10, &ple_qt11},
> > + [RTW89_QTA_SU_TP] = {RTW89_QTA_SU_TP, &wde_size3, &ple_size3,
> > + &wde_qt3, &wde_qt3, &ple_qt12, &ple_qt12},
> > + [RTW89_QTA_DLFW] = {RTW89_QTA_DLFW, &wde_size4, &ple_size4,
> > + &wde_qt4, &wde_qt4, &ple_qt13, &ple_qt13},
> > + [RTW89_QTA_LAMODE] = {RTW89_QTA_LAMODE, &wde_size10, &ple_size10,
> > + &wde_qt9, &wde_qt9, &ple_qt23, &ple_qt24},
> > + [RTW89_QTA_INVALID] = {RTW89_QTA_INVALID, NULL, NULL, NULL, NULL, NULL,
> > + NULL},
> > +};
>
> IF I see it correctly, only some of this RTW89_QTA_* modes are actually
> used.
> If this modes are not used by the current state of the driver, please
> remove it.
>
> RTW89_QTA_SCC, RTW89_QTA_DLFW and RTW89_QTA_INVALID - are requested
> RTW89_QTA_DBCC, RTW89_QTA_SU_TP - not used. If so, please remove.
> RTW89_QTA_SCC_STF, RTW89_QTA_DBCC_STF and RTW89_QTA_LAMODE - kind of used but
> never set/requested? If so, please remove the modes and the code which
> depends on it. For example dle_rsvd_size() is executed if RTW89_QTA_LAMODE is
> set, but I can find any play where it is actually set.
>
Will remove unused parts.
next prev parent reply other threads:[~2021-07-12 6:25 UTC|newest]
Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-18 6:46 [PATCH 00/24] rtw89: add Realtek 802.11ax driver Ping-Ke Shih
2021-06-18 6:46 ` [PATCH 01/24] rtw89: add CAM files Ping-Ke Shih
2021-06-18 6:46 ` [PATCH 02/24] rtw89: add BT coexistence files Ping-Ke Shih
2021-06-18 6:46 ` [PATCH 03/24] rtw89: add core and trx files Ping-Ke Shih
2021-07-09 17:32 ` Oleksij Rempel
2021-07-12 6:23 ` Pkshih
2021-07-15 18:57 ` Brian Norris
2021-07-16 2:00 ` Pkshih
2021-06-18 6:46 ` [PATCH 04/24] rtw89: add debug files Ping-Ke Shih
2021-07-02 7:23 ` Oleksij Rempel
2021-07-02 17:08 ` Brian Norris
2021-07-02 17:57 ` Oleksij Rempel
2021-07-02 18:38 ` Brian Norris
2021-07-02 19:32 ` Oleksij Rempel
2021-07-02 20:00 ` Brian Norris
2021-07-03 4:15 ` Oleksij Rempel
2021-07-13 1:40 ` Brian Norris
2021-07-05 8:58 ` Pkshih
2021-07-05 9:09 ` Oleksij Rempel
2021-07-05 8:08 ` Kalle Valo
2021-07-05 9:23 ` Oleksij Rempel
2021-07-05 8:58 ` Pkshih
2021-07-13 1:57 ` Brian Norris
2021-07-13 4:50 ` Oleksij Rempel
2021-07-13 11:26 ` Pkshih
2021-06-18 6:46 ` [PATCH 05/24] rtw89: add efuse files Ping-Ke Shih
2021-06-18 6:46 ` [PATCH 06/24] rtw89: add files to download and communicate with firmware Ping-Ke Shih
2021-06-18 6:46 ` [PATCH 07/24] rtw89: add MAC files Ping-Ke Shih
2021-07-09 17:38 ` Oleksij Rempel
2021-07-09 18:16 ` Johannes Berg
2021-07-10 4:58 ` Oleksij Rempel
2021-07-12 1:51 ` Pkshih
2021-07-12 6:23 ` Pkshih
2021-06-18 6:46 ` [PATCH 08/24] rtw89: implement mac80211 ops Ping-Ke Shih
2021-06-18 6:46 ` [PATCH 09/24] rtw89: add pci files Ping-Ke Shih
2021-06-18 6:46 ` [PATCH 10/24] rtw89: add phy files Ping-Ke Shih
2021-06-18 6:46 ` [PATCH 11/24] rtw89: define register names Ping-Ke Shih
2021-06-18 6:46 ` [PATCH 12/24] rtw89: add regulatory support Ping-Ke Shih
2021-06-18 6:46 ` [PATCH 13/24] rtw89: 8852a: add 8852a specific files Ping-Ke Shih
2021-07-10 5:27 ` Oleksij Rempel
2021-07-12 6:24 ` Pkshih [this message]
2021-06-18 6:46 ` [PATCH 14/24] rtw89: 8852a: add 8852a RFK files Ping-Ke Shih
2021-07-09 17:41 ` Oleksij Rempel
2021-07-12 6:23 ` Pkshih
2021-07-15 3:33 ` Pkshih
2021-07-15 3:59 ` Oleksij Rempel
2021-06-18 6:46 ` [PATCH 15/24] rtw89: 8852a: add 8852a RFK tables Ping-Ke Shih
2021-06-18 6:46 ` [PATCH 16/24] rtw89: 8852a: add 8852a tables (1 of 5) Ping-Ke Shih
2021-06-18 6:46 ` [PATCH 17/24] rtw89: 8852a: add 8852a tables (2 " Ping-Ke Shih
2021-06-18 6:46 ` [PATCH 18/24] rtw89: 8852a: add 8852a tables (3 " Ping-Ke Shih
2021-06-18 6:46 ` [PATCH 19/24] rtw89: 8852a: add 8852a tables (4 " Ping-Ke Shih
2021-06-18 6:46 ` [PATCH 20/24] rtw89: 8852a: add 8852a tables (5 " Ping-Ke Shih
2021-06-18 6:46 ` [PATCH 21/24] rtw89: add ser to recover error reported by firmware Ping-Ke Shih
2021-06-18 6:46 ` [PATCH 22/24] rtw89: add PS files Ping-Ke Shih
2021-06-18 6:46 ` [PATCH 23/24] rtw89: add SAR files Ping-Ke Shih
2021-06-18 6:46 ` [PATCH 24/24] rtw89: add Kconfig and Makefile Ping-Ke Shih
2021-06-19 3:18 ` kernel test robot
2021-06-25 8:54 ` Pkshih
2021-06-19 3:18 ` kernel test robot
2021-06-18 7:11 ` [PATCH 00/24] rtw89: add Realtek 802.11ax driver Pkshih
2021-06-23 6:29 ` Aaron Ma
2021-06-30 4:52 ` Aaron Ma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=de0ed6250b864d63ae39d7778b6b7b63@realtek.com \
--to=pkshih@realtek.com \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).