linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Manikanta Pubbisetty <quic_mpubbise@quicinc.com>
Cc: ath11k@lists.infradead.org, linux-wireless@vger.kernel.org,
	devicetree@vger.kernel.org
Subject: Re: [PATCH 19/19] dt: bindings: net: add bindings of WCN6750 for ath11k
Date: Sun, 28 Nov 2021 10:20:59 -0600	[thread overview]
Message-ID: <YaOsaxfXLmOtznYg@robh.at.kernel.org> (raw)
In-Reply-To: <1637693434-15462-20-git-send-email-quic_mpubbise@quicinc.com>

On Wed, Nov 24, 2021 at 12:20:34AM +0530, Manikanta Pubbisetty wrote:
> Add WCN6750 wireless driver support, its based on ath11k driver.
> 
> Signed-off-by: Manikanta Pubbisetty <quic_mpubbise@quicinc.com>
> ---
>  .../bindings/net/wireless/qcom,ath11k.yaml         | 333 ++++++++++++++-------
>  1 file changed, 225 insertions(+), 108 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/net/wireless/qcom,ath11k.yaml b/Documentation/devicetree/bindings/net/wireless/qcom,ath11k.yaml
> index 85c2f69..60bda6d 100644
> --- a/Documentation/devicetree/bindings/net/wireless/qcom,ath11k.yaml
> +++ b/Documentation/devicetree/bindings/net/wireless/qcom,ath11k.yaml
> @@ -20,120 +20,21 @@ properties:
>      enum:
>        - qcom,ipq8074-wifi
>        - qcom,ipq6018-wifi
> +      - qcom,wcn6750-wifi
>  
>    reg:
>      maxItems: 1
>  
> -  interrupts:
> -    items:
> -      - description: misc-pulse1 interrupt events
> -      - description: misc-latch interrupt events
> -      - description: sw exception interrupt events
> -      - description: watchdog interrupt events
> -      - description: interrupt event for ring CE0
> -      - description: interrupt event for ring CE1
> -      - description: interrupt event for ring CE2
> -      - description: interrupt event for ring CE3
> -      - description: interrupt event for ring CE4
> -      - description: interrupt event for ring CE5
> -      - description: interrupt event for ring CE6
> -      - description: interrupt event for ring CE7
> -      - description: interrupt event for ring CE8
> -      - description: interrupt event for ring CE9
> -      - description: interrupt event for ring CE10
> -      - description: interrupt event for ring CE11
> -      - description: interrupt event for ring host2wbm-desc-feed
> -      - description: interrupt event for ring host2reo-re-injection
> -      - description: interrupt event for ring host2reo-command
> -      - description: interrupt event for ring host2rxdma-monitor-ring3
> -      - description: interrupt event for ring host2rxdma-monitor-ring2
> -      - description: interrupt event for ring host2rxdma-monitor-ring1
> -      - description: interrupt event for ring reo2ost-exception
> -      - description: interrupt event for ring wbm2host-rx-release
> -      - description: interrupt event for ring reo2host-status
> -      - description: interrupt event for ring reo2host-destination-ring4
> -      - description: interrupt event for ring reo2host-destination-ring3
> -      - description: interrupt event for ring reo2host-destination-ring2
> -      - description: interrupt event for ring reo2host-destination-ring1
> -      - description: interrupt event for ring rxdma2host-monitor-destination-mac3
> -      - description: interrupt event for ring rxdma2host-monitor-destination-mac2
> -      - description: interrupt event for ring rxdma2host-monitor-destination-mac1
> -      - description: interrupt event for ring ppdu-end-interrupts-mac3
> -      - description: interrupt event for ring ppdu-end-interrupts-mac2
> -      - description: interrupt event for ring ppdu-end-interrupts-mac1
> -      - description: interrupt event for ring rxdma2host-monitor-status-ring-mac3
> -      - description: interrupt event for ring rxdma2host-monitor-status-ring-mac2
> -      - description: interrupt event for ring rxdma2host-monitor-status-ring-mac1
> -      - description: interrupt event for ring host2rxdma-host-buf-ring-mac3
> -      - description: interrupt event for ring host2rxdma-host-buf-ring-mac2
> -      - description: interrupt event for ring host2rxdma-host-buf-ring-mac1
> -      - description: interrupt event for ring rxdma2host-destination-ring-mac3
> -      - description: interrupt event for ring rxdma2host-destination-ring-mac2
> -      - description: interrupt event for ring rxdma2host-destination-ring-mac1
> -      - description: interrupt event for ring host2tcl-input-ring4
> -      - description: interrupt event for ring host2tcl-input-ring3
> -      - description: interrupt event for ring host2tcl-input-ring2
> -      - description: interrupt event for ring host2tcl-input-ring1
> -      - description: interrupt event for ring wbm2host-tx-completions-ring3
> -      - description: interrupt event for ring wbm2host-tx-completions-ring2
> -      - description: interrupt event for ring wbm2host-tx-completions-ring1
> -      - description: interrupt event for ring tcl2host-status-ring
> +  reg-names:
> +    maxItems: 1
>  
> +  interrupts:
> +    minItems: 32
> +    maxItems: 52

You have to define what each interrupt is which you are not doing for 
6750.

      parent reply	other threads:[~2021-11-28 16:23 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-23 18:50 [PATCH 00/19] add support for WCN6750 Manikanta Pubbisetty
2021-11-23 18:50 ` [PATCH 01/19] ath11k: PCI changes to support WCN6750 Manikanta Pubbisetty
2021-11-23 18:50 ` [PATCH 02/19] ath11k: Refactor PCI code to support hybrid bus devices Manikanta Pubbisetty
2021-11-23 18:50 ` [PATCH 03/19] ath11k: Choose MSI config based on HW revision Manikanta Pubbisetty
2021-11-23 18:50 ` [PATCH 04/19] ath11k: Refactor MSI logic Manikanta Pubbisetty
2021-11-23 18:50 ` [PATCH 05/19] ath11k: Remove core PCI references from PCI common code Manikanta Pubbisetty
2021-11-23 18:50 ` [PATCH 06/19] ath11k: Add HW params for WCN6750 Manikanta Pubbisetty
2021-11-23 18:50 ` [PATCH 07/19] ath11k: Add bus " Manikanta Pubbisetty
2021-11-23 18:50 ` [PATCH 08/19] ath11k: Add register access logic " Manikanta Pubbisetty
2021-11-23 18:50 ` [PATCH 09/19] ath11k: Fetch device information via QMI " Manikanta Pubbisetty
2021-11-23 18:50 ` [PATCH 10/19] ath11k: Add QMI changes " Manikanta Pubbisetty
2021-11-23 18:50 ` [PATCH 11/19] ath11k: HAL changes to support WCN6750 Manikanta Pubbisetty
2021-11-23 18:50 ` [PATCH 12/19] ath11k: Datapath " Manikanta Pubbisetty
2021-11-23 18:50 ` [PATCH 13/19] ath11k: Fix RX de-fragmentation issue on WCN6750 Manikanta Pubbisetty
2021-11-23 18:50 ` [PATCH 14/19] ath11k: Do not put HW in DBS mode for WCN6750 Manikanta Pubbisetty
2021-11-23 18:50 ` [PATCH 15/19] ath11k: WMI changes to support WCN6750 Manikanta Pubbisetty
2021-11-23 18:50 ` [PATCH 16/19] ath11k: Update WBM idle ring HP after FW mode on Manikanta Pubbisetty
2021-11-23 18:50 ` [PATCH 17/19] ath11k: Add support for WCN6750 device Manikanta Pubbisetty
2021-11-23 18:50 ` [PATCH 18/19] ath11k: Add support for targets without trustzone Manikanta Pubbisetty
2021-11-23 18:50 ` [PATCH 19/19] dt: bindings: net: add bindings of WCN6750 for ath11k Manikanta Pubbisetty
2021-11-24  2:59   ` Rob Herring
2021-11-28 16:20   ` Rob Herring [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YaOsaxfXLmOtznYg@robh.at.kernel.org \
    --to=robh@kernel.org \
    --cc=ath11k@lists.infradead.org \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=quic_mpubbise@quicinc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).