* [PATCH] mt76: connac: adjust wlan_idx size from u8 to u16
@ 2022-02-12 18:04 Chad Monroe
2022-02-13 17:21 ` Lorenzo Bianconi
0 siblings, 1 reply; 2+ messages in thread
From: Chad Monroe @ 2022-02-12 18:04 UTC (permalink / raw)
To: Felix Fietkau, Johannes Berg
Cc: Lorenzo Bianconi, Shayne Chen, Evelyn Tsai, Ryder Lee,
linux-wireless, linux-mediatek, Chad Monroe
Newer chips such as MT7915 require up to 16-bits for this field.
Signed-off-by: Chad Monroe <chad.monroe@smartrg.com>
---
drivers/net/wireless/mediatek/mt76/mt76_connac_mcu.c | 2 +-
drivers/net/wireless/mediatek/mt76/mt76_connac_mcu.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/wireless/mediatek/mt76/mt76_connac_mcu.c b/drivers/net/wireless/mediatek/mt76/mt76_connac_mcu.c
index cdd82a62eeb1..f3fdd755a3bb 100644
--- a/drivers/net/wireless/mediatek/mt76/mt76_connac_mcu.c
+++ b/drivers/net/wireless/mediatek/mt76/mt76_connac_mcu.c
@@ -2656,7 +2656,7 @@ EXPORT_SYMBOL_GPL(mt76_connac_mcu_bss_ext_tlv);
int mt76_connac_mcu_bss_basic_tlv(struct sk_buff *skb,
struct ieee80211_vif *vif,
struct ieee80211_sta *sta,
- struct mt76_phy *phy, u8 wlan_idx,
+ struct mt76_phy *phy, u16 wlan_idx,
bool enable)
{
struct mt76_vif *mvif = (struct mt76_vif *)vif->drv_priv;
diff --git a/drivers/net/wireless/mediatek/mt76/mt76_connac_mcu.h b/drivers/net/wireless/mediatek/mt76/mt76_connac_mcu.h
index 7b9d82dd3f9d..384c3eab1c8a 100644
--- a/drivers/net/wireless/mediatek/mt76/mt76_connac_mcu.h
+++ b/drivers/net/wireless/mediatek/mt76/mt76_connac_mcu.h
@@ -1642,7 +1642,7 @@ void mt76_connac_mcu_bss_omac_tlv(struct sk_buff *skb,
int mt76_connac_mcu_bss_basic_tlv(struct sk_buff *skb,
struct ieee80211_vif *vif,
struct ieee80211_sta *sta,
- struct mt76_phy *phy, u8 wlan_idx,
+ struct mt76_phy *phy, u16 wlan_idx,
bool enable);
void mt76_connac_mcu_sta_uapsd(struct sk_buff *skb, struct ieee80211_vif *vif,
struct ieee80211_sta *sta);
--
2.32.0 (Apple Git-132)
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] mt76: connac: adjust wlan_idx size from u8 to u16
2022-02-12 18:04 [PATCH] mt76: connac: adjust wlan_idx size from u8 to u16 Chad Monroe
@ 2022-02-13 17:21 ` Lorenzo Bianconi
0 siblings, 0 replies; 2+ messages in thread
From: Lorenzo Bianconi @ 2022-02-13 17:21 UTC (permalink / raw)
To: Chad Monroe
Cc: Felix Fietkau, Johannes Berg, Shayne Chen, Evelyn Tsai,
Ryder Lee, linux-wireless, linux-mediatek
[-- Attachment #1: Type: text/plain, Size: 2004 bytes --]
Thx for fixing it.
I guess we can add the following Fixes tag:
Fixes: 49126ac1f8d26 ("mt76: connac: move mt76_connac_mcu_bss_basic_tlv in connac module")
Anyway:
Acked-by: Lorenzo Bianconi <lorenzo@kernel.org>
> Newer chips such as MT7915 require up to 16-bits for this field.
>
> Signed-off-by: Chad Monroe <chad.monroe@smartrg.com>
> ---
> drivers/net/wireless/mediatek/mt76/mt76_connac_mcu.c | 2 +-
> drivers/net/wireless/mediatek/mt76/mt76_connac_mcu.h | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/wireless/mediatek/mt76/mt76_connac_mcu.c b/drivers/net/wireless/mediatek/mt76/mt76_connac_mcu.c
> index cdd82a62eeb1..f3fdd755a3bb 100644
> --- a/drivers/net/wireless/mediatek/mt76/mt76_connac_mcu.c
> +++ b/drivers/net/wireless/mediatek/mt76/mt76_connac_mcu.c
> @@ -2656,7 +2656,7 @@ EXPORT_SYMBOL_GPL(mt76_connac_mcu_bss_ext_tlv);
> int mt76_connac_mcu_bss_basic_tlv(struct sk_buff *skb,
> struct ieee80211_vif *vif,
> struct ieee80211_sta *sta,
> - struct mt76_phy *phy, u8 wlan_idx,
> + struct mt76_phy *phy, u16 wlan_idx,
> bool enable)
> {
> struct mt76_vif *mvif = (struct mt76_vif *)vif->drv_priv;
> diff --git a/drivers/net/wireless/mediatek/mt76/mt76_connac_mcu.h b/drivers/net/wireless/mediatek/mt76/mt76_connac_mcu.h
> index 7b9d82dd3f9d..384c3eab1c8a 100644
> --- a/drivers/net/wireless/mediatek/mt76/mt76_connac_mcu.h
> +++ b/drivers/net/wireless/mediatek/mt76/mt76_connac_mcu.h
> @@ -1642,7 +1642,7 @@ void mt76_connac_mcu_bss_omac_tlv(struct sk_buff *skb,
> int mt76_connac_mcu_bss_basic_tlv(struct sk_buff *skb,
> struct ieee80211_vif *vif,
> struct ieee80211_sta *sta,
> - struct mt76_phy *phy, u8 wlan_idx,
> + struct mt76_phy *phy, u16 wlan_idx,
> bool enable);
> void mt76_connac_mcu_sta_uapsd(struct sk_buff *skb, struct ieee80211_vif *vif,
> struct ieee80211_sta *sta);
> --
> 2.32.0 (Apple Git-132)
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-02-13 17:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-12 18:04 [PATCH] mt76: connac: adjust wlan_idx size from u8 to u16 Chad Monroe
2022-02-13 17:21 ` Lorenzo Bianconi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).