* [PATCH] brcmsmac: ampdu: remove unused suc_mpdu variable
@ 2023-03-27 15:11 Tom Rix
2023-03-28 15:09 ` Simon Horman
2023-03-31 14:53 ` wifi: " Kalle Valo
0 siblings, 2 replies; 3+ messages in thread
From: Tom Rix @ 2023-03-27 15:11 UTC (permalink / raw)
To: aspriel, franky.lin, hante.meuleman, kvalo, davem, edumazet,
kuba, pabeni, nathan, ndesaulniers
Cc: linux-wireless, brcm80211-dev-list.pdl, SHA-cyfmac-dev-list,
netdev, linux-kernel, llvm, Tom Rix
clang with W=1 reports
drivers/net/wireless/broadcom/brcm80211/brcmsmac/ampdu.c:848:5: error: variable
'suc_mpdu' set but not used [-Werror,-Wunused-but-set-variable]
u8 suc_mpdu = 0, tot_mpdu = 0;
^
This variable is not used so remove it.
Signed-off-by: Tom Rix <trix@redhat.com>
---
drivers/net/wireless/broadcom/brcm80211/brcmsmac/ampdu.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmsmac/ampdu.c b/drivers/net/wireless/broadcom/brcm80211/brcmsmac/ampdu.c
index 2631eb7569eb..e24228e60027 100644
--- a/drivers/net/wireless/broadcom/brcm80211/brcmsmac/ampdu.c
+++ b/drivers/net/wireless/broadcom/brcm80211/brcmsmac/ampdu.c
@@ -845,7 +845,7 @@ brcms_c_ampdu_dotxstatus_complete(struct ampdu_info *ampdu, struct scb *scb,
u16 seq, start_seq = 0, bindex, index, mcl;
u8 mcs = 0;
bool ba_recd = false, ack_recd = false;
- u8 suc_mpdu = 0, tot_mpdu = 0;
+ u8 tot_mpdu = 0;
uint supr_status;
bool retry = true;
u16 mimoantsel = 0;
@@ -975,7 +975,6 @@ brcms_c_ampdu_dotxstatus_complete(struct ampdu_info *ampdu, struct scb *scb,
ieee80211_tx_status_irqsafe(wlc->pub->ieee_hw,
p);
ack_recd = true;
- suc_mpdu++;
}
}
/* either retransmit or send bar if ack not recd */
--
2.27.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] brcmsmac: ampdu: remove unused suc_mpdu variable
2023-03-27 15:11 [PATCH] brcmsmac: ampdu: remove unused suc_mpdu variable Tom Rix
@ 2023-03-28 15:09 ` Simon Horman
2023-03-31 14:53 ` wifi: " Kalle Valo
1 sibling, 0 replies; 3+ messages in thread
From: Simon Horman @ 2023-03-28 15:09 UTC (permalink / raw)
To: Tom Rix
Cc: aspriel, franky.lin, hante.meuleman, kvalo, davem, edumazet,
kuba, pabeni, nathan, ndesaulniers, linux-wireless,
brcm80211-dev-list.pdl, SHA-cyfmac-dev-list, netdev,
linux-kernel, llvm
On Mon, Mar 27, 2023 at 11:11:51AM -0400, Tom Rix wrote:
> clang with W=1 reports
> drivers/net/wireless/broadcom/brcm80211/brcmsmac/ampdu.c:848:5: error: variable
> 'suc_mpdu' set but not used [-Werror,-Wunused-but-set-variable]
> u8 suc_mpdu = 0, tot_mpdu = 0;
> ^
> This variable is not used so remove it.
>
> Signed-off-by: Tom Rix <trix@redhat.com>
Reviewed-by: Simon Horman <simon.horman@corigine.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: wifi: brcmsmac: ampdu: remove unused suc_mpdu variable
2023-03-27 15:11 [PATCH] brcmsmac: ampdu: remove unused suc_mpdu variable Tom Rix
2023-03-28 15:09 ` Simon Horman
@ 2023-03-31 14:53 ` Kalle Valo
1 sibling, 0 replies; 3+ messages in thread
From: Kalle Valo @ 2023-03-31 14:53 UTC (permalink / raw)
To: Tom Rix
Cc: aspriel, franky.lin, hante.meuleman, davem, edumazet, kuba,
pabeni, nathan, ndesaulniers, linux-wireless,
brcm80211-dev-list.pdl, SHA-cyfmac-dev-list, netdev,
linux-kernel, llvm, Tom Rix
Tom Rix <trix@redhat.com> wrote:
> clang with W=1 reports
> drivers/net/wireless/broadcom/brcm80211/brcmsmac/ampdu.c:848:5: error: variable
> 'suc_mpdu' set but not used [-Werror,-Wunused-but-set-variable]
> u8 suc_mpdu = 0, tot_mpdu = 0;
> ^
> This variable is not used so remove it.
>
> Signed-off-by: Tom Rix <trix@redhat.com>
> Reviewed-by: Simon Horman <simon.horman@corigine.com>
Patch applied to wireless-next.git, thanks.
2f73f04b7f93 wifi: brcmsmac: ampdu: remove unused suc_mpdu variable
--
https://patchwork.kernel.org/project/linux-wireless/patch/20230327151151.1771350-1-trix@redhat.com/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-03-31 14:54 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-27 15:11 [PATCH] brcmsmac: ampdu: remove unused suc_mpdu variable Tom Rix
2023-03-28 15:09 ` Simon Horman
2023-03-31 14:53 ` wifi: " Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).