* [PATCH] drivers: net: wlcore: remove duplicate \n for some warnings
@ 2018-07-25 5:55 H. Nikolaus Schaller
2018-07-25 6:40 ` Kalle Valo
2018-07-31 7:23 ` [PATCH] " Kalle Valo
0 siblings, 2 replies; 5+ messages in thread
From: H. Nikolaus Schaller @ 2018-07-25 5:55 UTC (permalink / raw)
To: Kalle Valo, Arnd Bergmann, Reizer, Eyal, Kees Cook, H. Nikolaus Schaller
Cc: linux-wireless, netdev, linux-kernel, letux-kernel, kernel
wl1271_warning() already appends a \n to the format,
so adding one to the warning string gives empty lines in the log.
Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com>
---
drivers/net/wireless/ti/wlcore/main.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/net/wireless/ti/wlcore/main.c b/drivers/net/wireless/ti/wlcore/main.c
index 3a51ab116e79..ab34d41487d3 100644
--- a/drivers/net/wireless/ti/wlcore/main.c
+++ b/drivers/net/wireless/ti/wlcore/main.c
@@ -6065,16 +6065,16 @@ static int wl1271_register_hw(struct wl1271 *wl)
}
if (oui_addr == 0xdeadbe && nic_addr == 0xef0000) {
- wl1271_warning("Detected unconfigured mac address in nvs, derive from fuse instead.\n");
+ wl1271_warning("Detected unconfigured mac address in nvs, derive from fuse instead.");
if (!strcmp(pdev_data->family->name, "wl18xx")) {
- wl1271_warning("This default nvs file can be removed from the file system\n");
+ wl1271_warning("This default nvs file can be removed from the file system");
} else {
- wl1271_warning("Your device performance is not optimized.\n");
- wl1271_warning("Please use the calibrator tool to configure your device.\n");
+ wl1271_warning("Your device performance is not optimized.");
+ wl1271_warning("Please use the calibrator tool to configure your device.");
}
if (wl->fuse_oui_addr == 0 && wl->fuse_nic_addr == 0) {
- wl1271_warning("Fuse mac address is zero. using random mac\n");
+ wl1271_warning("Fuse mac address is zero. using random mac");
/* Use TI oui and a random nic */
oui_addr = WLCORE_TI_OUI_ADDRESS;
nic_addr = get_random_int();
--
2.12.2
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] drivers: net: wlcore: remove duplicate \n for some warnings
2018-07-25 5:55 [PATCH] drivers: net: wlcore: remove duplicate \n for some warnings H. Nikolaus Schaller
@ 2018-07-25 6:40 ` Kalle Valo
2018-07-25 8:30 ` H. Nikolaus Schaller
2018-07-31 7:23 ` [PATCH] " Kalle Valo
1 sibling, 1 reply; 5+ messages in thread
From: Kalle Valo @ 2018-07-25 6:40 UTC (permalink / raw)
To: H. Nikolaus Schaller
Cc: Arnd Bergmann, Reizer, Eyal, Kees Cook, linux-wireless, netdev,
linux-kernel, letux-kernel, kernel
"H. Nikolaus Schaller" <hns@goldelico.com> writes:
> wl1271_warning() already appends a \n to the format,
> so adding one to the warning string gives empty lines in the log.
>
> Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com>
"drivers: net:" in the title is unnecessary, but I can remove that.
--
Kalle Valo
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drivers: net: wlcore: remove duplicate \n for some warnings
2018-07-25 6:40 ` Kalle Valo
@ 2018-07-25 8:30 ` H. Nikolaus Schaller
2018-07-25 8:40 ` Kalle Valo
0 siblings, 1 reply; 5+ messages in thread
From: H. Nikolaus Schaller @ 2018-07-25 8:30 UTC (permalink / raw)
To: Kalle Valo
Cc: Arnd Bergmann, Reizer, Eyal, Kees Cook, linux-wireless, netdev,
linux-kernel, letux-kernel, kernel
> Am 25.07.2018 um 08:40 schrieb Kalle Valo <kvalo@codeaurora.org>:
>
> "H. Nikolaus Schaller" <hns@goldelico.com> writes:
>
>> wl1271_warning() already appends a \n to the format,
>> so adding one to the warning string gives empty lines in the log.
>>
>> Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com>
>
> "drivers: net:" in the title is unnecessary, but I can remove that.
Ok, thanks! I wasn't aware of the precise subsystem tagging style here.
BR,
Nikolaus
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drivers: net: wlcore: remove duplicate \n for some warnings
2018-07-25 8:30 ` H. Nikolaus Schaller
@ 2018-07-25 8:40 ` Kalle Valo
0 siblings, 0 replies; 5+ messages in thread
From: Kalle Valo @ 2018-07-25 8:40 UTC (permalink / raw)
To: H. Nikolaus Schaller
Cc: Arnd Bergmann, Reizer, Eyal, Kees Cook, linux-wireless, netdev,
linux-kernel, letux-kernel, kernel
"H. Nikolaus Schaller" <hns@goldelico.com> writes:
>> Am 25.07.2018 um 08:40 schrieb Kalle Valo <kvalo@codeaurora.org>:
>>
>> "H. Nikolaus Schaller" <hns@goldelico.com> writes:
>>
>>> wl1271_warning() already appends a \n to the format,
>>> so adding one to the warning string gives empty lines in the log.
>>>
>>> Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com>
>>
>> "drivers: net:" in the title is unnecessary, but I can remove that.
>
> Ok, thanks! I wasn't aware of the precise subsystem tagging style here.
Yeah, subsystems can do it a bit differently. But you can easily check
with git log the preferred style:
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#subject
--
Kalle Valo
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] wlcore: remove duplicate \n for some warnings
2018-07-25 5:55 [PATCH] drivers: net: wlcore: remove duplicate \n for some warnings H. Nikolaus Schaller
2018-07-25 6:40 ` Kalle Valo
@ 2018-07-31 7:23 ` Kalle Valo
1 sibling, 0 replies; 5+ messages in thread
From: Kalle Valo @ 2018-07-31 7:23 UTC (permalink / raw)
To: H. Nikolaus Schaller
Cc: Arnd Bergmann, Reizer, Eyal, Kees Cook, H. Nikolaus Schaller,
linux-wireless, netdev, linux-kernel, letux-kernel, kernel
"H. Nikolaus Schaller" <hns@goldelico.com> wrote:
> wl1271_warning() already appends a \n to the format,
> so adding one to the warning string gives empty lines in the log.
>
> Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com>
Patch applied to wireless-drivers-next.git, thanks.
18dc5a4bbcc5 wlcore: remove duplicate \n for some warnings
--
https://patchwork.kernel.org/patch/10543473/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-07-31 9:02 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-25 5:55 [PATCH] drivers: net: wlcore: remove duplicate \n for some warnings H. Nikolaus Schaller
2018-07-25 6:40 ` Kalle Valo
2018-07-25 8:30 ` H. Nikolaus Schaller
2018-07-25 8:40 ` Kalle Valo
2018-07-31 7:23 ` [PATCH] " Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).