From: Andrey Ryabinin <aryabinin@virtuozzo.com>
To: Ryan Hsu <ryanhsu@qti.qualcomm.com>,
Igor Mitsyanko <igor.mitsyanko.os@quantenna.com>,
Kalle Valo <kvalo@qca.qualcomm.com>
Cc: Networking <netdev@vger.kernel.org>,
linux-wireless <linux-wireless@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
"ath10k@lists.infradead.org" <ath10k@lists.infradead.org>
Subject: Re: WARN_ON_ONCE(work > weight) in napi_poll()
Date: Mon, 24 Jul 2017 12:30:44 +0300 [thread overview]
Message-ID: <b5e60c2f-c719-0c65-f2c4-bb280fee2eb7@virtuozzo.com> (raw)
In-Reply-To: <daa2fbf9-ac75-a7eb-f2b7-054dfae6fc56@qca.qualcomm.com>
On 07/18/2017 09:47 AM, Ryan Hsu wrote:
> On 07/11/2017 06:19 PM, Igor Mitsyanko wrote:
>
>> On 07/11/2017 10:28 AM, Andrey Ryabinin wrote:
>>>
>>> It gave me this:
>>>
>>> [118648.825347] #1 quota too big 72 64 16
>>> [118648.825351] #2 quota too big 72 64 16
>>> [118648.825471] ------------[ cut here ]------------
>>> [118648.825484] WARNING: CPU: 0 PID: 0 at ../net/core/dev.c:5274 net_rx_action+0x258/0x360
>>>
>>> So this means that we didn't met the condition bellow, i.e. skb_queue_empty() returned true.
>>>
>>> ath10k_htt_txrx_compl_task():
>>>
>>> if ((quota > ATH10K_NAPI_QUOTA_LIMIT) &&
>>> !skb_queue_empty(&htt->rx_in_ord_compl_q)) {
>>> resched_napi = true;
>>> goto exit;
>>> }
>>>
>>>> Also WLAN.RM.2.0-00180-QCARMSWPZ-1 firmware is a bit old, could you also update firmware to give it a try?
>>>> https://github.com/kvalo/ath10k-firmware/tree/master/QCA6174/hw3.0/4.4
>>>>
>>>
>>> Will try.
>>>
>>
>> Maybe ath10k_htt_rx_in_ord_ind() has to accept "budget_left" parameter and use it to limit number of processed MSDUs in queued AMSDU and saving rest for later (NAPI has to be rescheduled in this case).
>> It seems natural that this problem happens with current logic, in case AMSDU in Rx queue has more elements then left in budget.
>
> Thanks, likely in current logic, it does have chance to exceed the budget while dequeuing from the last list.
>
> Can you give it a try this one? for QCA6174 reorder is offload, so this should be good enough for your case to test, will have to check non-offload reorder case... but let me know if you're seeing something different....
>
I've been running with this patch almost a week and haven't seen the WARNING. One week is usually enough to trigger it several times.
I guess we can assume that the patch fixed the problem.
prev parent reply other threads:[~2017-07-24 9:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-30 16:34 WARN_ON_ONCE(work > weight) in napi_poll() Andrey Ryabinin
2017-07-04 13:49 ` Kalle Valo
2017-07-04 15:59 ` Andrey Ryabinin
2017-07-10 21:24 ` Ryan Hsu
2017-07-11 17:28 ` Andrey Ryabinin
2017-07-12 1:19 ` Igor Mitsyanko
2017-07-18 6:47 ` Ryan Hsu
2017-07-24 9:30 ` Andrey Ryabinin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b5e60c2f-c719-0c65-f2c4-bb280fee2eb7@virtuozzo.com \
--to=aryabinin@virtuozzo.com \
--cc=ath10k@lists.infradead.org \
--cc=igor.mitsyanko.os@quantenna.com \
--cc=kvalo@qca.qualcomm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=ryanhsu@qti.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).