* [PATCH v2] mt76: eeprom: tolerate corrected bit-flips
@ 2021-11-25 19:45 Daniel Golle
2021-11-28 18:34 ` Hauke Mehrtens
2021-12-02 16:26 ` Felix Fietkau
0 siblings, 2 replies; 3+ messages in thread
From: Daniel Golle @ 2021-11-25 19:45 UTC (permalink / raw)
To: linux-mediatek, linux-wireless
Cc: Ryder Lee, Lorenzo Bianconi, Felix Fietkau, Hauke Mehrtens
mtd_read() returns -EUCLEAN in case of corrected bit-flips.
As data was read, don't error out in this case.
Signed-off-by: Daniel Golle <daniel@makrotopia.org>
---
v2: fix wrong variable name
drivers/net/wireless/mediatek/mt76/eeprom.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/mediatek/mt76/eeprom.c b/drivers/net/wireless/mediatek/mt76/eeprom.c
index 2d58aa31db934..4a5d14473ddc4 100644
--- a/drivers/net/wireless/mediatek/mt76/eeprom.c
+++ b/drivers/net/wireless/mediatek/mt76/eeprom.c
@@ -65,7 +65,7 @@ int mt76_get_of_eeprom(struct mt76_dev *dev, void *eep, int offset, int len)
offset = be32_to_cpup(list);
ret = mtd_read(mtd, offset, len, &retlen, eep);
put_mtd_device(mtd);
- if (ret) {
+ if (ret && !mtd_is_bitflip(ret)) {
dev_err(dev->dev, "reading EEPROM from mtd %s failed: %i\n",
part, ret);
goto out_put_node;
--
2.34.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] mt76: eeprom: tolerate corrected bit-flips
2021-11-25 19:45 [PATCH v2] mt76: eeprom: tolerate corrected bit-flips Daniel Golle
@ 2021-11-28 18:34 ` Hauke Mehrtens
2021-12-02 16:26 ` Felix Fietkau
1 sibling, 0 replies; 3+ messages in thread
From: Hauke Mehrtens @ 2021-11-28 18:34 UTC (permalink / raw)
To: Daniel Golle, linux-mediatek, linux-wireless
Cc: Ryder Lee, Lorenzo Bianconi, Felix Fietkau
On 11/25/21 8:45 PM, Daniel Golle wrote:
> mtd_read() returns -EUCLEAN in case of corrected bit-flips.
> As data was read, don't error out in this case.
>
> Signed-off-by: Daniel Golle <daniel@makrotopia.org>
Acked-by: Hauke Mehrtens <hauke@hauke-m.de>
I tried a similar patch on my device before and it solved the problem too.
> ---
> v2: fix wrong variable name
>
> drivers/net/wireless/mediatek/mt76/eeprom.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/mediatek/mt76/eeprom.c b/drivers/net/wireless/mediatek/mt76/eeprom.c
> index 2d58aa31db934..4a5d14473ddc4 100644
> --- a/drivers/net/wireless/mediatek/mt76/eeprom.c
> +++ b/drivers/net/wireless/mediatek/mt76/eeprom.c
> @@ -65,7 +65,7 @@ int mt76_get_of_eeprom(struct mt76_dev *dev, void *eep, int offset, int len)
> offset = be32_to_cpup(list);
> ret = mtd_read(mtd, offset, len, &retlen, eep);
> put_mtd_device(mtd);
> - if (ret) {
> + if (ret && !mtd_is_bitflip(ret)) {
> dev_err(dev->dev, "reading EEPROM from mtd %s failed: %i\n",
> part, ret);
> goto out_put_node;
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] mt76: eeprom: tolerate corrected bit-flips
2021-11-25 19:45 [PATCH v2] mt76: eeprom: tolerate corrected bit-flips Daniel Golle
2021-11-28 18:34 ` Hauke Mehrtens
@ 2021-12-02 16:26 ` Felix Fietkau
1 sibling, 0 replies; 3+ messages in thread
From: Felix Fietkau @ 2021-12-02 16:26 UTC (permalink / raw)
To: Daniel Golle, linux-mediatek, linux-wireless
Cc: Ryder Lee, Lorenzo Bianconi, Hauke Mehrtens
Hi,
On 2021-11-25 20:45, Daniel Golle wrote:
> mtd_read() returns -EUCLEAN in case of corrected bit-flips.
> As data was read, don't error out in this case.
>
> Signed-off-by: Daniel Golle <daniel@makrotopia.org>
> ---
> v2: fix wrong variable name
>
> drivers/net/wireless/mediatek/mt76/eeprom.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/mediatek/mt76/eeprom.c b/drivers/net/wireless/mediatek/mt76/eeprom.c
> index 2d58aa31db934..4a5d14473ddc4 100644
> --- a/drivers/net/wireless/mediatek/mt76/eeprom.c
> +++ b/drivers/net/wireless/mediatek/mt76/eeprom.c
> @@ -65,7 +65,7 @@ int mt76_get_of_eeprom(struct mt76_dev *dev, void *eep, int offset, int len)
> offset = be32_to_cpup(list);
> ret = mtd_read(mtd, offset, len, &retlen, eep);
> put_mtd_device(mtd);
> - if (ret) {
> + if (ret && !mtd_is_bitflip(ret)) {
unfortunately the patch is still incomplete. I will fold in the
following change to make it work:
---
--- a/drivers/net/wireless/mediatek/mt76/eeprom.c
+++ b/drivers/net/wireless/mediatek/mt76/eeprom.c
@@ -65,7 +65,9 @@ int mt76_get_of_eeprom(struct mt76_dev *dev, void *eep, int offset, int len)
offset = be32_to_cpup(list);
ret = mtd_read(mtd, offset, len, &retlen, eep);
put_mtd_device(mtd);
- if (ret && !mtd_is_bitflip(ret)) {
+ if (mtd_is_bitflip(ret))
+ ret = 0;
+ if (ret) {
dev_err(dev->dev, "reading EEPROM from mtd %s failed: %i\n",
part, ret);
goto out_put_node;
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-12-02 16:27 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-25 19:45 [PATCH v2] mt76: eeprom: tolerate corrected bit-flips Daniel Golle
2021-11-28 18:34 ` Hauke Mehrtens
2021-12-02 16:26 ` Felix Fietkau
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).